OrdisPrime
  • Joined on 2025-02-01
OrdisPrime merged pull request OpenWF/SpaceNinjaServer#1592 2025-04-13 05:50:52 -07:00
feat: handle duet encounter
OrdisPrime commented on issue OpenWF/SpaceNinjaServer#1477 2025-04-06 13:56:26 -07:00
Visual-only inbox attachments

Damn, might want to add an exception for certain items then? Since, I am relatively certain inbox behaves the same as official hm

OrdisPrime commented on issue OpenWF/SpaceNinjaServer#1477 2025-04-06 13:51:46 -07:00
Visual-only inbox attachments

Did you confirm that its actually given twice? I suspect, the lua script does not call the giveKeyChainItem anymore and it is a leftover

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1290 2025-03-23 05:28:55 -07:00
fix: use deleteMany for models where accountId is not unique when deleting account

I was wondering why accounts can be non-unique in a guild member list?

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1227 2025-03-18 12:18:45 -07:00
feat: start nemesis

otherwise, nice pr

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1227 2025-03-18 12:17:09 -07:00
feat: start nemesis

lets keep this out tho, the lack of support there is uncomfortable, but lets keep our code.. noice

OrdisPrime deleted branch mastery-slates from OpenWF/SpaceNinjaServer 2025-03-17 12:23:18 -07:00
OrdisPrime closed issue OpenWF/SpaceNinjaServer#1203 2025-03-17 12:23:17 -07:00
Mastery Rank Up Inbox Message
OrdisPrime merged pull request OpenWF/SpaceNinjaServer#1206 2025-03-17 12:23:17 -07:00
feat: mastery rank up inbox message
OrdisPrime pushed to main at OpenWF/SpaceNinjaServer 2025-03-17 12:23:17 -07:00
b4da457501 feat: mastery rank up inbox message (#1206)
OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1206 2025-03-17 12:22:55 -07:00
feat: mastery rank up inbox message

Yeah, it's a number in my inbox messages. Weird situation, well in that case we gotta use mixed, you are right. PR is good to go

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1206 2025-03-17 12:17:00 -07:00
feat: mastery rank up inbox message

I think this might be a DE moment, and the client can just work with both. It just work when a number is supplied, right? I sadly can't try now.

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1206 2025-03-17 12:09:36 -07:00
feat: mastery rank up inbox message

tag can be a number? I don't see why this pr needs that change, so I don't know where it's coming from

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1206 2025-03-17 12:08:53 -07:00
feat: mastery rank up inbox message

why use mixed here? its the same as allowing everything. We should certainly not use mixed for anything that was validated.

OrdisPrime commented on issue OpenWF/SpaceNinjaServer#1208 2025-03-16 19:14:29 -07:00
/Lotus/Types/Keys/NewWarQuest/TNWActTwoArchonNira

I will sadly only be able to work on sns again after the 25th

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1176 2025-03-14 06:24:04 -07:00
chore: fix various eslint issues

Right, however I don't think validation or casting is required during retrieval of a document, since that also happens during saving, so it should be impossible to even have invalid objects. Other…

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1176 2025-03-14 06:14:08 -07:00
chore: fix various eslint issues

I left the function there as a reminder to do that

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1176 2025-03-14 06:13:18 -07:00
chore: fix various eslint issues

hydration is ONLY needed when you want to use a mongoose document's functions. So, all get requests should generally only use .lean() versions, so mongoose doesn't hydrate them (which takes lots…

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1176 2025-03-14 06:08:07 -07:00
chore: fix various eslint issues

only because this function is currently not used, does not mean it has to be deleted.