Incorrect handling of adding/removing ship decorations #2277

New Issue

ricochet · 2025-06-24T13:53:58-07:00

ricochet commented

2025-06-24 13:53:58 -07:00

using /Lotus/Types/Items/ShipDecos/Hollvania/LASxDiningTableA (Dining Table) as an example, if you have some in your ShipDecorations inventory, and place one down, it will be added to ShipDecorations as this:

{
  "ItemType": "/Lotus/Objects/Tenno/Props/1999Placeables/ShipDecos/LASxDiningTableADeco",
  "ItemCount": -1
},

this seems like the wrong item type as its listed in my ShipDecorations as /Lotus/Types/Items/ShipDecos/Hollvania/LASxDiningTableA, currently the ship deco count never goes down cuz of this, adding it back to your inventory / removing it from the ship will actually remove the (incorrect?) entry like the one above, visually when you first place it, it will seem like the value goes down in the ui, but reloading the area makes it go back to the initial value

current result after placing this item is this (I start with 50):

{
  "ItemType": "/Lotus/Types/Items/ShipDecos/Hollvania/LASxDiningTableA",
  "ItemCount": 50
}

when it should be this:

{
  "ItemType": "/Lotus/Types/Items/ShipDecos/Hollvania/LASxDiningTableA",
  "ItemCount": 49
}

you'll also get spammed with warnings about inventory.ShipDecorations having a negative amount for types when placing decos cuz of this

using `/Lotus/Types/Items/ShipDecos/Hollvania/LASxDiningTableA` (Dining Table) as an example, if you have some in your ShipDecorations inventory, and place one down, it will be added to ShipDecorations as this: ```json { "ItemType": "/Lotus/Objects/Tenno/Props/1999Placeables/ShipDecos/LASxDiningTableADeco", "ItemCount": -1 }, ``` this seems like the wrong item type as its listed in my ShipDecorations as `/Lotus/Types/Items/ShipDecos/Hollvania/LASxDiningTableA`, currently the ship deco count never goes down cuz of this, adding it back to your inventory / removing it from the ship will actually remove the (incorrect?) entry like the one above, visually when you first place it, it will seem like the value goes down in the ui, but reloading the area makes it go back to the initial value current result after placing this item is this (I start with 50): ```json { "ItemType": "/Lotus/Types/Items/ShipDecos/Hollvania/LASxDiningTableA", "ItemCount": 50 } ``` when it should be this: ```json { "ItemType": "/Lotus/Types/Items/ShipDecos/Hollvania/LASxDiningTableA", "ItemCount": 49 } ``` you'll also get spammed with warnings about inventory.ShipDecorations having a negative amount for types when placing decos cuz of this

Sainan added the

bug

label 2025-06-24 16:53:06 -07:00

Sainan referenced a pull request that will close this issue

2025-06-24 17:14:08 -07:00

fix: properly convert personal room decos to and from inventory types #2279

Sainan added the

pr'd for

label 2025-06-24 17:14:23 -07:00

OrdisPrime closed this issue

2025-06-25 08:03:57 -07:00

OrdisPrime referenced this issue from a commit