OpenWF/SpaceNinjaServer
19
21
Fork 23
Code Issues 27 Pull Requests 6 Actions Packages Projects Releases Activity

fix: use shared count for calendar day indecies #2265

Merged
OrdisPrime merged 5 commits from cal-fix-ii into main 2025-06-23 15:02:31 -07:00
Conversation 0 Commits 5 Files Changed 3 +51 -27
Sainan commented 2025-06-23 13:13:03 -07:00
Owner
Copy Link

I'm not sure if this was always this way and I was just really confused when I initially implemented this, or if this was changed in a later version, but at least now it seems to be tracking everything correctly for 38.6.0.

Closes #2264

I'm not sure if this was always this way and I was just really confused when I initially implemented this, or if this was changed in a later version, but at least now it seems to be tracking everything correctly for 38.6.0. Closes #2264
Sainan added 1 commit 2025-06-23 13:13:03 -07:00
fix: use shared count for calendar day indecies
All checks were successful
Build / build (pull_request) Successful in 1m25s
Details
043ffeecef 
I'm not sure if this was always this way and I was just really confused when I initially implemented this, or if this was changed in a later version, but at least now it seems to be tracking everything correctly for 38.6.0, just not entirely sure what "ActivatedChallenges" is for.
Sainan added 1 commit 2025-06-23 13:15:49 -07:00
remove intermediate variable
All checks were successful
Build / build (pull_request) Successful in 52s
Details
c4404e2942
Sainan added 1 commit 2025-06-23 13:19:53 -07:00
simplify completeCalendarEvent, codify assumption that it's not used for challenges
All checks were successful
Build / build (pull_request) Successful in 52s
Details
29a465b183
Sainan added 1 commit 2025-06-23 13:20:36 -07:00
combine conditions
All checks were successful
Build / build (pull_request) Successful in 1m28s
Details
917d82c707
Sainan added 1 commit 2025-06-23 13:27:37 -07:00
track season ActivatedChallenges
All checks were successful
Build / build (pull_request) Successful in 1m31s
Details
6cd897b63a
OrdisPrime merged commit 444c92f0c6 into main 2025-06-23 15:02:31 -07:00
OrdisPrime deleted branch cal-fix-ii 2025-06-23 15:02:31 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2265
No description provided.
Delete Branch "cal-fix-ii"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?