OrdisPrime
  • Joined on 2025-02-01
OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#978 2025-02-20 02:55:23 -08:00
WIP: chore: send messages after completing quest

just use giveKeyChainMessage with the correct keychain info.

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#977 2025-02-20 02:53:43 -08:00
feat: implement awakening quest completion (/api/giveStartingGear)

use the game supplied values for creating inventory items.

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#977 2025-02-20 02:52:40 -08:00
feat: implement awakening quest completion (/api/giveStartingGear)

this should not be here, the game handles trigger items itself.

OrdisPrime closed issue OpenWF/SpaceNinjaServer#964 2025-02-19 14:09:53 -08:00
Quests: Completing All Unlocked Quests does not set Active Quest.
OrdisPrime deleted branch fix-completeallunlocked from OpenWF/SpaceNinjaServer 2025-02-19 14:09:50 -08:00
OrdisPrime pushed to main at OpenWF/SpaceNinjaServer 2025-02-19 14:09:49 -08:00
fb8d176fbe fix(webui): quest cheats (#965)
OrdisPrime merged pull request OpenWF/SpaceNinjaServer#965 2025-02-19 14:09:47 -08:00
fix(webui): quest cheats
OrdisPrime pushed to main at OpenWF/SpaceNinjaServer 2025-02-19 14:09:04 -08:00
b551563681 fix: save settings when accepting trade policy. (#966)
OrdisPrime merged pull request OpenWF/SpaceNinjaServer#966 2025-02-19 14:09:02 -08:00
fix: Unable to save settings when accepting trade policy.
OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#970 2025-02-19 13:50:19 -08:00
chore: handle motorcycle in addItems

i would like not to use as object[] defeats the purpose of type checking

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#969 2025-02-19 13:32:31 -08:00
chore: enforce that account only owns one of 'singleton items'

Actually, I'm not sure they use the wishlist like you describe at all.

it was just my guess for what the wishlist's function is. But for some items they report a WishlistChange. And since…

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#969 2025-02-19 13:30:04 -08:00
chore: enforce that account only owns one of 'singleton items'

They don't seem to use any different system for this. This is just a courtesy to ensure that SNS inventories stay in an expected state.

Right, sure, but we could just maintain a list on the…

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#966 2025-02-19 13:28:27 -08:00
fix: Unable to save settings when accepting trade policy.

I just forgot to edit the name when i copyt the file.

I was thinking that too but i havet found anything eles to trigger that endpoint

Okey, right. You could just use Object.Assign…

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#969 2025-02-19 13:27:19 -08:00
chore: enforce that account only owns one of 'singleton items'

there are many unique items which should be owned only once. we shouldnt have a check for every of those

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#969 2025-02-19 13:26:25 -08:00
chore: enforce that account only owns one of 'singleton items'

should probably use the wishlist thingie and add all unique items in that list, not add items if they are in there.

OrdisPrime pushed to fix-completeallunlocked at OpenWF/SpaceNinjaServer 2025-02-19 13:25:08 -08:00
OrdisPrime pushed to fix-completeallunlocked at OpenWF/SpaceNinjaServer 2025-02-19 13:03:55 -08:00
229910cf2a Merge branch 'main' into fix-completeallunlocked
00a75a33fa fix: don't use path-based matching to add QuestKeys (#967)
Compare 2 commits »
OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#966 2025-02-19 12:51:52 -08:00
fix: Unable to save settings when accepting trade policy.

Also I was wondering if you know whether these settings are meant to be overwritten in full or whether this situation can exist: inventory.Settings: { setting1: "something"} server sends:…

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#966 2025-02-19 12:49:57 -08:00
fix: Unable to save settings when accepting trade policy.

yea that all makes sense, I was just wondering why its called training results :D

OrdisPrime deleted branch keys-fix from OpenWF/SpaceNinjaServer 2025-02-19 12:42:22 -08:00