OpenWF/SpaceNinjaServer
21
23
Fork 24
Code Issues 23 Pull Requests 5 Actions Packages Projects Releases Activity

WIP: fix: LevelKeys items added to QuestKeys #986

Closed
AMelonInsideLemon wants to merge 2 commits from AMelonInsideLemon:fix-keys into main
pull from: AMelonInsideLemon:fix-keys
merge into: OpenWF:main
Conversation 3 Commits 2 Files Changed 3 +35 -15
AMelonInsideLemon commented 2025-02-22 01:05:27 -08:00
Contributor
Copy Link
No description provided.
AMelonInsideLemon added 1 commit 2025-02-22 01:05:27 -08:00
fix: LevelKeys items added to QuestKeys
All checks were successful
Build / build (18) (pull_request) Successful in 38s
Details
Build / build (20) (pull_request) Successful in 1m6s
Details
Build / build (22) (pull_request) Successful in 36s
Details
23f8818257
AMelonInsideLemon added 1 commit 2025-02-22 01:28:30 -08:00
Update inventoryService.ts
All checks were successful
Build / build (22) (pull_request) Successful in 39s
Details
Build / build (18) (pull_request) Successful in 59s
Details
Build / build (20) (pull_request) Successful in 1m9s
Details
c69625e43d
Sainan commented 2025-02-22 02:23:23 -08:00
Owner
Copy Link

I don't think it's a good idea to bump PE+ right now before Ordis had a chance to review the changes and properly integrate them.

I don't think it's a good idea to bump PE+ right now before Ordis had a chance to review the changes and properly integrate them.
OrdisPrime reviewed 2025-02-22 11:05:59 -08:00
src/services/inventoryService.ts
@ -377,2 +370,2 @@
}
]
if (ExportKeys[typeName].chainStages) {
inventory.QuestKeys.push({ ItemType: typeName, Progress: [] });
OrdisPrime commented 2025-02-22 11:05:59 -08:00
Owner
Copy Link

why add Progress? The game handles it itself normally.

why add Progress? The game handles it itself normally.
OrdisPrime marked this conversation as resolved
OrdisPrime reviewed 2025-02-22 11:08:27 -08:00
src/services/inventoryService.ts
@ -379,0 +374,4 @@
QuestKeys: [
{
ItemType: typeName,
Progress: []
OrdisPrime commented 2025-02-22 11:08:27 -08:00
Owner
Copy Link

do you have a log where this is actually returned? I never saw it and I don't think its necessary

do you have a log where this is actually returned? I never saw it and I don't think its necessary
OrdisPrime marked this conversation as resolved
OrdisPrime changed title from fix: LevelKeys items added to QuestKeys to WIP: fix: LevelKeys items added to QuestKeys 2025-02-22 11:08:34 -08:00
OrdisPrime closed this pull request 2025-02-24 06:13:03 -08:00
All checks were successful
Build / build (22) (pull_request) Successful in 39s
Details
Build / build (18) (pull_request) Successful in 59s
Details
Build / build (20) (pull_request) Successful in 1m9s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#986
No description provided.
Delete Branch "AMelonInsideLemon:fix-keys"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?