OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat: implement awakening quest completion (/api/giveStartingGear) #977

Closed
neon wants to merge 3 commits from neon/SpaceNinjaServer:starting-gear into main
pull from: neon/SpaceNinjaServer:starting-gear
merge into: OpenWF:main
Conversation 7 Commits 3 Files Changed 3 +214 -4
neon commented 2025-02-20 02:47:37 -08:00
Contributor
Copy Link

closes #975

My repo was completely messed up, hadn't touched it in a while. anyways hope this works

closes #975 My repo was completely messed up, hadn't touched it in a while. anyways hope this works
neon added 1 commit 2025-02-20 02:47:37 -08:00
feat: implement giveStartingGear
All checks were successful
Build / build (22) (pull_request) Successful in 46s
Details
Build / build (18) (pull_request) Successful in 1m1s
Details
Build / build (20) (pull_request) Successful in 1m16s
Details
7efcdfd9a3
neon commented 2025-02-20 02:51:52 -08:00
Author
Contributor
Copy Link

checks passed :)

checks passed :)
OrdisPrime reviewed 2025-02-20 02:52:40 -08:00
src/controllers/api/giveStartingGear.ts
@ -0,0 +20,4 @@
const dataJSON = getJSONfromString<IStartingGearClient>(String(req.body));
await addKeyChainItems(inventory, {
OrdisPrime commented 2025-02-20 02:52:40 -08:00
Owner
Copy Link

this should not be here, the game handles trigger items itself.

this should not be here, the game handles trigger items itself.
neon commented 2025-02-20 02:54:53 -08:00
Author
Contributor
Copy Link

if youre talking about missionInventoryUpdate, then no. the awakening quest doesnt call that. this is why it needs to be done here.

if youre talking about missionInventoryUpdate, then no. the awakening quest doesnt call that. this is why it needs to be done here.
OrdisPrime commented 2025-02-20 02:56:25 -08:00
Owner
Copy Link

if youre talking about missionInventoryUpdate, then no. the awakening quest doesnt call that. this is why it needs to be done here.

What mission inventory update?
I marked the line addKeychain Items, this is not meant to be done here.

> if youre talking about missionInventoryUpdate, then no. the awakening quest doesnt call that. this is why it needs to be done here. What mission inventory update? I marked the line addKeychain Items, this is not meant to be done here.
neon commented 2025-02-20 02:56:58 -08:00
Author
Contributor
Copy Link

Where else would u do it?

Where else would u do it?
OrdisPrime commented 2025-02-20 02:58:09 -08:00
Owner
Copy Link

Not at all, because, as I said "the game handles trigger items itself."

Not at all, because, as I said "the game handles trigger items itself."
neon commented 2025-02-20 02:58:51 -08:00
Author
Contributor
Copy Link

try it without but it didnt work for me

try it without but it didnt work for me
OrdisPrime commented 2025-02-20 02:53:43 -08:00
Owner
Copy Link

use the game supplied values for creating inventory items.

use the game supplied values for creating inventory items.
neon added 1 commit 2025-02-20 02:58:09 -08:00
moved
All checks were successful
Build / build (18) (pull_request) Successful in 1m0s
Details
Build / build (22) (pull_request) Successful in 37s
Details
Build / build (20) (pull_request) Successful in 1m4s
Details
605905c880
OrdisPrime changed title from feat: implement awakening quest completion (/api/giveStartingGear) to WIP: feat: implement awakening quest completion (/api/giveStartingGear) 2025-02-20 03:00:58 -08:00
OrdisPrime added a new dependency 2025-02-20 03:03:08 -08:00
#885 Give Starting Gear
neon commented 2025-02-20 03:11:07 -08:00
Author
Contributor
Copy Link

not sure what u mean by that. its working like this. it gives the Arsenal Segment which is required to start the next stage

not sure what u mean by that. its working like this. it gives the Arsenal Segment which is required to start the next stage
neon added 1 commit 2025-02-20 08:43:28 -08:00
add comments
All checks were successful
Build / build (18) (pull_request) Successful in 38s
Details
Build / build (20) (pull_request) Successful in 1m2s
Details
Build / build (22) (pull_request) Successful in 1m12s
Details
6f388128ae
neon commented 2025-02-20 09:27:03 -08:00
Author
Contributor
Copy Link

giveKeyChainTriggeredItems.php and giveKeyChainTriggeredMessage.php dont get called after completing the awakening so this is absolutely needed as it gives the arsenal segment which allows for further progression and I feel its better adding it through "addKeyChainItems" instead of directly through "addItem".
Anyways i added some comments, please check

giveKeyChainTriggeredItems.php and giveKeyChainTriggeredMessage.php dont get called after completing the awakening so this is absolutely needed as it gives the arsenal segment which allows for further progression and I feel its better adding it through "addKeyChainItems" instead of directly through "addItem". Anyways i added some comments, please check
OrdisPrime changed title from WIP: feat: implement awakening quest completion (/api/giveStartingGear) to feat: implement awakening quest completion (/api/giveStartingGear) 2025-02-21 08:47:48 -08:00
OrdisPrime commented 2025-02-21 08:48:18 -08:00
Owner
Copy Link

I appreciate your effort, however I self-assigned the issue to me and had some code already, so I finished my code. I used your code to check against mine, so it was still helpful. Thanks :)

I appreciate your effort, however I self-assigned the issue to me and had some code already, so I finished my code. I used your code to check against mine, so it was still helpful. Thanks :)
OrdisPrime removed a dependency 2025-02-21 08:48:30 -08:00
#885 Give Starting Gear
OrdisPrime commented 2025-02-21 08:48:39 -08:00
Owner
Copy Link

I appreciate your effort, however I self-assigned the issue to me and had some code already, so I finished my code. I used your code to check against mine, so it was still helpful. Thanks :)

I appreciate your effort, however I self-assigned the issue to me and had some code already, so I finished my code. I used your code to check against mine, so it was still helpful. Thanks :)
OrdisPrime closed this pull request 2025-02-21 08:48:39 -08:00
All checks were successful
Build / build (18) (pull_request) Successful in 38s
Details
Build / build (20) (pull_request) Successful in 1m2s
Details
Build / build (22) (pull_request) Successful in 1m12s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#977
No description provided.
Delete Branch "neon/SpaceNinjaServer:starting-gear"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?