OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 41 Pull Requests 1 Actions Packages Projects Releases Activity

WIP: feat: store administrator status in database #936

Closed
AMelonInsideLemon wants to merge 1 commits from AMelonInsideLemon:administrator-status into main
pull from: AMelonInsideLemon:administrator-status
merge into: OpenWF:main
Conversation 2 Commits 1 Files Changed 3 +11 -2
3 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/models/loginModel.ts
View File

@ -21,7 +21,8 @@ const databaseAccountSchema = new Schema<IDatabaseAccountJson>(
TrackedSettings: { type: [String], default: [] },
Nonce: { type: Number, default: 0 },
LastLoginDay: { type: Number },
LatestEventMessageDate: { type: Date, default: 0 }
LatestEventMessageDate: { type: Date, default: 0 },
isAdministrator: { type: Boolean, required: false, default: false }
},
opts
);

9
src/services/loginService.ts
View File

@ -18,7 +18,11 @@ export const isNameTaken = async (name: string): Promise<boolean> => {
};
export const createAccount = async (accountData: IDatabaseAccount): Promise<IDatabaseAccountJson> => {
const account = new Account(accountData);
const account = new Account({
OrdisPrime commented 2025-02-09 11:03:58 -08:00
Review
Copy Link

provide an optional parameter, isAdministrator: false,
use that instead of querying the database instead.
For the reasons that sainan mentioned, plus avoiding unnecessary performance overhead by querying.

provide an optional parameter, isAdministrator: false, use that instead of querying the database instead. For the reasons that sainan mentioned, plus avoiding unnecessary performance overhead by querying.
...accountData,
isAdministrator: !(await Account.exists({}))
});
try {
await account.save();
const loadoutId = await createLoadout(account._id);
@ -101,6 +105,9 @@ export const getAccountIdForRequest = async (req: Request): Promise<string> => {
};
export const isAdministrator = (account: TAccountDocument): boolean => {
if (account.isAdministrator) {
return true;
}
if (!config.administratorNames) {
return false;
}

1
src/types/loginTypes.ts
View File

@ -16,6 +16,7 @@ export interface IDatabaseAccount extends IAccountAndLoginResponseCommons {
password: string;
LastLoginDay?: number;
LatestEventMessageDate: Date;
isAdministrator?: boolean;
}
// Includes virtual ID