OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

WIP: feat: store administrator status in database #936

Closed
AMelonInsideLemon wants to merge 1 commits from AMelonInsideLemon:administrator-status into main
pull from: AMelonInsideLemon:administrator-status
merge into: OpenWF:main
Conversation 2 Commits 1 Files Changed 3 +11 -2
AMelonInsideLemon commented 2025-02-09 10:34:41 -08:00
Contributor
Copy Link

Closes #907

Closes #907
AMelonInsideLemon added 1 commit 2025-02-09 10:34:41 -08:00
feat: store administrator status in database
All checks were successful
Build / build (20) (pull_request) Successful in 37s
Details
Build / build (22) (pull_request) Successful in 1m2s
Details
Build / build (18) (pull_request) Successful in 1m37s
Details
2725784bc8 
Closes 907
Sainan commented 2025-02-09 10:51:35 -08:00
Owner
Copy Link

Well, the semantic you're introducing here is only "implicitly give administrator status to the first account created", which is fine, but without further work, it's a bit too implicit for my liking.

Well, the semantic you're introducing here is only "implicitly give administrator status to the first account created", which is fine, but without further work, it's a bit too implicit for my liking.
👍 1
OrdisPrime reviewed 2025-02-09 11:03:58 -08:00
src/services/loginService.ts
@ -19,3 +19,3 @@
export const createAccount = async (accountData: IDatabaseAccount): Promise<IDatabaseAccountJson> => {
const account = new Account(accountData);
const account = new Account({
OrdisPrime commented 2025-02-09 11:03:58 -08:00
Owner
Copy Link

provide an optional parameter, isAdministrator: false,
use that instead of querying the database instead.
For the reasons that sainan mentioned, plus avoiding unnecessary performance overhead by querying.

provide an optional parameter, isAdministrator: false, use that instead of querying the database instead. For the reasons that sainan mentioned, plus avoiding unnecessary performance overhead by querying.
Sainan changed title from feat: store administrator status in database to WIP: feat: store administrator status in database 2025-02-09 14:37:45 -08:00
Sainan closed this pull request 2025-02-24 21:25:37 -08:00
All checks were successful
Build / build (20) (pull_request) Successful in 37s
Details
Build / build (22) (pull_request) Successful in 1m2s
Details
Build / build (18) (pull_request) Successful in 1m37s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#936
No description provided.
Delete Branch "AMelonInsideLemon:administrator-status"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?