OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

chore: dont send messages with completeQuest #2914

Merged
Sainan merged 2 commits from AMelonInsideLemon/SpaceNinjaServer:silent-completeQuest into main 2025-10-20 00:56:46 -07:00
Conversation 2 Commits 2 Files Changed 2 +20 -9
AMelonInsideLemon commented 2025-10-18 10:05:59 -07:00
Member
Copy Link

Re #2754

Re #2754
AMelonInsideLemon added 1 commit 2025-10-18 10:06:00 -07:00
chore: dont send messages with completeQuest
All checks were successful
Build / build (pull_request) Successful in 1m45s
Details
2a2c57a932 
Re #2754
Sainan reviewed 2025-10-18 11:34:41 -07:00
src/services/questService.ts
@ -340,2 +348,4 @@
if (keyChainMessage.att?.length) await addItems(inventory, keyChainMessage.att);
}
updateQuestStage(inventory, keyChainInfo, { m: true });
Sainan commented 2025-10-18 11:34:41 -07:00
Owner
Copy Link

If we don't send the message, maybe we shouldn't set this either?

If we don't send the message, maybe we shouldn't set this either?
AMelonInsideLemon commented 2025-10-18 11:50:42 -07:00
Author
Member
Copy Link
{
    "unlock": true,
    "Progress": [
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        },
        {
            "c": 0,
            "i": true,
            "m": true,
            "b": []
        }
    ],
    "Completed": true,
    "ItemType": "/Lotus/Types/Keys/RailJackBuildQuest/RailjackBuildQuestKeyChain"
}

thats that from account with gifted railjack bundle, they just set all i and m to true.
I think I just need to change defaults in completeQuest to match live

``` { "unlock": true, "Progress": [ { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] }, { "c": 0, "i": true, "m": true, "b": [] } ], "Completed": true, "ItemType": "/Lotus/Types/Keys/RailJackBuildQuest/RailjackBuildQuestKeyChain" } ``` thats that from account with gifted railjack bundle, they just set all `i` and `m` to `true`. I think I just need to change defaults in `completeQuest` to match live
AMelonInsideLemon added 1 commit 2025-10-18 11:55:19 -07:00
change default i and m to match live
All checks were successful
Build / build (pull_request) Successful in 1m45s
Details
05eff5e00f
Sainan approved these changes 2025-10-18 23:45:25 -07:00
Sainan merged commit a0ce110e7e into main 2025-10-20 00:56:46 -07:00
Sainan deleted branch silent-completeQuest 2025-10-20 00:56:46 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2914
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:silent-completeQuest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?