OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

feat(webui): skins #2816

Merged
Sainan merged 13 commits from AMelonInsideLemon/SpaceNinjaServer:webui-WeaponSkins into main 2025-10-09 23:02:10 -07:00
Conversation 9 Commits 13 Files Changed 17 +276 -22
AMelonInsideLemon commented 2025-09-26 17:15:22 -07:00
Member
Copy Link
No description provided.
AMelonInsideLemon added 1 commit 2025-09-26 17:15:23 -07:00
feat(webui): skins
All checks were successful
Build / build (pull_request) Successful in 1m13s
Details
a31e293a6e 
Re #2361
AMelonInsideLemon added 1 commit 2025-09-26 18:20:02 -07:00
add warning for other loadouts with skins
All checks were successful
Build / build (pull_request) Successful in 1m8s
Details
4f2d636a4a
AMelonInsideLemon added 1 commit 2025-09-26 18:30:26 -07:00
Update inventoryController.ts
All checks were successful
Build / build (pull_request) Successful in 1m11s
Details
785a83a2ea
Sainan commented 2025-09-27 03:21:40 -07:00
Owner
Copy Link

This seems like a rough migration. I really would not remove unlockAllSkins for the time being.

This seems like a rough migration. I really would not remove `unlockAllSkins` for the time being.
AMelonInsideLemon added 1 commit 2025-09-27 12:59:09 -07:00
readd unlockAllSkins as account cheat
Some checks failed
Build / build (pull_request) Failing after 57s
Details
a9f994ea4c
AMelonInsideLemon added 1 commit 2025-09-27 13:00:16 -07:00
Update saveLoadoutService.ts
Some checks failed
Build / build (pull_request) Failing after 56s
Details
35971b914c
AMelonInsideLemon added 1 commit 2025-09-27 13:02:45 -07:00
typo
All checks were successful
Build / build (pull_request) Successful in 56s
Details
186d0559ec
Sainan changed title from feat(webui): skins to WIP: feat(webui): skins 2025-09-28 01:15:46 -07:00
Sainan commented 2025-09-28 01:17:07 -07:00
Owner
Copy Link

This really is not gonna work if you break existing configs in any way. You log in, and it breaks immediately because the client removes any unowned skins.

I'd be okay with this if you automatically gave the WeaponSkin items or just kept the unlockAllSkins option as-is. This does not have to be a rough all-in-one transition.

This really is not gonna work if you break existing configs in any way. You log in, and it breaks immediately because the client removes any unowned skins. I'd be okay with this if you automatically gave the WeaponSkin items or just kept the `unlockAllSkins` option as-is. This does not have to be a rough all-in-one transition.
AMelonInsideLemon added 1 commit 2025-09-29 08:35:29 -07:00
give all missing skins
All checks were successful
Build / build (pull_request) Successful in 1m10s
Details
f2d3837dc0
AMelonInsideLemon changed title from WIP: feat(webui): skins to feat(webui): skins 2025-09-29 08:37:24 -07:00
Sainan commented 2025-09-29 09:13:41 -07:00
Owner
Copy Link

How about you put the logic you added to inventoryController into the cleanupInventory function so the migration can happen without impacting every single inventory request? Then we can merge the full PR later.

How about you put the logic you added to inventoryController into the cleanupInventory function so the migration can happen without impacting every single inventory request? Then we can merge the full PR later.
AMelonInsideLemon added 1 commit 2025-09-29 12:20:43 -07:00
move migration to cleanupInventory
All checks were successful
Build / build (pull_request) Successful in 1m10s
Details
3a3d5de5dc
Sainan changed title from feat(webui): skins to WIP: feat(webui): skins 2025-09-29 23:56:00 -07:00
Sainan added 1 commit 2025-09-30 00:18:03 -07:00
chore: add a helper for skinLookupTable
All checks were successful
Build / build (pull_request) Successful in 1m15s
Details
fc0090e4c7
Sainan commented 2025-09-30 00:18:55 -07:00
Owner
Copy Link

Not really what I meant, but okay. A problem I can already see is that animation sets don't work like this so this migration is actually adding garbage WeaponSkins for those and not adding the respective FlavourItems to unlock them.

Not really what I meant, but okay. A problem I can already see is that animation sets don't work like this so this migration is actually adding garbage WeaponSkins for those and not adding the respective FlavourItems to unlock them.
Sainan commented 2025-10-04 09:34:58 -07:00
Owner
Copy Link

Maybe just #2843 is what this needs?

Maybe just #2843 is what this needs?
AMelonInsideLemon force-pushed webui-WeaponSkins from fc0090e4c7 to 317fb8324f 2025-10-07 04:11:09 -07:00 Compare
AMelonInsideLemon added 1 commit 2025-10-07 04:11:20 -07:00
add required item
All checks were successful
Build / build (pull_request) Successful in 1m36s
Details
cc92609740
AMelonInsideLemon changed title from WIP: feat(webui): skins to feat(webui): skins 2025-10-07 04:12:45 -07:00
Sainan reviewed 2025-10-07 04:14:29 -07:00
src/controllers/api/sellController.ts Outdated
@ -335,6 +343,7 @@ interface ISellRequest {
CrewShipWeapons?: ISellItem[];
CrewShipWeaponSkins?: ISellItem[];
FusionTreasures?: ISellItem[];
WeaponSkins?: ISellItem[];
Sainan commented 2025-10-07 04:14:29 -07:00
Owner
Copy Link

Maybe a comment here that this is not a standard request field?

Maybe a comment here that this is not a standard request field?
AMelonInsideLemon marked this conversation as resolved
Sainan commented 2025-10-07 04:15:59 -07:00
Owner
Copy Link

I suggested cleanupInventory for a slow migration. This PR not a slow migration because it does everything all at once.

I suggested `cleanupInventory` for a slow migration. This PR not a slow migration because it does everything all at once.
Sainan changed title from feat(webui): skins to WIP: feat(webui): skins 2025-10-07 05:04:21 -07:00
AMelonInsideLemon added 1 commit 2025-10-09 02:29:35 -07:00
revert removal of unlockAllSkins cheat
All checks were successful
Build / build (pull_request) Successful in 1m0s
Details
ddf5468bff
AMelonInsideLemon changed title from WIP: feat(webui): skins to feat(webui): skins 2025-10-09 02:31:03 -07:00
Sainan reviewed 2025-10-09 02:33:33 -07:00
src/controllers/api/inventoryController.ts
@ -344,3 +336,1 @@
},
ItemType: uniqueName
});
if (config.unlockAllSkins) {
Sainan commented 2025-10-09 02:33:33 -07:00
Owner
Copy Link

unlockAllSkins is now dependent on baroTennoConRelay

unlockAllSkins is now dependent on baroTennoConRelay
AMelonInsideLemon marked this conversation as resolved
AMelonInsideLemon added 1 commit 2025-10-09 02:35:13 -07:00
Update inventoryController.ts
All checks were successful
Build / build (pull_request) Successful in 2m35s
Details
e39291b077
AMelonInsideLemon added 1 commit 2025-10-09 02:36:36 -07:00
Update sellController.ts
All checks were successful
Build / build (pull_request) Successful in 59s
Details
c7523aaa10
Sainan approved these changes 2025-10-09 04:52:50 -07:00
Sainan merged commit 02f0935710 into main 2025-10-09 23:02:10 -07:00
Sainan referenced this issue from a commit 2025-10-09 23:02:11 -07:00
feat(webui): skins (#2816)
Sainan deleted branch webui-WeaponSkins 2025-10-09 23:02:11 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2816
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:webui-WeaponSkins"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?