OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

feat: nemesis henchmen kills multiplier cheat #2806

Merged
Sainan merged 19 commits from AlexisinGit/SpaceNinjaServerAlexFork:cheat-nemesis-henchmen-kills-multiplier into main 2025-09-26 04:41:55 -07:00
Conversation 11 Commits 19 Files Changed 14 +191 -9
AlexisinGit commented 2025-09-22 15:20:30 -07:00
Contributor
Copy Link
No description provided.
AlexisinGit added 2 commits 2025-09-22 15:20:31 -07:00
cheat: antivirusGainMultiplier
Some checks failed
Build / build (pull_request) Failing after 23s
Details
6226518e50
Sainan commented 2025-09-22 15:30:51 -07:00
Owner
Copy Link

Please cherry-pick #2805 onto this branch.

Please cherry-pick #2805 onto this branch.
AlexisinGit added 2 commits 2025-09-22 15:34:08 -07:00
AlexisinGit added 5 commits 2025-09-22 15:35:06 -07:00
AlexisinGit added 1 commit 2025-09-22 15:42:09 -07:00
cheat: nemesisExtraWeapon
All checks were successful
Build / build (pull_request) Successful in 1m23s
Details
536ed1cffe 
cheat: nemesisExtraWeapon

cheat: nemesisExtraWeapon (2)

fix weapon name

cheat: nemesisExtraWeapon (3)

fix error delegating weapon for infestation nemesis
AMelonInsideLemon reviewed 2025-09-23 08:00:30 -07:00
static/webui/index.html Outdated
@ -1021,0 +1052,4 @@
<input class="form-control" id="nemesisHintProgressMultiplierCorpus" type="number" min="-1" max="65535" data-default="1" />
<button class="btn btn-secondary" type="button" data-loc="cheats_save"></button>
</form>
<form class="form-group mt-2"></form>
AMelonInsideLemon commented 2025-09-23 08:00:30 -07:00
Member
Copy Link

This form has an extra closing tag, and the div above it does not have one. This breaks the layout.

This `form` has an extra closing tag, and the `div` above it does not have one. This breaks the layout.
AlexisinGit marked this conversation as resolved
Sainan changed title from nemesis henchmen kills multiplier cheat to WIP: feat: nemesis henchmen kills multiplier cheat 2025-09-23 08:17:14 -07:00
AMelonInsideLemon commented 2025-09-23 09:03:05 -07:00
Member
Copy Link

Save buttons doesn't do anything, you send request on each number change. And for some reason it always send false as value instead number.

Save buttons doesn't do anything, you send request on each number change. And for some reason it always send `false` as `value` instead number.
AlexisinGit added 2 commits 2025-09-23 12:41:19 -07:00
account-cheats button emit payload
All checks were successful
Build / build (pull_request) Successful in 1m10s
Details
0bbd05c8b8
AlexisinGit commented 2025-09-23 12:45:21 -07:00
Author
Contributor
Copy Link

account-cheat save buttons should work properly now and should only emit payload on click. buttons should change style (highlight) on number changes as well.

account-cheat save buttons should work properly now and should only emit payload on click. buttons should change style (highlight) on number changes as well.
AlexisinGit added 1 commit 2025-09-23 12:53:53 -07:00
fix #guild-cheats value
All checks were successful
Build / build (pull_request) Successful in 1m8s
Details
d07fc19281 
a mistake in previous merging action
AMelonInsideLemon commented 2025-09-23 13:01:20 -07:00
Member
Copy Link

Is min="-1" intended in multipliers?

Is `min="-1"` intended in multipliers?
AlexisinGit commented 2025-09-23 13:10:15 -07:00
Author
Contributor
Copy Link

Is min="-1" intended in multipliers?

No. If this might cause any issues, I can change the minimum value to 0. Meanwhile I’m just keeping an negative multiplier option

> Is `min="-1"` intended in multipliers? No. If this might cause any issues, I can change the minimum value to 0. Meanwhile I’m just keeping an negative multiplier option
AlexisinGit added 1 commit 2025-09-23 18:26:24 -07:00
0 is min value for multipliers
All checks were successful
Build / build (pull_request) Successful in 1m3s
Details
e1f86e4d7b
Sainan commented 2025-09-24 08:42:05 -07:00
Owner
Copy Link

Once this PR is ready for review, you can remove the WIP prefix.

Once this PR is ready for review, you can remove the WIP prefix.
AlexisinGit changed title from WIP: feat: nemesis henchmen kills multiplier cheat to feat: nemesis henchmen kills multiplier cheat 2025-09-24 10:08:05 -07:00
AlexisinGit added 1 commit 2025-09-24 10:08:14 -07:00
Merge branch 'main' into cheat-nemesis-henchmen-kills-multiplier
All checks were successful
Build / build (pull_request) Successful in 1m6s
Details
f1b53777b6
Sainan reviewed 2025-09-24 10:19:45 -07:00
static/webui/script.js Outdated
@ -3210,0 +3230,4 @@
contentType: "application/json",
data: JSON.stringify({
key: input.id,
value: value
Sainan commented 2025-09-24 10:19:45 -07:00
Owner
Copy Link

Should parseInt(value) here otherwise the server gets a string

Should `parseInt(value)` here otherwise the server gets a string
AlexisinGit marked this conversation as resolved
AlexisinGit added 2 commits 2025-09-24 12:39:07 -07:00
Sainan commented 2025-09-24 23:51:34 -07:00
Owner
Copy Link

Getting this in the browser console when just loading the webui: Uncaught TypeError: can't access property "onchange", input is null

Getting this in the browser console when just loading the webui: Uncaught TypeError: can't access property "onchange", input is null
AlexisinGit added 1 commit 2025-09-25 02:50:36 -07:00
fix assigning function on a null element
All checks were successful
Build / build (pull_request) Successful in 1m29s
Details
108333e8d5
AlexisinGit added 1 commit 2025-09-25 03:01:13 -07:00
fix changeSyndicate button hight logic
All checks were successful
Build / build (pull_request) Successful in 1m0s
Details
46fe26a8ff
AlexisinGit commented 2025-09-25 03:03:31 -07:00
Author
Contributor
Copy Link

This will fix the error. The changeSyndicate input-group below does not have a input, thus cause previous error. However I do notice that button below does not follow highlighting logic like other buttons. It should de-highlight as default and highligh on select change on the lastest commit.

This will fix the error. The changeSyndicate input-group below does not have a input, thus cause previous error. However I do notice that button below does not follow highlighting logic like other buttons. It should de-highlight as default and highligh on select change on the lastest commit.
Sainan approved these changes 2025-09-25 10:22:45 -07:00
Sainan merged commit fc38f818dd into main 2025-09-26 04:41:55 -07:00
Sainan deleted branch cheat-nemesis-henchmen-kills-multiplier 2025-09-26 04:41:55 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2806
No description provided.
Delete Branch "AlexisinGit/SpaceNinjaServerAlexFork:cheat-nemesis-henchmen-kills-multiplier"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?