OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

feat(webui): add item by ItemType #2704

Merged
Sainan merged 7 commits from AMelonInsideLemon/SpaceNinjaServer:add-by-ItemType into main 2025-08-30 19:34:23 -07:00
Conversation 5 Commits 7 Files Changed 10 +107 -7
AMelonInsideLemon commented 2025-08-26 19:49:11 -07:00
Member
Copy Link
No description provided.
AMelonInsideLemon added 1 commit 2025-08-26 19:49:12 -07:00
feat(webui): add item by ItemType
Some checks failed
Build / build (pull_request) Failing after 1m5s
Details
d8a389fa7f
AMelonInsideLemon added 1 commit 2025-08-26 19:54:05 -07:00
lint fix
All checks were successful
Build / build (pull_request) Successful in 1m13s
Details
dad479fac8
AMelonInsideLemon added 1 commit 2025-08-26 19:57:34 -07:00
Update script.js
All checks were successful
Build / build (pull_request) Successful in 1m12s
Details
acf3b811cf
Sainan commented 2025-08-26 20:14:07 -07:00
Owner
Copy Link

I'm mildly against this. If an item isn't already listed, it means we don't know it, so we also don't know for sure how to add it, and need to guess. And if a cockup requires editing the database manually anyway, then you could've just edited the database to begin with.

I'm mildly against this. If an item isn't already listed, it means we don't know it, so we also don't know for sure how to add it, and need to guess. And if a cockup requires editing the database manually anyway, then you could've just edited the database to begin with.
Sainan commented 2025-08-26 20:15:14 -07:00
Owner
Copy Link

A good thing with editing the database is that the user at least knows what they're doing is dangerous and might mess up their inventory. I don't have that same expectation when using the WebUI.

A good thing with editing the database is that the user at least knows what they're doing is dangerous and might mess up their inventory. I don't have that same expectation when using the WebUI.
Sainan changed title from feat(webui): add item by ItemType to WIP: feat(webui): add item by ItemType 2025-08-27 01:30:46 -07:00
AMelonInsideLemon commented 2025-08-29 13:51:20 -07:00
Author
Member
Copy Link

All item groups that can be added using path addition, except for WeaponSkins, can be removed from the WebUI. If I add the ability to add/remove items in WebUI fromWeaponSkins array, will that be okay?

All item groups that can be added using path addition, except for `WeaponSkins`, can be removed from the WebUI. If I add the ability to add/remove items in WebUI from`WeaponSkins` array, will that be okay?
Sainan commented 2025-08-29 17:28:33 -07:00
Owner
Copy Link

I mean, if you put it like that, I guess WeaponSkins is really not that important to clean up.

But the way you implemented it looks a bit bad. Take look at https://getbootstrap.com/docs/5.3/components/card/#navigation.

I mean, if you put it like that, I guess `WeaponSkins` is really not that important to clean up. But the way you implemented it looks a bit bad. Take look at <https://getbootstrap.com/docs/5.3/components/card/#navigation>.
AMelonInsideLemon added 1 commit 2025-08-29 18:45:16 -07:00
put tab navs into card header
All checks were successful
Build / build (pull_request) Successful in 1m54s
Details
65b8211aeb
AMelonInsideLemon changed title from WIP: feat(webui): add item by ItemType to feat(webui): add item by ItemType 2025-08-29 18:45:58 -07:00
Sainan added 1 commit 2025-08-29 19:01:22 -07:00
details
All checks were successful
Build / build (pull_request) Successful in 1m1s
Details
72219ab7d5
Sainan approved these changes 2025-08-29 19:01:37 -07:00
AMelonInsideLemon added 2 commits 2025-08-29 19:07:03 -07:00
Update ru.js
All checks were successful
Build / build (pull_request) Successful in 1m47s
Details
7a04d0fd23
Sainan merged commit e98cb2ec24 into main 2025-08-30 19:34:23 -07:00
Sainan deleted branch add-by-ItemType 2025-08-30 19:34:23 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2704
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:add-by-ItemType"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?