OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

fix: use netracell search pulse only when container item was picked up #2687

Merged
Sainan merged 1 commits from netracell-fix into main 2025-08-24 15:16:08 -07:00
Conversation 11 Commits 1 Files Changed 1 +6 -6
Sainan commented 2025-08-23 12:55:45 -07:00
Owner
Copy Link
No description provided.
Sainan added 1 commit 2025-08-23 12:55:46 -07:00
fix: use netracell search pulse only when container item was picked up
All checks were successful
Build / build (pull_request) Successful in 1m2s
Details
efd616fed1
LoseFace commented 2025-08-23 23:46:25 -07:00
Contributor
Copy Link

Search pulses may have a negative value, which should not be the case

Search pulses may have a negative value, which should not be the case
Sainan commented 2025-08-23 23:52:38 -07:00
Author
Owner
Copy Link

What do you mean?

What do you mean?
LoseFace commented 2025-08-24 00:37:13 -07:00
Contributor
Copy Link

What do you mean?

If you pass Netracell when there are 0 search pulses available, then upon successful completion of the mission, there will be -1/5 search pulses. Next -2/5, -3/5 ... -999/5, it shouldn't work like that.

> What do you mean? If you pass Netracell when there are 0 search pulses available, then upon successful completion of the mission, there will be -1/5 search pulses. Next -2/5, -3/5 ... -999/5, it shouldn't work like that.
Sainan commented 2025-08-24 00:41:01 -07:00
Author
Owner
Copy Link

Does this PR not fix that?

Does this PR not fix that?
LoseFace commented 2025-08-24 00:43:00 -07:00
Contributor
Copy Link

Does this PR not fix that?

Of course not, here the value always increases ( inventory.EntratiVaultCountLastPeriod! += 1; ), while in the game it always decreases, ultimately reaching a negative value.

> Does this PR not fix that? Of course not, here the value always increases ( inventory.EntratiVaultCountLastPeriod! += 1; ), while in the game it always decreases, ultimately reaching a negative value.
Animan8000 commented 2025-08-24 00:48:01 -07:00
Contributor
Copy Link

Does this PR not fix that?

Of course not, here the value always increases ( inventory.EntratiVaultCountLastPeriod! += 1; ), while in the game it always decreases, ultimately reaching a negative value.

You made sure that you force grabbed the PR before testing?

> > Does this PR not fix that? > > Of course not, here the value always increases ( inventory.EntratiVaultCountLastPeriod! += 1; ), while in the game it always decreases, ultimately reaching a negative value. You made sure that you force grabbed the PR before testing?
Sainan commented 2025-08-24 00:51:30 -07:00
Author
Owner
Copy Link

I assume you did not apply this patch locally, but just in case, could you provide a log of a netracell completion past your 5 search pulses?

I assume you did not apply this patch locally, but just in case, could you provide a log of a netracell completion past your 5 search pulses?
LoseFace commented 2025-08-24 01:12:04 -07:00
Contributor
Copy Link

I assume you did not apply this patch locally, but just in case, could you provide a log of a netracell completion past your 5 search pulses?

> I assume you did not apply this patch locally, but just in case, could you provide a log of a netracell completion past your 5 search pulses?
ntrcll.txt
35 KiB
Sainan commented 2025-08-24 02:45:39 -07:00
Author
Owner
Copy Link

Yeah, you definitely didn't apply this patch locally.

Yeah, you definitely didn't apply this patch locally.
LoseFace commented 2025-08-24 02:59:36 -07:00
Contributor
Copy Link

Yeah, you definitely didn't apply this patch locally.

Check it out for yourself, search pulses will receive a negative value.

> Yeah, you definitely didn't apply this patch locally. Check it out for yourself, search pulses will receive a negative value.
LoseFace commented 2025-08-24 06:25:49 -07:00
Contributor
Copy Link

I rewrote it manually, the fix works, not thanks to Animan8000.

I rewrote it manually, the fix works, not thanks to Animan8000.
Sainan merged commit f06a3b8187 into main 2025-08-24 15:16:08 -07:00
Sainan deleted branch netracell-fix 2025-08-24 15:16:08 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2687
No description provided.
Delete Branch "netracell-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?