OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

fix(import): accept loadouts without GEAR field #2671

Merged
Sainan merged 2 commits from AMelonInsideLemon/SpaceNinjaServer:gear-fix into main 2025-08-21 11:25:51 -07:00
Conversation 2 Commits 2 Files Changed 2 +3 -3
AMelonInsideLemon commented 2025-08-20 08:28:57 -07:00
Member
Copy Link

New inventories don't have that field

New inventories don't have that field
AMelonInsideLemon added 1 commit 2025-08-20 08:28:58 -07:00
fix(importer): accept loadouts without GEAR field
All checks were successful
Build / build (pull_request) Successful in 55s
Details
c297ac01e9 
New inventories don't have that field
Sainan approved these changes 2025-08-20 10:17:21 -07:00
Sainan reviewed 2025-08-20 12:46:40 -07:00
src/services/importService.ts Outdated
@ -445,3 +445,3 @@
db.LUNARO = client.LUNARO.map(convertLoadOutConfig);
db.OPERATOR = client.OPERATOR.map(convertLoadOutConfig);
db.GEAR = client.GEAR.map(convertLoadOutConfig);
db.GEAR = client.GEAR ? client.GEAR.map(convertLoadOutConfig) : [];
Sainan commented 2025-08-20 12:46:40 -07:00
Owner
Copy Link

Why not also make it optional in ILoadoutDatabase so you can simplify this to client.GEAR?.map(convertLoadOutConfig)

Why not also make it optional in `ILoadoutDatabase` so you can simplify this to `client.GEAR?.map(convertLoadOutConfig)`
Sainan marked this conversation as resolved
AMelonInsideLemon added 1 commit 2025-08-21 07:36:04 -07:00
GEAR optional in database
All checks were successful
Build / build (pull_request) Successful in 1m20s
Details
1eff3e8df2
Sainan merged commit 1e4007f6da into main 2025-08-21 11:25:51 -07:00
Sainan deleted branch gear-fix 2025-08-21 11:25:51 -07:00
Sainan changed title from fix(importer): accept loadouts without `GEAR` field to fix(import): accept loadouts without `GEAR` field 2025-08-21 11:27:52 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2671
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:gear-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?