OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

feat: warframe anniversary goals #2640

Merged
Sainan merged 4 commits from AMelonInsideLemon/SpaceNinjaServer:goal-anniversary into main 2025-08-17 13:11:56 -07:00
Conversation 7 Commits 4 Files Changed 13 +495 -54
AMelonInsideLemon commented 2025-08-15 23:46:36 -07:00
Member
Copy Link

Also adds useAnniversaryTagForOldGoals to display old Goals in GUI
Re #1103

Also adds `useAnniversaryTagForOldGoals` to display old Goals in GUI Re #1103
AMelonInsideLemon added 1 commit 2025-08-15 23:46:37 -07:00
feat: warframe anniversary goals
All checks were successful
Build / build (pull_request) Successful in 2m13s
Details
6cef5e44be 
Also adds `useAnniversaryTagForOldGoals` to display old Goals in GUI
Re #1103
AMelonInsideLemon added 1 commit 2025-08-16 00:05:22 -07:00
use same tagsForOlderGoals for incompatible goals
All checks were successful
Build / build (pull_request) Successful in 1m5s
Details
8f3882a231
Sainan approved these changes 2025-08-16 05:38:29 -07:00
Dismissed
Sainan commented 2025-08-16 09:53:28 -07:00
Owner
Copy Link

merge conflicts

merge conflicts
AMelonInsideLemon force-pushed goal-anniversary from 8f3882a231 to bac58a56fb 2025-08-16 10:06:03 -07:00 Compare
AMelonInsideLemon added 1 commit 2025-08-16 10:06:18 -07:00
Update index.html
All checks were successful
Build / build (pull_request) Successful in 1m48s
Details
7b67f24a2b
AMelonInsideLemon commented 2025-08-16 10:07:06 -07:00
Author
Member
Copy Link

resolved

resolved
Sainan reviewed 2025-08-16 12:02:53 -07:00
config-vanilla.json Outdated
@ -61,2 +61,3 @@
"ignore1999LastRegionPlayed": false,
"fixXtraCheeseTimer": false
"fixXtraCheeseTimer": false,
"useAnniversaryTagForOldGoals": false
Sainan commented 2025-08-16 12:02:53 -07:00
Owner
Copy Link

Should this not be enabled by default?

Should this not be enabled by default?
AMelonInsideLemon commented 2025-08-16 12:58:12 -07:00
Author
Member
Copy Link

I'm hesitating because on the one hand it will fix the event tab, but on the other hand it's unfaithful because those events were with these Tag

I'm hesitating because on the one hand it will fix the event tab, but on the other hand it's unfaithful because those events were with these `Tag`
Sainan commented 2025-08-16 13:05:30 -07:00
Owner
Copy Link

Well, yes, it's explicitly documented as unfaithful, but considering modern versions right now work the best with SNS and are what most people use anyway, I don't see why such a crucial prerequisite should not be enabled by default

Well, yes, it's explicitly documented as unfaithful, but considering modern versions right now work the best with SNS and are what most people use anyway, I don't see why such a crucial prerequisite should not be enabled by default
AMelonInsideLemon marked this conversation as resolved
Sainan dismissed Sainan’s review 2025-08-16 12:03:09 -07:00
AMelonInsideLemon added 1 commit 2025-08-16 13:07:11 -07:00
Update config-vanilla.json
All checks were successful
Build / build (pull_request) Successful in 2m5s
Details
0e6029d59e
Sainan approved these changes 2025-08-16 13:12:05 -07:00
VampireKitten commented 2025-08-16 13:25:09 -07:00
Contributor
Copy Link

I noticed a few tags in the PR didn't get changed, namely at least one Halloween and Halloween19Endless. Were those ommisions on purpose or by accident?

I noticed a few tags in the PR didn't get changed, namely at least one `Halloween` and `Halloween19Endless`. Were those ommisions on purpose or by accident?
AMelonInsideLemon commented 2025-08-16 13:26:57 -07:00
Author
Member
Copy Link

There is no need to change Tag if Goal contains only one Node

There is no need to change `Tag` if Goal contains only one Node
Sainan merged commit b885d7766c into main 2025-08-17 13:11:56 -07:00
Sainan deleted branch goal-anniversary 2025-08-17 13:11:58 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2640
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:goal-anniversary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?