OpenWF/SpaceNinjaServer
21
23
Fork 29
Code Issues 22 Pull Requests 2 Actions Packages Projects Releases Activity

Handle Railjack Abandoned Caches #2610

Closed
VampireKitten wants to merge 4 commits from VampireKitten:railjackabandonedcaches into main
pull from: VampireKitten:railjackabandonedcaches
merge into: OpenWF:main
Conversation 3 Commits 4 Files Changed 4 +37 -8
VampireKitten commented 2025-08-12 06:28:23 -07:00
Contributor
Copy Link

Closes #2602

Closes #2602
VampireKitten added 1 commit 2025-08-12 06:28:23 -07:00
Handle Railjack Abandoned Caches
All checks were successful
Build / build (pull_request) Successful in 54s
Details
6d22d7912c
Sainan commented 2025-08-12 06:30:43 -07:00
Owner
Copy Link

Are these railjack abandoned caches only applicable to veil proxima?

Are these railjack abandoned caches only applicable to veil proxima?
VampireKitten commented 2025-08-12 06:33:08 -07:00
Author
Contributor
Copy Link

Are these railjack abandoned caches only applicable to veil proxima?

No, they should apply to every railjack node with a cache reward manifest, which is... all of them except the Adversary assassination ones.

> Are these railjack abandoned caches only applicable to veil proxima? No, they should apply to every railjack node with a cache reward manifest, which is... all of them except the Adversary assassination ones.
Sainan commented 2025-08-12 06:34:52 -07:00
Owner
Copy Link

Well, I guess you did add a check for if the node has a cacheRewardManifest, but it might be better to warn in case these fields are non-zero and the node doesn't have this data.

Well, I guess you did add a check for if the node has a `cacheRewardManifest`, but it might be better to warn in case these fields are non-zero and the node doesn't have this data.
VampireKitten added 1 commit 2025-08-12 06:40:11 -07:00
Add warning for missing cache reward manifest
Some checks failed
Build / build (pull_request) Failing after 1m1s
Details
f3beebc53d
VampireKitten added 1 commit 2025-08-12 06:40:38 -07:00
Merge branch 'main' into railjackabandonedcaches
Some checks failed
Build / build (pull_request) Failing after 58s
Details
75779649b3
VampireKitten added 1 commit 2025-08-12 06:51:44 -07:00
revert 75779649b3220b7cbf3d1e5e179151a867fc7358
Some checks failed
Build / build (pull_request) Failing after 54s
Details
9ae925fd43 
revert Merge branch 'main' into railjackabandonedcaches
VampireKitten closed this pull request 2025-08-12 06:55:03 -07:00
Some checks failed
Build / build (pull_request) Failing after 54s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2610
No description provided.
Delete Branch "VampireKitten:railjackabandonedcaches"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?