OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

feat: tactical alerts #2607

Merged
Sainan merged 9 commits from AMelonInsideLemon/SpaceNinjaServer:goal-dog-days into main 2025-08-13 07:13:07 -07:00
Conversation 13 Commits 9 Files Changed 17 +1100 -23
AMelonInsideLemon commented 2025-08-11 11:17:36 -07:00
Member
Copy Link

Includes all Tactical Alerts since Star Chart 3.0 with exception:
Snowday Showdown
Wolf Hunt (2019) (couldn't find corresponded EventNode for that)
Void Corruption (that's goes into Alerts)
All Warframe's Anniversary

Re #1103

Includes all `Tactical Alerts` since Star Chart 3.0 with exception: `Snowday Showdown` `Wolf Hunt (2019)` (couldn't find corresponded `EventNode` for that) `Void Corruption` (that's goes into `Alerts`) All `Warframe's Anniversary` Re #1103
Sainan reviewed 2025-08-11 11:28:23 -07:00
config-vanilla.json Outdated
@ -76,2 +76,4 @@
"plagueStarOverride": null,
"starDaysOverride": null,
"waterFightOverride": null,
"waterFightRewardsOverride": null,
Sainan commented 2025-08-11 11:28:23 -07:00
Owner
Copy Link

I don't love the use of codenames in the config, as it's still meant to be somewhat user-facing.

I don't love the use of codenames in the config, as it's still meant to be somewhat user-facing.
Sainan marked this conversation as resolved
Sainan commented 2025-08-11 12:12:50 -07:00
Owner
Copy Link

Also a minor thing is that RegularCredits should be deleted when transforming message database to client since that's definitely not a real field (the credit reward is likely not even given via the inbox message)

Also a minor thing is that `RegularCredits` should be deleted when transforming message database to client since that's definitely not a real field (the credit reward is likely not even given via the inbox message)
AMelonInsideLemon commented 2025-08-11 12:19:09 -07:00
Author
Member
Copy Link

If that not real field then why i see it on https://api.warframe.com/api/inbox.php?

If that not real field then why i see it on https://api.warframe.com/api/inbox.php?
Sainan commented 2025-08-11 12:38:47 -07:00
Owner
Copy Link

Oh nvm, I guess I was looking at the wrong log.

Oh nvm, I guess I was looking at the wrong log.
Sainan approved these changes 2025-08-11 12:38:54 -07:00
Dismissed
AMelonInsideLemon changed title from feat: dog days to feat: tactical alerts 2025-08-12 00:39:23 -07:00
Sainan commented 2025-08-12 06:33:09 -07:00
Owner
Copy Link

Merge conflict, could you please rebase

Merge conflict, could you please rebase
qingchun commented 2025-08-12 06:56:30 -07:00
Contributor
Copy Link

Sorry to bother you, but would you consider adding Thermia Fractures? Thank you so much.

Sorry to bother you, but would you consider adding Thermia Fractures? Thank you so much.
AMelonInsideLemon force-pushed goal-dog-days from 72572f2c47 to 6b3aa11ec1 2025-08-12 08:34:55 -07:00 Compare
AMelonInsideLemon commented 2025-08-12 08:36:32 -07:00
Author
Member
Copy Link

Merge conflict, could you please rebase

Done

> Merge conflict, could you please rebase Done
Sainan reviewed 2025-08-12 08:45:30 -07:00
src/services/worldStateService.ts Outdated
@ -1403,2 +1404,3 @@
...staticWorldState,
SyndicateMissions: [...staticWorldState.SyndicateMissions]
SyndicateMissions: [...staticWorldState.SyndicateMissions],
InGameMarket: staticWorldState.InGameMarket
Sainan commented 2025-08-12 08:45:30 -07:00
Owner
Copy Link

This is not creating a copy, so every single request to the worldState endpoint where this array is mutated persists those changes.

This is not creating a copy, so every single request to the worldState endpoint where this array is mutated persists those changes.
Sainan marked this conversation as resolved
Sainan dismissed Sainan’s review 2025-08-12 08:46:03 -07:00
Animan8000 commented 2025-08-12 08:46:03 -07:00
Contributor
Copy Link

Typo in comments (present in a couple of more places, than the screenshot). Incompatible*

Typo in comments (present in a couple of more places, than the screenshot). `Incompatible`*
Animan8000 commented 2025-08-12 09:18:17 -07:00
Contributor
Copy Link

Uhhh, should we maybe just have the year load from a |YEAR| value? Because otherwise we end up with that, having identical strings with different years, resulting into (probably-)pointless extra strings.

Uhhh, should we maybe just have the year load from a |YEAR| value? Because otherwise we end up with that, having identical strings with different years, resulting into (probably-)pointless extra strings.
AMelonInsideLemon added 1 commit 2025-08-12 09:41:10 -07:00
data-loc-year
All checks were successful
Build / build (pull_request) Successful in 56s
Details
344e37db01
Sainan reviewed 2025-08-12 09:52:13 -07:00
Sainan approved these changes 2025-08-12 10:46:33 -07:00
Sainan added 1 commit 2025-08-12 10:48:42 -07:00
fix doubled colons
All checks were successful
Build / build (pull_request) Successful in 1m1s
Details
6235b87561
Sainan added 1 commit 2025-08-12 10:53:03 -07:00
use warning icon for incompatibility notes
Some checks failed
Build / build (pull_request) Failing after 51s
Details
6688a97184
Sainan added 1 commit 2025-08-12 10:53:34 -07:00
prettier
All checks were successful
Build / build (pull_request) Successful in 1m0s
Details
411d8d1950
Sainan merged commit fd2ec696a0 into main 2025-08-13 07:13:07 -07:00
Sainan deleted branch goal-dog-days 2025-08-13 07:13:10 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2607
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:goal-dog-days"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?