feat(webui): edit suit invigorations #2478

Merged
Sainan merged 12 commits from nyaoouo/SpaceNinjaServer:ImplEditSuitInvigorationUpgradeController into main 2025-07-14 20:33:38 -07:00
Contributor
No description provided.
nyaoouo added 1 commit 2025-07-12 08:32:02 -07:00
impl editSuitInvigorationUpgradeController in web ui
All checks were successful
Build / build (pull_request) Successful in 56s
8c2b4f2c48
Sainan reviewed 2025-07-12 08:43:13 -07:00
@ -2865,0 +2922,4 @@
form.style.left = "50%";
form.style.transform = "translate(-50%, -50%)";
form.style.zIndex = "1050";
form.style.width = "400px";
Owner

If you need godawful custom CSS, put it in the CSS file.

If you need godawful custom CSS, put it in the CSS file.
Sainan marked this conversation as resolved
Sainan reviewed 2025-07-12 08:43:24 -07:00
@ -45,6 +46,7 @@ customRouter.get("/addMissingMaxRankMods", addMissingMaxRankModsController);
customRouter.get("/webuiFileChangeDetected", webuiFileChangeDetectedController);
customRouter.get("/completeAllMissions", completeAllMissionsController);
customRouter.get("/addMissingHelminthBlueprints", addMissingHelminthBlueprintsController);
customRouter.post("/editSuitInvigorationUpgrade", editSuitInvigorationUpgradeController);
Owner

Really? Don't see what's wrong here?

Really? Don't see what's wrong here?
Sainan marked this conversation as resolved
Sainan reviewed 2025-07-12 08:43:44 -07:00
@ -977,6 +977,59 @@
</div>
<div class="toast-container position-fixed bottom-0 end-0 p-3"></div>
</div>
<div id="editSuitInvigorationForm" class="card" style="display: none;">
Owner

What is this shit? We have a detailedView, this is completely misplaced.

What is this shit? We have a detailedView, this is completely misplaced.
Author
Contributor

detailed view dont pass detail of item to view, cannot auto fillin data

detailed view dont pass detail of item to view, cannot auto fillin data
Owner

Damn, all the other features on the detailed view must be magic then. Purely guessing the data to fill in. What a miracle that it guesses correctly.

Damn, all the other features on the detailed view must be magic then. Purely guessing the data to fill in. What a miracle that it guesses correctly.
Author
Contributor

i found it, but i want to remind u that part is id="archonShards-card" =_=

i found it, but i want to remind u that part is `id="archonShards-card"` =_=
Contributor

And id="modularParts-card" and id="valenceBonus-card" is under id="detailedView-route"

And `id="modularParts-card"` and `id="valenceBonus-card"` is under `id="detailedView-route"`
Sainan marked this conversation as resolved
nyaoouo added 1 commit 2025-07-12 09:29:49 -07:00
fix coding
All checks were successful
Build / build (pull_request) Successful in 57s
164e3e7c12
nyaoouo added 1 commit 2025-07-12 10:02:31 -07:00
move InvigorationUpgrade from modal to detailed view
All checks were successful
Build / build (pull_request) Successful in 51s
8d144188f7
nyaoouo added 1 commit 2025-07-12 10:05:51 -07:00
remove unused style
All checks were successful
Build / build (pull_request) Successful in 55s
9be4e14de2
Sainan reviewed 2025-07-12 21:16:43 -07:00
@ -477,2 +477,4 @@
<tbody id="crystals-list"></tbody>
</table>
<form onsubmit="submitSuitInvigorationUpgrade(event)">
<input type="hidden" id="dv-invigoration-oid" />
Owner

The oid is already in the query string. Be consistent.

The oid is already in the query string. Be consistent.
Sainan marked this conversation as resolved
Sainan changed title from impl editSuitInvigorationUpgradeController in web ui to WIP: impl editSuitInvigorationUpgradeController in web ui 2025-07-12 21:20:02 -07:00
nyaoouo added 1 commit 2025-07-13 03:56:09 -07:00
Remove unused field
All checks were successful
Build / build (pull_request) Successful in 1m32s
fb7d5efa0a
Sainan reviewed 2025-07-13 04:03:52 -07:00
@ -1232,1 +1232,4 @@
});
const { OffensiveUpgrade, DefensiveUpgrade, UpgradesExpiry } =
suitInvigorationUpgradeData(item);
document.getElementById("dv-invigoration-oid").value = oid;
Owner

Unused?

Unused?
nyaoouo marked this conversation as resolved
nyaoouo added 1 commit 2025-07-13 04:45:20 -07:00
remove unused line
All checks were successful
Build / build (pull_request) Successful in 1m3s
0921fef757
nyaoouo changed title from WIP: impl editSuitInvigorationUpgradeController in web ui to impl editSuitInvigorationUpgradeController in web ui 2025-07-13 09:06:09 -07:00
Sainan reviewed 2025-07-13 21:07:01 -07:00
@ -476,6 +476,51 @@
<table class="table table-hover w-100">
<tbody id="crystals-list"></tbody>
</table>
<form onsubmit="submitSuitInvigorationUpgrade(event)">
Owner

Why is this inside of the archon crystals card and not its own card?

Why is this inside of the archon crystals card and not its own card?
Author
Contributor

Because I didn't realize that you used path route first and then only controlled visibility based on url params...

Because I didn't realize that you used path route first and then only controlled visibility based on url params...
Sainan marked this conversation as resolved
Sainan changed title from impl editSuitInvigorationUpgradeController in web ui to feat(webui): edit suit invigorations 2025-07-13 21:07:57 -07:00
nyaoouo added 1 commit 2025-07-14 05:05:40 -07:00
seperate card
All checks were successful
Build / build (pull_request) Successful in 1m3s
89d0c472c4
nyaoouo added 1 commit 2025-07-14 05:06:15 -07:00
show card
All checks were successful
Build / build (pull_request) Successful in 1m0s
2c7905118b
Sainan reviewed 2025-07-14 05:09:30 -07:00
@ -480,1 +480,4 @@
</div>
<div id="edit-suit-invigorations-card" class="card mb-3 d-none">
<h5 class="card-header">
edit suit invigorations
Owner

All your strings should be added to the translation system. And let's not lowercase a title? 😒

All your strings should be added to the translation system. And let's not lowercase a title? 😒
Author
Contributor

because i just use my mobile phone to edit it =_=...

because i just use my mobile phone to edit it =_=...
Owner

Try coding on a PC. :)

Try coding on a PC. :)
Sainan marked this conversation as resolved
nyaoouo added 1 commit 2025-07-14 05:24:34 -07:00
set card tittle translation
All checks were successful
Build / build (pull_request) Successful in 1m43s
870dfb377f
nyaoouo added 1 commit 2025-07-14 05:27:08 -07:00
Merge remote-tracking branch 'upstream/main' into ImplEditSuitInvigorationUpgradeController
All checks were successful
Build / build (pull_request) Successful in 1m5s
4f6f8a2c81
Sainan reviewed 2025-07-14 05:44:17 -07:00
@ -481,0 +482,4 @@
<h5 class="card-header" data-loc="detailedView_editSuitInvigoration"></h5>
<div class="card-body">
<form onsubmit="submitSuitInvigorationUpgrade(event)">
<div class="mb-3">
Owner

There are a few more strings here...

There are a few more strings here...
Author
Contributor

I don't know the exact translation of the attributes, so I'll just estimate it based on the key.

I don't know the exact translation of the attributes, so I'll just estimate it based on the key.
Sainan marked this conversation as resolved
Sainan reviewed 2025-07-14 05:44:33 -07:00
@ -2866,0 +2907,4 @@
const expiry = document.getElementById("dv-invigoration-expiry").value;
if (!offensiveUpgrade && !defensiveUpgrade) {
alert("Please select at least one upgrade type.");
Owner

...and here.

...and here.
Sainan marked this conversation as resolved
nyaoouo added 1 commit 2025-07-14 06:20:57 -07:00
add i18n
All checks were successful
Build / build (pull_request) Successful in 59s
ac2a239e53
Sainan approved these changes 2025-07-14 08:36:16 -07:00
Sainan added 1 commit 2025-07-14 20:26:38 -07:00
Merge remote-tracking branch 'gitea/main' into ImplEditSuitInvigorationUpgradeController
All checks were successful
Build / build (pull_request) Successful in 1m3s
ac01a70298
Sainan merged commit b60723ef54 into main 2025-07-14 20:33:38 -07:00
Sainan deleted branch ImplEditSuitInvigorationUpgradeController 2025-07-14 20:33:38 -07:00
Sign in to join this conversation.
No description provided.