OpenWF/SpaceNinjaServer
21
23
Fork 24
Code Issues 22 Pull Requests 3 Actions Packages Projects Releases Activity

feat(webui): Valence Bonus #2348

Merged
Sainan merged 1 commits from AMelonInsideLemon/SpaceNinjaServer:webui-valence-bonus into main 2025-06-29 09:28:29 -07:00
Conversation 5 Commits 1 Files Changed 11 +299 -79
AMelonInsideLemon commented 2025-06-28 14:46:49 -07:00
Contributor
Copy Link

Closes #1181

Closes #1181
AMelonInsideLemon added 1 commit 2025-06-28 14:46:49 -07:00
feat(webui): Valence Bonus
All checks were successful
Build / build (pull_request) Successful in 46s
Details
ac1928e02e 
Closes #1181
AMelonInsideLemon force-pushed webui-valence-bonus from ac1928e02e to fd6b6ec9ab 2025-06-28 14:49:41 -07:00 Compare
Sainan reviewed 2025-06-28 14:52:36 -07:00
static/webui/script.js Outdated
@ -2119,3 +2160,3 @@
window.authz +
"&oid=" +
single.getCurrentPath().substr(17) +
urlParams.get("itemId") +
Sainan commented 2025-06-28 14:52:36 -07:00
Owner
Copy Link

This doesn't work without reloading the page because urlParams is never updated.

This doesn't work without reloading the page because `urlParams` is never updated.
AMelonInsideLemon marked this conversation as resolved
Sainan commented 2025-06-28 14:53:55 -07:00
Owner
Copy Link

Nit-pick: Use the d-none class instead of inline display: none

Nit-pick: Use the `d-none` class instead of inline `display: none`
Sainan reviewed 2025-06-28 14:54:37 -07:00
static/webui/translations/en.js Outdated
@ -117,0 +119,4 @@
detailedView_archonShardsDescription: `You can use these unlimited slots to apply a wide range of upgrades.`,
detailedView_archonShardsDescription2: `Note that each archon shard takes some time to be applied when loading in.`,
detailedView_valenceBonusLabel: `Valence Bonus`,
detailedView_valenceBonusDescription: `You can add or remove the Valence Bonus from your weapon.`,
Sainan commented 2025-06-28 14:54:37 -07:00
Owner
Copy Link

Should be "set or remove" to be consistent with the button labels.

Should be "set or remove" to be consistent with the button labels.
AMelonInsideLemon marked this conversation as resolved
AMelonInsideLemon added 1 commit 2025-06-28 15:03:48 -07:00
fix
All checks were successful
Build / build (pull_request) Successful in 1m35s
Details
bdd6de80f8
Sainan approved these changes 2025-06-28 15:07:20 -07:00
Sainan commented 2025-06-29 09:08:25 -07:00
Owner
Copy Link

urg, looks like there's a merge conflict now

urg, looks like there's a merge conflict now
Sainan force-pushed webui-valence-bonus from bdd6de80f8 to 88173285ff 2025-06-29 09:25:50 -07:00 Compare
Sainan force-pushed webui-valence-bonus from 88173285ff to 47b822752e 2025-06-29 09:27:20 -07:00 Compare
Sainan merged commit d1c860c693 into main 2025-06-29 09:28:29 -07:00
Sainan deleted branch webui-valence-bonus 2025-06-29 09:28:29 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2348
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:webui-valence-bonus"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?