OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat: clearing lich infuance #1270

Merged
Sainan merged 2 commits from AMelonInsideLemon/SpaceNinjaServer:nemesis-influance into main 2025-03-22 06:08:01 -07:00
Conversation 7 Commits 2 Files Changed 7 +92 -52
AMelonInsideLemon commented 2025-03-22 00:43:06 -07:00
Contributor
Copy Link

Re #1253
idk what field is increasing duet change

Re #1253 idk what field is increasing duet change
AMelonInsideLemon added 1 commit 2025-03-22 00:43:06 -07:00
feat: clearing lich infuance
All checks were successful
Build / build (22) (pull_request) Successful in 41s
Details
Build / build (20) (pull_request) Successful in 1m9s
Details
Build / build (18) (pull_request) Successful in 1m22s
Details
ae62e9f47c 
Closes #1253
Sainan commented 2025-03-22 01:01:08 -07:00
Owner
Copy Link

PR looks good to me, but regarding the duet chance, I'd like to be sure that's working. I see there's the MissionCount and LastEnc fields in the inventory Nemesis object now, both of which should probably be incremented after every mission completion, at least for infested liches, and I think then the duet chance might also update as expected?

PR looks good to me, but regarding the duet chance, I'd like to be sure that's working. I see there's the `MissionCount` and `LastEnc` fields in the inventory `Nemesis` object now, both of which should probably be incremented after every mission completion, at least for infested liches, and I think then the duet chance might also update as expected?
Sainan commented 2025-03-22 01:02:40 -07:00
Owner
Copy Link

Also since you did add the InfNodes logic, what I did notice now is that once HenchmenKilled reaches 100 for the infested lich, the InfNodes contains the railjack mission:

        "InfNodes": [
            {
                "Node": "CrewBattleNode559",
                "Influence": 1
            }
        ],
Also since you did add the InfNodes logic, what I did notice now is that once `HenchmenKilled` reaches 100 for the infested lich, the InfNodes contains the railjack mission: ```json "InfNodes": [ { "Node": "CrewBattleNode559", "Influence": 1 } ], ```
AMelonInsideLemon commented 2025-03-22 01:07:24 -07:00
Author
Contributor
Copy Link

When infested lich comes to railjack Weakened sets to true?

When infested lich comes to railjack `Weakened` sets to `true`?
Sainan commented 2025-03-22 01:07:31 -07:00
Owner
Copy Link

Another nitpick would be that systemIndexes can be an array instead of an object with indexes that just happen to start at 0 and then increment...

Another nitpick would be that `systemIndexes` can be an array instead of an object with indexes that just happen to start at 0 and then increment...
Sainan commented 2025-03-22 01:08:35 -07:00
Owner
Copy Link

When infested lich comes to railjack Weakened sets to true?

Hmm, appears so.

> When infested lich comes to railjack `Weakened` sets to `true`? Hmm, appears so.
AMelonInsideLemon changed title from feat: clearing lich infuance to WIP: feat: clearing lich infuance 2025-03-22 01:09:15 -07:00
AMelonInsideLemon added 1 commit 2025-03-22 02:45:35 -07:00
weakening infested lich
All checks were successful
Build / build (18) (pull_request) Successful in 48s
Details
Build / build (20) (pull_request) Successful in 1m11s
Details
Build / build (22) (pull_request) Successful in 44s
Details
4eee6a95fe
AMelonInsideLemon commented 2025-03-22 02:45:43 -07:00
Author
Contributor
Copy Link

duet chance = (MissionCount - LastEnc + 1) * 25

MissionCount should be incremented when you clear mission from infested lich infuance, LastEnc should be set to MissionCount when band is spawned. but i cannot spawn it because game calls #1272 before spawning them

duet chance = (`MissionCount` - `LastEnc` + 1) * 25 `MissionCount` should be incremented when you clear mission from infested lich infuance, `LastEnc` should be set to `MissionCount` when band is spawned. but i cannot spawn it because game calls #1272 before spawning them
AMelonInsideLemon changed title from WIP: feat: clearing lich infuance to feat: clearing lich infuance 2025-03-22 04:39:58 -07:00
Sainan approved these changes 2025-03-22 04:43:10 -07:00
Sainan merged commit c6a2785175 into main 2025-03-22 06:08:01 -07:00
Sainan deleted branch nemesis-influance 2025-03-22 06:08:01 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1270
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:nemesis-influance"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?