OpenWF/SpaceNinjaServer
21
23
Fork 29
Code Issues 23 Pull Requests 3 Actions Packages Projects Releases Activity

feat(goals): cetus events #2598

Merged
Sainan merged 5 commits from AMelonInsideLemon/SpaceNinjaServer:goals-cetus into main 2025-08-11 08:08:41 -07:00
Conversation 5 Commits 5 Files Changed 13 +305 -38
AMelonInsideLemon commented 2025-08-08 16:58:07 -07:00
Contributor
Copy Link

Includes Plague Star and Ghoul Purge.
Translation for webUI taken from game files.
Re #1103

Includes `Plague Star` and `Ghoul Purge`. Translation for webUI taken from game files. Re #1103
AMelonInsideLemon added 1 commit 2025-08-08 16:58:08 -07:00
feat(goals): cetus events
All checks were successful
Build / build (pull_request) Successful in 51s
Details
4606980d7f 
Includes `Plague Star` and `Ghoul Purge`.
Translation for webUI taken from game files.
Re #1103
AMelonInsideLemon added 1 commit 2025-08-08 17:10:38 -07:00
Update missionInventoryUpdateService.ts
All checks were successful
Build / build (pull_request) Successful in 57s
Details
19c2e85c44
Sainan reviewed 2025-08-08 17:27:24 -07:00
src/services/missionInventoryUpdateService.ts Outdated
@ -1259,6 +1259,8 @@ export const addMissionRewards = async (
}
}
if (!AffiliationMods) AffiliationMods ??= [];
Sainan commented 2025-08-08 17:27:24 -07:00
Owner
Copy Link

if (!AffiliationMods) seems redundant when you do ??= anyway

`if (!AffiliationMods)` seems redundant when you do `??=` anyway
AMelonInsideLemon marked this conversation as resolved
Sainan reviewed 2025-08-08 17:28:43 -07:00
src/services/configService.ts Outdated
@ -95,2 +95,4 @@
varziaOverride?: string;
varziaFullyStocked?: boolean;
plagueStar?: boolean;
ghoulEmergence?: boolean;
Sainan commented 2025-08-08 17:28:43 -07:00
Owner
Copy Link

The ordering here seems a bit weird compared to how they are ordered in the WebUI.

Also, from what I understand, these are periodic events, so something similar to Star Days would seem more appropriate.

The ordering here seems a bit weird compared to how they are ordered in the WebUI. Also, from what I understand, these are periodic events, so something similar to Star Days would seem more appropriate.
VampireKitten commented 2025-08-08 17:50:08 -07:00
Contributor
Copy Link

Plague Star is... awkwardly periodic. In that it kinda happens whenever DE remembers they got the code for it. There is... zero consistency for it, in terms of when it happens, how long it lasts, or when it's supposed to come back. Ghoul Purge and Thermia Fractures are also similarly awkwardly periodic, only they are properly recurring, just nobody has any idea when they'll actually drop until they do, save for a vague "every few weeks".

image.png

Plague Star is... *awkwardly* periodic. In that it kinda happens whenever DE remembers they got the code for it. There is... zero consistency for it, in terms of when it happens, how long it lasts, or when it's supposed to come back. Ghoul Purge and Thermia Fractures are also similarly awkwardly periodic, only they *are* properly recurring, just nobody has any idea *when* they'll actually drop until they do, save for a vague "every few weeks". ![image.png](/attachments/4e7d95d4-2674-45e8-9b9f-c8fbb36da5e1)
image.png
99 KiB
Sainan commented 2025-08-08 18:26:08 -07:00
Owner
Copy Link

From a quick historical analysis, I can see that ghoul purge is active for 3-4 days and inactive for 15-17 days.

From a quick historical analysis, I can see that ghoul purge is active for 3-4 days and inactive for 15-17 days.
Sainan marked this conversation as resolved
AMelonInsideLemon added 1 commit 2025-08-08 19:56:54 -07:00
make Ghoul Purge and Plague Star events periodic
All checks were successful
Build / build (pull_request) Successful in 55s
Details
dedf73b5ee
Sainan reviewed 2025-08-09 03:40:32 -07:00
config-vanilla.json Outdated
@ -84,1 +84,3 @@
"varziaFullyStocked": false
"varziaFullyStocked": false,
"plagueStar": null,
"ghoulEmergence": null
Sainan commented 2025-08-09 03:40:32 -07:00
Owner
Copy Link

Still ordered & named awkwardly:

  • Move it before starDaysOverride in config-vanilla.json + configService.ts to match the webui ordering.
  • Rename to plagueStarOverride and ghoulEmergenceOverride to match starDaysOverride.
Still ordered & named awkwardly: - Move it before `starDaysOverride` in config-vanilla.json + configService.ts to match the webui ordering. - Rename to `plagueStarOverride` and `ghoulEmergenceOverride` to match `starDaysOverride`.
Sainan marked this conversation as resolved
AMelonInsideLemon added 1 commit 2025-08-09 04:48:23 -07:00
reordering
All checks were successful
Build / build (pull_request) Successful in 55s
Details
b9ac660b7e
Sainan reviewed 2025-08-10 06:40:54 -07:00
config-vanilla.json Outdated
@ -73,2 +73,4 @@
"tennoLiveRelay": false,
"galleonOfGhouls": 0,
"ghoulEmergence": null,
"plagueStar": null,
Sainan commented 2025-08-10 06:40:54 -07:00
Owner
Copy Link

These fields obviously mismatch with the typings.

These fields obviously mismatch with the typings.
Sainan marked this conversation as resolved
AMelonInsideLemon added 1 commit 2025-08-10 08:04:55 -07:00
Update config-vanilla.json
All checks were successful
Build / build (pull_request) Successful in 58s
Details
27e1621c26
Sainan approved these changes 2025-08-10 16:52:51 -07:00
Sainan merged commit 51c0ddda38 into main 2025-08-11 08:08:41 -07:00
Sainan deleted branch goals-cetus 2025-08-11 08:08:41 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2598
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:goals-cetus"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?