OrdisPrime
  • Joined on 2025-02-01
OrdisPrime merged pull request OpenWF/SpaceNinjaServer#1022 2025-02-25 17:31:25 -08:00
fix: increment LoreFragmentScans Progress when already present
OrdisPrime closed issue OpenWF/SpaceNinjaServer#1021 2025-02-25 17:31:25 -08:00
Lore Fragment Scans are not saved correctly
OrdisPrime deleted branch null-upgrade from OpenWF/SpaceNinjaServer 2025-02-25 17:31:18 -08:00
OrdisPrime pushed to main at OpenWF/SpaceNinjaServer 2025-02-25 17:31:17 -08:00
8fea608b76 fix: fill upgrades array with empty strings (#1023)
OrdisPrime merged pull request OpenWF/SpaceNinjaServer#1023 2025-02-25 17:31:17 -08:00
fix: fill upgrades array with empty strings
OrdisPrime closed issue OpenWF/SpaceNinjaServer#945 2025-02-25 17:26:42 -08:00
The Duviri Paradox Quest unlocking too early
OrdisPrime pushed to main at OpenWF/SpaceNinjaServer 2025-02-25 17:26:24 -08:00
c13cf70814 fix: update vor's prize completion rewards
OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 17:00:49 -08:00
chore: simplify conversion of missionReward from PE+

If anything, this example shows, that we cannot just remove /storeItems/ and think its the normal non-store variant. It shows we ALWAYS have to look up typeName.

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:59:27 -08:00
chore: simplify conversion of missionReward from PE+

Yes, DE is wrong, it's surely not our code that's making stupid assumption.

you can't tell me you don't think that's a typing mistake. the client's data have shown REPEATEDLY in the past how…

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:57:54 -08:00
chore: simplify conversion of missionReward from PE+

well, okey. if the data are bad, we are doomed to find more of these annoying bugs anyway. KK. remove the logic.

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:57:16 -08:00
chore: simplify conversion of missionReward from PE+

Bro.

  • Normal: /Lotus/Types/StoreItems/AvatarImages/ImageGaussVED
  • Store item: /Lotus/StoreItems/Types/StoreItems/AvatarImages/ImageGaussVED

Ah so im too tired I think its a…

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:55:55 -08:00
chore: simplify conversion of missionReward from PE+

Seems like this item does not have a non-store item counterpart. For some reason

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:54:40 -08:00
chore: simplify conversion of missionReward from PE+

well, it contains /storeitem/ so its a store item? :D

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:53:33 -08:00
chore: simplify conversion of missionReward from PE+

Example: /Lotus/Types/StoreItems/AvatarImages/ImageGaussVED :)

I'd say the data is as close to perfect as it gets, it's just a matter of respecting the 'types'.

But that's a store…

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:50:35 -08:00
chore: simplify conversion of missionReward from PE+

The additional check does harm because /StoreItems/ may be a substring of a non-StoreItem. Also if we assume the data is inaccurate, then we have a lot of other problems.

Why would…

OrdisPrime commented on issue OpenWF/SpaceNinjaServer#1020 2025-02-25 16:35:06 -08:00
Obtaining Excalibur via Awakening does not reward the Exalted Blade

Yea, startingGear uses addEquipment, which does not check for AdditionalItems.

OrdisPrime commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:33:27 -08:00
chore: simplify conversion of missionReward from PE+

I would like to keep the current way as a sanity check. If for some reason, the data should contain non store items, then the client will bug out receiving them as missionrewards. So, the…

OrdisPrime merged pull request OpenWF/SpaceNinjaServer#1017 2025-02-25 10:08:31 -08:00
fix: converting storeitems
OrdisPrime pushed to main at OpenWF/SpaceNinjaServer 2025-02-25 10:08:31 -08:00
a27f1c5e01 fix: converting storeitems in missionRewards (#1017)
OrdisPrime merged pull request OpenWF/SpaceNinjaServer#1016 2025-02-25 04:42:50 -08:00
fix: items from enemy caches not showing "identified"