OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat: implement CreditBundle purchases #989

Merged
OrdisPrime merged 5 commits from neon/SpaceNinjaServer:credit-bundles into main 2025-02-23 03:53:57 -08:00
Conversation 11 Commits 5 Files Changed 2 +22 -1
neon commented 2025-02-22 13:15:49 -08:00
Contributor
Copy Link

This fixes purchasing one of the few bundles that include these credit bundles. Ex: Essential Damage mod bundles

This fixes purchasing one of the few bundles that include these credit bundles. Ex: Essential Damage mod bundles
neon added 1 commit 2025-02-22 13:15:49 -08:00
feat: implement creditbundle purchases
All checks were successful
Build / build (20) (pull_request) Successful in 34s
Details
Build / build (18) (pull_request) Successful in 1m1s
Details
Build / build (22) (pull_request) Successful in 1m12s
Details
de9283e3a7
neon added 1 commit 2025-02-22 13:22:40 -08:00
handle invalid bundle request
All checks were successful
Build / build (20) (pull_request) Successful in 33s
Details
Build / build (18) (pull_request) Successful in 58s
Details
Build / build (22) (pull_request) Successful in 1m11s
Details
2dfb36018f
neon force-pushed credit-bundles from cd6f773ec1 to af7df53799 2025-02-22 13:31:45 -08:00 Compare
OrdisPrime commented 2025-02-22 16:28:46 -08:00
Owner
Copy Link

does it not work to add the 2 bundles here?
export const creditBundles:

does it not work to add the 2 bundles here? export const creditBundles:
neon commented 2025-02-22 16:31:39 -08:00
Author
Contributor
Copy Link

does it not work to add the 2 bundles here?
export const creditBundles:

why? the game already provides them

> does it not work to add the 2 bundles here? > export const creditBundles: why? the game already provides them
neon commented 2025-02-22 16:32:42 -08:00
Author
Contributor
Copy Link

does it not work to add the 2 bundles here?
export const creditBundles:

why? the game already provides them

plus they are only used in market purchases so there is no need to define them somewhere

> > does it not work to add the 2 bundles here? > > export const creditBundles: > > why? the game already provides them plus they are only used in market purchases so there is no need to define them somewhere
Sainan commented 2025-02-22 16:35:58 -08:00
Owner
Copy Link

creditBundles is a map defined in missionInventoryUpdateService. You should use it instead of doing this crap.

`creditBundles` is a map defined in missionInventoryUpdateService. You should use it instead of doing this crap.
neon commented 2025-02-22 16:37:18 -08:00
Author
Contributor
Copy Link

creditBundles is a map defined in missionInventoryUpdateService. You should use it instead of doing this crap.
Those only include mission credit bundles, not market credit bundles

> `creditBundles` is a map defined in missionInventoryUpdateService. You should use it instead of doing this crap. Those only include mission credit bundles, not market credit bundles
neon commented 2025-02-22 16:38:06 -08:00
Author
Contributor
Copy Link

creditBundles is a map defined in missionInventoryUpdateService. You should use it instead of doing this crap.
Those only include mission credit bundles, not market credit bundles
although i will add those ones there and use it now that i think about it.

> > `creditBundles` is a map defined in missionInventoryUpdateService. You should use it instead of doing this crap. > Those only include mission credit bundles, not market credit bundles although i will add those ones there and use it now that i think about it.
neon added 1 commit 2025-02-22 16:46:33 -08:00
use creditBundles
All checks were successful
Build / build (22) (pull_request) Successful in 41s
Details
Build / build (18) (pull_request) Successful in 1m3s
Details
Build / build (20) (pull_request) Successful in 1m1s
Details
ab111d5c57
Sainan commented 2025-02-22 16:49:05 -08:00
Owner
Copy Link

I'm pretty sure the logic as you have it now does not work.

I'm pretty sure the logic as you have it now does not work.
neon commented 2025-02-22 16:49:17 -08:00
Author
Contributor
Copy Link

@OrdisPrime what is your new discord account, i want to send you a message

@OrdisPrime what is your new discord account, i want to send you a message
neon added 1 commit 2025-02-22 16:53:46 -08:00
oversight
All checks were successful
Build / build (18) (pull_request) Successful in 41s
Details
Build / build (20) (pull_request) Successful in 1m0s
Details
Build / build (22) (pull_request) Successful in 1m9s
Details
998808505d
neon commented 2025-02-22 16:54:05 -08:00
Author
Contributor
Copy Link

oh yeah lol i forgot it needs to use internal name, now it works

oh yeah lol i forgot it needs to use internal name, now it works
Sainan commented 2025-02-22 17:04:50 -08:00
Owner
Copy Link

Closes #990. Sorry for my hesitation, but I do feel like this should eventually use ExportMisc.creditBundles from PE+.

Closes #990. Sorry for my hesitation, but I do feel like this should eventually use ExportMisc.creditBundles from PE+.
neon commented 2025-02-22 17:05:19 -08:00
Author
Contributor
Copy Link

Closes #990. Sorry for my hesitation, but I do feel like this should eventually use ExportMisc.creditBundles from PE+.

no worries, in this case i just followed what ordis said :)

> Closes #990. Sorry for my hesitation, but I do feel like this should eventually use ExportMisc.creditBundles from PE+. no worries, in this case i just followed what ordis said :)
OrdisPrime merged commit e1af6bd598 into main 2025-02-23 03:53:57 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#989
No description provided.
Delete Branch "neon/SpaceNinjaServer:credit-bundles"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?