OpenWF/SpaceNinjaServer
16
15
Fork 18
Code Issues 38 Pull Requests 4 Actions Packages Projects Releases Activity

feat: implement awakening quest completion (/api/giveStartingGear) #977

Closed
neon wants to merge 3 commits from neon/SpaceNinjaServer:starting-gear into main
pull from: neon/SpaceNinjaServer:starting-gear
merge into: OpenWF:main
Conversation 7 Commits 3 Files Changed 3 +5 -5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 605905c880 - Show all commits

10
src/controllers/api/giveStartingGear.ts
View File

@ -20,11 +20,6 @@ export const giveStartingGearController: RequestHandler = async (req, res) => {
const dataJSON = getJSONfromString<IStartingGearClient>(String(req.body));
await addKeyChainItems(inventory, {
KeyChain: "/Lotus/Types/Keys/VorsPrize/VorsPrizeQuestKeyChain",
ChainStage: 0
});
for (const key of Object.keys(dataJSON) as Array<keyof IStartingGearClient>) {
OrdisPrime commented 2025-02-20 02:52:40 -08:00
Review
Copy Link

this should not be here, the game handles trigger items itself.

this should not be here, the game handles trigger items itself.
neon commented 2025-02-20 02:54:53 -08:00
Review
Copy Link

if youre talking about missionInventoryUpdate, then no. the awakening quest doesnt call that. this is why it needs to be done here.

if youre talking about missionInventoryUpdate, then no. the awakening quest doesnt call that. this is why it needs to be done here.
OrdisPrime commented 2025-02-20 02:56:25 -08:00
Review
Copy Link

if youre talking about missionInventoryUpdate, then no. the awakening quest doesnt call that. this is why it needs to be done here.

What mission inventory update?
I marked the line addKeychain Items, this is not meant to be done here.

> if youre talking about missionInventoryUpdate, then no. the awakening quest doesnt call that. this is why it needs to be done here. What mission inventory update? I marked the line addKeychain Items, this is not meant to be done here.
neon commented 2025-02-20 02:56:58 -08:00
Review
Copy Link

Where else would u do it?

Where else would u do it?
OrdisPrime commented 2025-02-20 02:58:09 -08:00
Review
Copy Link

Not at all, because, as I said "the game handles trigger items itself."

Not at all, because, as I said "the game handles trigger items itself."
neon commented 2025-02-20 02:58:51 -08:00
Review
Copy Link

try it without but it didnt work for me

try it without but it didnt work for me
switch (key) {
// This is the only gear we receive as the rest will come from future quests
@ -49,6 +44,11 @@ export const giveStartingGearController: RequestHandler = async (req, res) => {
}
}
await addKeyChainItems(inventory, {
KeyChain: "/Lotus/Types/Keys/VorsPrize/VorsPrizeQuestKeyChain",
ChainStage: 0
});
addConsumables(inventory, [{ ItemCount: 1, ItemType: "/Lotus/Types/Restoratives/LisetAutoHack" }]);
if (!config.unlockAllFlavourItems) {
inventory.FlavourItems.push([