OpenWF/SpaceNinjaServer
16
15
Fork 18
Code Issues 38 Pull Requests 4 Actions Packages Projects Releases Activity

chore: send messages after completing quest instead of on account creation #976

Closed
neon wants to merge 5 commits from (deleted):messages into main
pull from: (deleted):messages
merge into: OpenWF:main
Conversation 7 Commits 5 Files Changed 3 +41 -38
neon commented 2025-02-20 02:08:04 -08:00
Contributor
Copy Link
No description provided.
neon added 5 commits 2025-02-20 02:08:05 -08:00
chore: send messages after completing quest
Some checks failed
Build / build (18) (pull_request) Failing after 36s
Details
Build / build (22) (pull_request) Failing after 57s
Details
Build / build (20) (pull_request) Failing after 1m9s
Details
8eae85486d
neon commented 2025-02-20 02:09:40 -08:00
Author
Contributor
Copy Link

ok im gonna have to re-clone this shit is cooked

ok im gonna have to re-clone this shit is cooked
Sainan commented 2025-02-20 02:10:26 -08:00
Owner
Copy Link

Or you could just look at the errors that eslint is giving...

Or you could just look at the errors that eslint is giving...
Sainan commented 2025-02-20 02:11:10 -08:00
Owner
Copy Link

Also use a proper GUI like Sublime Merge. Rebase should do the trick.

Also use a proper GUI like Sublime Merge. Rebase should do the trick.
neon commented 2025-02-20 02:11:43 -08:00
Author
Contributor
Copy Link

not getting any errors, at least not coming from my code. just had merge conflicts

not getting any errors, at least not coming from my code. just had merge conflicts
neon commented 2025-02-20 02:12:12 -08:00
Author
Contributor
Copy Link

i couldnt rebase for some reason xD

i couldnt rebase for some reason xD
Sainan commented 2025-02-20 02:12:18 -08:00
Owner
Copy Link

Your code definitely has lint errors, see the workflow failures.

Your code definitely has lint errors, see the workflow failures.
neon commented 2025-02-20 02:18:37 -08:00
Author
Contributor
Copy Link

ok i did just notice 2* unused variable in giveStartingGear.ts , but its not even showing up in workflow failures

ok i did just notice 2* unused variable in giveStartingGear.ts , but its not even showing up in workflow failures
neon closed this pull request 2025-02-20 02:40:01 -08:00
Some checks failed
Build / build (18) (pull_request) Failing after 36s
Details
Build / build (22) (pull_request) Failing after 57s
Details
Build / build (20) (pull_request) Failing after 1m9s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#976
No description provided.
Delete Branch "(deleted):messages"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?