OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

chore: enforce that account only owns one of 'singleton items' #969

Merged
Sainan merged 1 commits from singletons into main 2025-02-19 13:42:37 -08:00
Conversation 7 Commits 1 Files Changed 1 +6
Sainan commented 2025-02-19 13:19:35 -08:00
Owner
Copy Link
No description provided.
Sainan force-pushed singletons from d842576a0f to d1264b3549 2025-02-19 13:25:19 -08:00 Compare
OrdisPrime commented 2025-02-19 13:26:25 -08:00
Owner
Copy Link

should probably use the wishlist thingie and add all unique items in that list, not add items if they are in there.

should probably use the wishlist thingie and add all unique items in that list, not add items if they are in there.
OrdisPrime commented 2025-02-19 13:27:19 -08:00
Owner
Copy Link

there are many unique items which should be owned only once. we shouldnt have a check for every of those

there are many unique items which should be owned only once. we shouldnt have a check for every of those
Sainan commented 2025-02-19 13:27:44 -08:00
Author
Owner
Copy Link

They don't seem to use any different system for this. This is just a courtesy to ensure that SNS inventories stay in an expected state.

They don't seem to use any different system for this. This is just a courtesy to ensure that SNS inventories stay in an expected state.
OrdisPrime commented 2025-02-19 13:30:04 -08:00
Owner
Copy Link

They don't seem to use any different system for this. This is just a courtesy to ensure that SNS inventories stay in an expected state.

Right, sure, but we could just maintain a list on the inventory.
The original servers seem to use the wishlist for that, but we could use any name of course.

> They don't seem to use any different system for this. This is just a courtesy to ensure that SNS inventories stay in an expected state. Right, sure, but we could just maintain a list on the inventory. The original servers seem to use the wishlist for that, but we could use any name of course.
Sainan commented 2025-02-19 13:30:57 -08:00
Author
Owner
Copy Link

They don't use the wishlist for crewships at least.

They don't use the wishlist for crewships at least.
Sainan commented 2025-02-19 13:31:19 -08:00
Author
Owner
Copy Link

Actually, I'm not sure they use the wishlist like you describe at all.

Actually, I'm not sure they use the wishlist like you describe at all.
OrdisPrime commented 2025-02-19 13:32:31 -08:00
Owner
Copy Link

Actually, I'm not sure they use the wishlist like you describe at all.

it was just my guess for what the wishlist's function is.
But for some items they report a WishlistChange.
And since for example ship features are not wishlistable, the only reasonable explanation for me was that it is the games way to track unique items.

> Actually, I'm not sure they use the wishlist like you describe at all. it was just my guess for what the wishlist's function is. But for some items they report a WishlistChange. And since for example ship features are not wishlistable, the only reasonable explanation for me was that it is the games way to track unique items.
Sainan merged commit 6acb0f5dca into main 2025-02-19 13:42:37 -08:00
Sainan deleted branch singletons 2025-02-19 13:42:37 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#969
No description provided.
Delete Branch "singletons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?