fix: Unable to save settings when accepting trade policy. #966

CyberVenom · 2025-02-19T11:36:33-08:00

CyberVenom commented

2025-02-19 11:36:33 -08:00

![image.png](/attachments/b9954b5f-5ece-4803-b728-548ca2320fdf)

image.png

314 KiB

CyberVenom added 1 commit 2025-02-19 11:36:33 -08:00

fix: Unable to save settings when accepting trade policy.

Build / build (22) (pull_request) Successful in 56s

Details

Build / build (20) (pull_request) Successful in 1m13s

Details

Build / build (18) (pull_request) Successful in 36s

Details

6c6403f460

OrdisPrime reviewed 2025-02-19 11:56:03 -08:00

src/controllers/api/saveSettingsController.ts Outdated

						
				@ -0,0 +14,4 @@

				    const trainingResults = getJSONfromString<ISaveSettingsRequest>(String(req.body));

				    const inventory = await getInventory(accountId);

				    inventory.Settings = trainingResults.Settings;

OrdisPrime commented

2025-02-19 11:56:03 -08:00

training results?

CyberVenom commented

2025-02-19 12:03:58 -08:00

The client wil send the full settings object like so
{"Settings":{"GiftMode":"GIFT_MODE_ALL","FriendInvRestriction":"GIFT_MODE_ALL","GuildInvRestriction":"GIFT_MODE_ALL","ShowFriendInvNotifications":true,"TradingRulesConfirmed":true,"SubscribedToSurveys":true}}

The client wil send the full settings object like so {"Settings":{"GiftMode":"GIFT_MODE_ALL","FriendInvRestriction":"GIFT_MODE_ALL","GuildInvRestriction":"GIFT_MODE_ALL","ShowFriendInvNotifications":true,"TradingRulesConfirmed":true,"SubscribedToSurveys":true}}

OrdisPrime commented

2025-02-19 12:49:57 -08:00

yea that all makes sense, I was just wondering why its called training results :D

OrdisPrime commented

2025-02-19 12:51:52 -08:00

Also I was wondering if you know whether these settings are meant to be overwritten in full or whether this situation can exist:
inventory.Settings: { setting1: "something"}
server sends: Settings: { setting2: "something2", setting3: "something3"}

because in that case the old settings would get lost. Just wanna make sure we checked for that

Also I was wondering if you know whether these settings are meant to be overwritten in full or whether this situation can exist: inventory.Settings: { setting1: "something"} server sends: Settings: { setting2: "something2", setting3: "something3"} because in that case the old settings would get lost. Just wanna make sure we checked for that

CyberVenom commented

2025-02-19 13:06:23 -08:00

I just forgot to edit the name when i copyt the file.

I was thinking that too but i havet found anything eles to trigger that endpoint

I just forgot to edit the name when i copyt the file. I was thinking that too but i havet found anything eles to trigger that endpoint

OrdisPrime commented

2025-02-19 13:28:27 -08:00

I just forgot to edit the name when i copyt the file.

I was thinking that too but i havet found anything eles to trigger that endpoint

Okey, right.
You could just use Object.Assign(old, new). This way old settings will be overwritten and new added.

> I just forgot to edit the name when i copyt the file. > > > I was thinking that too but i havet found anything eles to trigger that endpoint Okey, right. You could just use Object.Assign(old, new). This way old settings will be overwritten and new added.

CyberVenom commented

2025-02-19 14:05:53 -08:00

It wil use Object.Assign now :)