fix: add missing quest keys at updateQuestKey #958

Merged

Sainan merged 2 commits from questfix into main 2025-02-18 13:48:21 -08:00

Conversation 3 Commits 2 Files Changed 1 +4 -3

Sainan commented 2025-02-17 15:44:03 -08:00

Owner

Copy Link

it's possible the quest key was not in already in the inventory but the quest was still available due to unlockAllQuests

Closes #957

it's possible the quest key was not in already in the inventory but the quest was still available due to unlockAllQuests Closes #957

Sainan added 1 commit 2025-02-17 15:44:04 -08:00

fix: add missing quest keys at updateQuestKey ... 0b29d33652

it's possible the quest key was not in already in the inventory but the quest was still available due to unlockAllQuests

OrdisPrime commented 2025-02-18 05:29:28 -08:00

Owner

Copy Link

handling the case where a quest key should be present due to some config, should not change core logic of the server.
The core logic ensures there are no critical bugs in the system and the assumptions are correct, which ensures that the system works properly.

Change the way the config works, or remove the config entry entirely and add a webui option that actually adds the keys to the inventory

handling the case where a quest key should be present due to some config, should not change core logic of the server. The core logic ensures there are no critical bugs in the system and the assumptions are correct, which ensures that the system works properly. Change the way the config works, or remove the config entry entirely and add a webui option that actually adds the keys to the inventory

OrdisPrime changed title from fix: add missing quest keys at updateQuestKey to WIP: fix: add missing quest keys at updateQuestKey 2025-02-18 05:29:39 -08:00

Sainan added 1 commit 2025-02-18 11:09:36 -08:00

error when quest key is missing & unlockAllQuests is false cbc1d2942a

Sainan commented 2025-02-18 11:10:10 -08:00

Author

Owner

Copy Link

The config is also part of the server's logic and should be respected. Please take a look at my new change.

The config is also part of the server's logic and should be respected. Please take a look at my new change.

Sainan changed title from WIP: fix: add missing quest keys at updateQuestKey to fix: add missing quest keys at updateQuestKey 2025-02-18 11:10:29 -08:00

OrdisPrime commented 2025-02-18 13:42:36 -08:00

Owner

Copy Link

Your current change would be good.
I made a more permanent solution, see if you like it, its the unlock quests branch.

Your current change would be good. I made a more permanent solution, see if you like it, its the unlock quests branch.

Sainan merged commit 87cc2594c8 into main 2025-02-18 13:48:21 -08:00

Sainan deleted branch questfix 2025-02-18 13:48:22 -08:00

Sainan referenced this issue from a commit 2025-02-18 13:48:23 -08:00

fix: add missing quest keys at updateQuestKey (#958)

OrdisPrime referenced this issue from a commit 2025-02-18 16:33:49 -08:00

revert 87cc2594c81eda976afcb3e0e42ba458d144a522

neon referenced this issue from a commit 2025-02-20 02:35:28 -08:00

fix: add missing quest keys at updateQuestKey (#958)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

An existing implemention is incorrect

dependencies

Pull requests that update a dependency file

documentation

Improvements or additions to documentation

enhancement

New feature or request specific to the emulator

help wanted

Extra attention is needed

improvement

missing data

part of more major rehaul

Can't be worked on right now without merge conflicts later

pr'd for

Soon™

question

Further information is requested

unimplemented

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#958

No description provided.