OpenWF/SpaceNinjaServer
21
23
Fork 30
Code Issues 23 Pull Requests 6 Actions Packages Projects Releases Activity

feat: obtaining crewship related items on mission update #897

Merged
OrdisPrime merged 3 commits from AMelonInsideLemon/SpaceNinjaServer:crewship-rewards into main 2025-02-05 12:23:35 -08:00
Conversation 4 Commits 3 Files Changed 4 -2
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5b525916d0 - Show all commits

2
src/services/inventoryService.ts
View File

@ -926,7 +926,6 @@ export const addCrewShipRawSalvage = (
if (itemIndex !== -1) {
CrewShipRawSalvage[itemIndex].ItemCount += ItemCount;
inventory.markModified(`CrewShipRawSalvage.${itemIndex}.ItemCount`);
} else {
Sainan marked this conversation as resolved
Sainan commented 2025-02-05 09:50:39 -08:00
Review
Copy Link

markModified shouldn't be needed with a proper schema.

`markModified` shouldn't be needed with a proper schema.
CrewShipRawSalvage.push({ ItemCount, ItemType });
}
@ -941,7 +940,6 @@ export const addCrewShipAmmo = (inventory: TInventoryDatabaseDocument, itemsArra
if (itemIndex !== -1) {
CrewShipAmmo[itemIndex].ItemCount += ItemCount;
inventory.markModified(`CrewShipAmmo.${itemIndex}.ItemCount`);
} else {
CrewShipAmmo.push({ ItemCount, ItemType });
}