OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat: obtaining crewship related items on mission update #897

Merged
OrdisPrime merged 3 commits from AMelonInsideLemon/SpaceNinjaServer:crewship-rewards into main 2025-02-05 12:23:35 -08:00
Conversation 4 Commits 3 Files Changed 4 +52 -8
AMelonInsideLemon commented 2025-02-04 11:39:11 -08:00
Contributor
Copy Link
No description provided.
AMelonInsideLemon added 1 commit 2025-02-04 11:39:12 -08:00
feat: obtaining crewship related items
All checks were successful
Build / build (18) (pull_request) Successful in 36s
Details
Build / build (22) (pull_request) Successful in 31s
Details
Build / build (20) (pull_request) Successful in 1m49s
Details
c678cac49d
Sainan approved these changes 2025-02-04 11:40:36 -08:00
OrdisPrime was assigned by Sainan 2025-02-04 11:54:00 -08:00
OrdisPrime reviewed 2025-02-05 06:05:54 -08:00
src/services/missionInventoryUpdateService.ts Outdated
@ -291,2 +297,3 @@
function getRandomMissionDrops(RewardInfo: IRewardInfo | undefined): IRngResult[] {
const drops: IRngResult[] = [];
if (RewardInfo.node in ExportRegions) {
if (RewardInfo && RewardInfo.node in ExportRegions) {
OrdisPrime commented 2025-02-05 06:05:54 -08:00
Owner
Copy Link

why was the return upon no rewardInfo removed and this check here added?
could you explain the logic behind it? In my testing I did not see game scenarios where random mission rewards would need to be applied when rewardInfo is missing. Could you name me the scenario?

why was the return upon no rewardInfo removed and this check here added? could you explain the logic behind it? In my testing I did not see game scenarios where random mission rewards would need to be applied when rewardInfo is missing. Could you name me the scenario?
OrdisPrime commented 2025-02-05 06:06:53 -08:00
Owner
Copy Link

Allowing undefined here and proceeding with the function upon undefined rewardInfo removes a lot of the control and leaves a possibility for hard to trace bugs I would think

Allowing undefined here and proceeding with the function upon undefined rewardInfo removes a lot of the control and leaves a possibility for hard to trace bugs I would think
AMelonInsideLemon added 1 commit 2025-02-05 08:17:42 -08:00
add BonusMiscItems
All checks were successful
Build / build (22) (pull_request) Successful in 33s
Details
Build / build (18) (pull_request) Successful in 56s
Details
Build / build (20) (pull_request) Successful in 1m16s
Details
604c87637e
Sainan commented 2025-02-05 08:30:44 -08:00
Owner
Copy Link

If you're also adding BonusMiscItems now to this 'crewship related items' PR, then I guess this also closes #421.

If you're also adding BonusMiscItems now to this 'crewship related items' PR, then I guess this also closes #421.
Sainan reviewed 2025-02-05 09:50:39 -08:00
src/services/inventoryService.ts
@ -918,0 +926,4 @@
if (itemIndex !== -1) {
CrewShipRawSalvage[itemIndex].ItemCount += ItemCount;
inventory.markModified(`CrewShipRawSalvage.${itemIndex}.ItemCount`);
Sainan commented 2025-02-05 09:50:39 -08:00
Owner
Copy Link

markModified shouldn't be needed with a proper schema.

`markModified` shouldn't be needed with a proper schema.
Sainan marked this conversation as resolved
AMelonInsideLemon added 1 commit 2025-02-05 09:53:50 -08:00
remove markModified
All checks were successful
Build / build (20) (pull_request) Successful in 33s
Details
Build / build (22) (pull_request) Successful in 52s
Details
Build / build (18) (pull_request) Successful in 1m9s
Details
5b525916d0
OrdisPrime changed title from feat: obtaining crewship related items to feat: obtaining crewship related items on mission update 2025-02-05 12:23:24 -08:00
OrdisPrime merged commit 1c82b90033 into main 2025-02-05 12:23:35 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees OrdisPrime
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#897
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:crewship-rewards"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?