OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

chore: update nightwave to nora's mix vol. 7 #784

Merged
nrbdev merged 2 commits from nightwave-7 into main 2025-01-15 07:23:58 -08:00
Conversation 5 Commits 2 Files Changed 4 +571 -86
nrbdev commented 2025-01-15 07:01:03 -08:00 (Migrated from github.com)
Copy Link

Changed worldState to use nora's mix volume 7

Changed worldState to use nora's mix volume 7
coderabbitai[bot] commented 2025-01-15 07:01:14 -08:00 (Migrated from github.com)
Copy Link

Walkthrough

The pull request introduces updates related to the Radio Legion Intermission event, specifically transitioning from version 10 to version 11. The changes span multiple files, including a service file for vendor manifests, a vendor manifest JSON, and a world state configuration.

The modifications involve updating import statements in the server-side vendors service, replacing the vendor manifest reference from version 10 to version 11. The vendor manifest JSON has been updated with a new type name and currency references, along with the addition of a new VendorInfo object and an ItemManifest array populated with items. Additionally, the world state JSON has been modified to include a new syndicate mission entry for the Radio Legion Intermission 11 event, with corresponding updates to the season information, including changing the affiliation tag and incrementing the season number.

These changes are part of a systematic update to prepare for a new iteration of the Radio Legion Intermission event in the game's ecosystem.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- walkthrough_start --> ## Walkthrough The pull request introduces updates related to the Radio Legion Intermission event, specifically transitioning from version 10 to version 11. The changes span multiple files, including a service file for vendor manifests, a vendor manifest JSON, and a world state configuration. The modifications involve updating import statements in the server-side vendors service, replacing the vendor manifest reference from version 10 to version 11. The vendor manifest JSON has been updated with a new type name and currency references, along with the addition of a new `VendorInfo` object and an `ItemManifest` array populated with items. Additionally, the world state JSON has been modified to include a new syndicate mission entry for the Radio Legion Intermission 11 event, with corresponding updates to the season information, including changing the affiliation tag and incrementing the season number. These changes are part of a systematic update to prepare for a new iteration of the Radio Legion Intermission event in the game's ecosystem. <!-- walkthrough_end --> <!-- internal state start --> <!-- FAHghAtBAEAqAWBLAztF0CGA7TBXALgPYQDmAplmQE4b5kAm0AxoQLasX4Bc0ADldEIAjAFZkm+RADcyqIQE9mhetQxChifADoMiaFAB8wY+CjGAxOegAFAErQAyrnYYq84wjJ9cAGx/QqMgBHXFl8aEl8HwZoACImeEJAnlxeelovLEQSeHwAdwwZCMJoLCSMAHJUVkQAD2gpQh8taAB2WOgC1GRcIRr8OkYFCPgvXGRqUqohFSlMLEZ0RBUsSQAzRBjh/FHS5yFJ1oAOABYWzz4qRFZXRQTscjRVqmVcJhjEHB30OzRUHa8rGUiA2TFoiEIOEIaxGXjySR89Ac+AyxWgBEQPkQAC8vAA5cpVaAAWTq0AAak1nF5WuddipkEwrrxJJDLoQpMsPgtEGC6P94LQRuhUuk6E9Gj4ZKgMNBkPgaNlcmskgUqIwMPQRON8BxVmiAdAyLUUJIsCQlCohBgJgAaOW8cQg3kYPyKFFUchmi2Gz50Eg0VlQmGGyh5BpUjgtABiSWga1wVABAhUKMxyHtht4vn8gRCYWY2GgB0wTHeyAmGvChpVfkIeU+FoAqrYADI8ADauXwvGQXAA9P2SJp4L0tCxWP3kLwMO8slgRDbqDIqP2HDP3njPouHMvqP3s35+8cTgBdAAU3d7A6HI7HE6nG4o26XVBXa6fW4XGF3b/3h58Y9TgASi0CwrAAYTYPV8FQJwXDcYwAEkvl2CcYO6cQg0EENdgAgJglCeV7QmFdXSeOgaAkCEsH+QhCAAaz4HxZzIOkxgmAQsGmWZSkIQYRiFQ0yFYXxwTZc8RNwYDMF4R1XGqJIxl4NExThEdYWYRNAn1AB1Vw1hoDhoHPPI1hklhVk4Ol0HQzg5VwEhyHlGU+EIZBNGkLxhE4qRxJwQISFcehG00wJoj8rB3hwzTRQyMDgAcXQsCLQJp0hFRGCIKYZjIKQiTs/VhmNfhZA880lCi6hUKE3YZAWOMbiyNYCy6Pjwn4QhHSoHxFDiwZ7WuXhetCnZaq8e5zVkaAbhUGalXCMpwkCNZogkTSWP5cIVw8tloU0+r6Ea7AQQLbBFlouhNU6ahAWBUF/NQfbDSaRhITYuAkFQT4Qr5abZV4fjOEQciOWoDycnCT4jVoxNRsFatdiBeUtKoHTwjFWU2oxLFcQu2K0ni5CAtkQHaK8bKks+bB7W43K5lnBiyjyaJ6HILK0Mhd4qCwEiUW9QTEbIRQDixPKYhexEGgoI6BCa06UfhXxGCW4tMnEMrbjlT5osNeUlIIm5PgFLxkAwKNPvQY1JseJAcixSHXJCxlxl2nA1EIAhNMocsPPwRR9qN1ZktC1IICICA1OgI6mGpYPsPO6PaCxkdocNFgrSXe0ZyTXkxJ6xRofC/y0UO47mrCZAEoAeTIvxM059hOFQFa1vCWUWD8D3Ay8o01hVJM0QoHpAk02dY6oxRE/CvLsGi560MFKbqk1Lw07wnMCPzYjOg0uneJUFqeQqgFEAEDA5JeWd4E6JBokwHxkBKCgguHCqGx2eMyAYa0mCYwy2CCGTJVBUiAhAECSFXYwhgTCQBgDLGKGAIGkAoKoAShVuCXEEKILCXk5B3GUKodQmgdB6BgaYGACAlgyndsg8glBAwxAwTwGg4YegIRFgQlQNBiHaF0PoCARhYFmGAMgKgTApzLl5LISRf4qAeRUOSGWkDfycneFoWCXBgCxB0cASw0AACCSEUEMIyIwdhNw3AxRtrIDw9IQQwmQIkPIrkgQhQethdea9WCA0HvKDIGF5gcy8AAAzLlQYkJ0WouRCZgNGGB5AtHXE6B6boG7eN8eEAe0AQm2E1BCVsZBhyQhQpRGoFYaIAEYAAMSiGoRKiWEWJgo5DfxJkCGQGoFgEWGqxRgH8b65PyYQQpxSsClOoOUt2lTKl1NlpEiu8oQk2VQDYzA/csImxyeEhZCtYKxNcDQeQ9o8ijFHoaFat0qpoiGSFEZRSaITKoFMqptTlENMWfgWJ6AVDRAEtPMgvT3j9I0rcgpDySlWWeSgaZsz3m7OiV89igg67+HlFQN4+BExeETj4Qgw4mAxUNCEpCcykgIqaRRagaxWJBM0gmKKQZUAhK9GSj5eyABC8hYDyEdHic2ZADndJZWQfAbKKXyi5dXZYsTAhB3RFFJe7NBo8j5PDca8ZcCMpoq6TQihi4CWyuEmajSXJ/EuLIPc/S77KTFPDU2jomDOkJca+WiK1ahSGkkQYCVwKGJ8JRR6Bp6TiBYj3SET0YQlW9TEOM2YhBYkJcDSQtjgAwCQj4716JCaDB4CEr1g88l3NGY8qFLzIQ1PFaarJLxWBxAAAJTn5ryfsGxagMAAPppTJhMZAQ5RVspQiqfsRbwVjKeeWrAlb4XVq0CIJ+WBYgAG5YmACTCHJBbwijvueOstMKqlwvqRKmtgDYiNv8ZICRbbO3dojTI1l7yh2EBHcMktkKyn7orYe+Zs752QmXSEtNFJ3kms+QRFqOlor9QYHm7db7xl7oqRWt5R7q3fJwGEmdnzkAHPiYoddYKd2lo/Uhqd37yVoaeNsrDeycNxKOdo3RaaREXpbde+gXbSZ3r7Q++pT6X3FohQhkjsKq2fLnQurROjYh6KsEYkxaCYgWK1vtGxyA7ETSVdNLx0AABSDhq54njJiNezxXjRVlGGaW9TQN7PjHGQ027oDwaNPVfAJFHXOtdL1ezAgdo0WgDM5FITB1YBVLE4QYh1otLVhQTA9BMr2ksmmecFoiwhI7TK4zZApaJ1lCEnlfKBWxI2DljmQppwpM2FsqzbqCz+0dJgZlsR+ytn4uMfshWZEAHEBX9jE7R/sABRNzfa4NCYnZ+sjA3EWxGWZ9UJSE6CsGPbho50AYsHDi4DQ8Zjd6f1EgGxAw017LYzEaa+0cyAbEoCCz+tBQHgP5A5BITWcnIiUktkSIT7QkuW9YK45Yfs5I5Z8YHISACKuBsCRHkMSXwkhhqbCoODobtReBn3kODgxdY8jw6O9mcRLTBX2kTiS+g83jBDcu5oESVHDR1ZRpcyD01QxkHDBPSD7peWhIJDQSbpGhsRQoBBQI9AcMnI0n5K4ntvrLaUFq2CdLOr0ExYWf0SRqsOiqwwYLaOMduBK5sKW2TDSuurXSsgNP5foAmNWEosoExYtHmpe0w84YnwRppWnrAW4iWSpgPymI1D32yYT+4EwFWSH8GNas1wPoXHRZi7FRLdj6cM+ayyHl5ScHtEHFL9q5QCt8zcLJcZvMw1AbIBK+iceBqZcGrwKgmBhqDftaNSZY0CHjYmyvnlU0wDxOzvTBmjNJ4kCnzUmU82hfC/tm+pXETMsyxT37XX+UcHB19lbaHSfCv15j9DOTWNXrqDerj5MeMDsfWF5943d0iYPTNsIEnITLOgdAIf4YfcygSxLEof2Ikq2bul2Ay2WS+72RAgQ2+W+/2gOsg4OoOWA4OUOMOeq+OiOYsKOv2B+huv2OOeKeOCOx2iYEeJOdK5O7+0m0CLGzap+7aHGt6l+/Y8IPUSI/MZALBCI7B8Uf6WAUmuitexi9Cim5izgliAcMIamGm0cDiFELwqu5YmApQw+yA8gqqqInAVi2SsQ9+xGkyU2MyDg6hv0GQHQOmsQxhGhdApIpGyAHQEw1Ee0uEXg6eRmGw0QKyleViOsPguADI4B4uvmOSK+2O1EfkQYqO6Oh+a+GAJA4Ou4DAwOZOBIDIwOYBxKoRHqFUsoWqiA+YaAKw6wyOdKxKsAcR6GphAsesJhLodARIKUFsFwISBi4R/kQqjAISuBWOgRMoo8duaIlWTqoISc4ofkfhsgJyNqmkISiRFO5qNoEMt2yhWA1IgO5E4xoQMUAAzAAKzbF77BI5KpEIH0YJLmoiQsiJLQDGAGIJaeSQjebHKaSWFW4LpPoOG4JsibZtLZpqRZQlCtxYTKFrI6YtH9yYggxBjlHxHxi1pxB6HvoGGkY1JWFVFkAdDZS6GvoTaIawpol1EYl0pFg6xyr2Rgm7g2hv57CsAHACAAJ1qVIABMaIlS2x7EkeamTw6JyhnUAYZUAWOmEwVJKU/gyW9kicvoZmih2E+0Vmah1hgIU2UCwAFwYMNAfgcoCoyeo8C8rho+hsyU30wcEgkun8bObCtRf03higwprA0QFYPmfoRSjCF02UwkJo8ooUmMJetAvqsm/q9eNEdEmkzereDe7e6OMab03evQveya1WH+X+coVpqIk68W0+Nx0A+gOSAA3nECvrEDwPmbEAACSEDLBFlxAABs1Z2xGAJwawTAux1o1ZawpwrQTJjZDZRw1S1Z1SHQAAvvaLEK0ZIBETRFWSWaWWpFOXEKWasbSdQG1uaFWbEJUq0JUrsdUgAJytC7EnCVInDbE7lDnQDDlxDdFzllmznFnzmLl0krkkBrlMnVJvnvkflvlnkXmxAwlrmInCbIn4mpl0CxAjlzFVl7EHFxAnH2GdinjnlH7EoEl/S2Fux0aOGykwghIn6tpn6MEX69pcFsHIgZDEWIikV0Cv7IHADZlAZNg5pKZvFsifADyl40RaLZkwDgkeFQk0QwmxLQaMAMkIk4kP5AWvIoVmFojYmCbiXQoomVJSWgX067CzHMUIZz6YUBb7Q4V0F4UMGcbpTMGsEUUcHkU8FUV8GAZcXvYaWCWMXCXwnMmsnbGqWhKUnvG36xLaXOHH76XsZGU9oyKmWWWcGhWUVsTWWMYybMZCIUIwxvQwhIIRwiGulKBNyrAsIYBsLiFazDAZxEIaB8JkKCKgBwIZX9Ar7ICcacjs6dr+KDwwLlVQDQAnDVJHBMlkC7GVJkC1lrBHn0DVK7HVm7Hbk7mVI7kNk7lHA7lrBMlrD0CVJMCVIYDVn7lHACJGAJXVJDXrVMDbGtBqBCDbHVJkCHVMk7kMAYBHBrDqBbk7nbHNlghCAnBMB3VMmyjNUJXoSaDVW1WbB5CdoIKGBAA --> <!-- internal state end --> <!-- tips_start --> --- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> <details> <summary>🪧 Tips</summary> ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit <commit_id>, please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR. ([Beta](https://docs.coderabbit.ai/early-access#beta)) - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. </details> <!-- tips_end -->
nrbdev commented 2025-01-15 07:03:58 -08:00 (Migrated from github.com)
Copy Link

moreso the emu looks more up to date with current wf :)

moreso the emu looks more up to date with current wf :)
Sainan commented 2025-01-15 07:11:09 -08:00
Copy Link

Fair enough, but it doesn't look like you grabbed a proper copy of the vendor manifest, instead just modifying the old one.

Fair enough, but it doesn't look like you grabbed a proper copy of the vendor manifest, instead just modifying the old one.
nrbdev commented 2025-01-15 07:11:57 -08:00 (Migrated from github.com)
Copy Link

Yeah, figured the old one wouldnt be needed. The store is the same anyways

Yeah, figured the old one wouldnt be needed. The store is the same anyways
coderabbitai[bot] (Migrated from github.com) reviewed 2025-01-15 07:24:27 -08:00
coderabbitai[bot] (Migrated from github.com) left a comment
Copy Link

Actionable comments posted: 1

🧹 Nitpick comments (2)
static/fixed_responses/getVendorInfo/RadioLegionIntermission11VendorManifest.json (2)

5-555: Consider using random ObjectIds for item entries.

The ItemManifest entries use sequentially incrementing ObjectIds which could be predictable. Consider using randomly generated ObjectIds for better security.

557-557: Consider implementing staggered expiry dates.

All items share the same far-future expiry date (2051240400000). Consider implementing staggered expiry dates to:

  • Facilitate item rotation in the store
  • Better align with seasonal content
  • Enable time-limited promotions
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4082e51e66 and 0d067c37ab.

📒 Files selected for processing (1)
  • static/fixed_responses/getVendorInfo/RadioLegionIntermission11VendorManifest.json (1 hunks)
🔇 Additional comments (2)
static/fixed_responses/getVendorInfo/RadioLegionIntermission11VendorManifest.json (2)

61-68: Verify the Kuva quantity multiplier.

The Kuva item has a QuantityMultiplier of 10000, which results in 10000 Kuva per purchase. Please confirm if this quantity is intentional.

70-78: LGTM! Proper purchase limits for unique cosmetic.

The GlassmakerShipDeco correctly implements purchase limitations with both PurchaseQuantityLimit and AllowMultipurchase flags, ensuring players can only obtain one copy of this unique cosmetic item.

**Actionable comments posted: 1** <details> <summary>🧹 Nitpick comments (2)</summary><blockquote> <details> <summary>static/fixed_responses/getVendorInfo/RadioLegionIntermission11VendorManifest.json (2)</summary><blockquote> `5-555`: **Consider using random ObjectIds for item entries.** The ItemManifest entries use sequentially incrementing ObjectIds which could be predictable. Consider using randomly generated ObjectIds for better security. --- `557-557`: **Consider implementing staggered expiry dates.** All items share the same far-future expiry date (2051240400000). Consider implementing staggered expiry dates to: - Facilitate item rotation in the store - Better align with seasonal content - Enable time-limited promotions </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: .coderabbit.yaml** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 4082e51e66f14d056550919a4989f2fd1c1a6758 and 0d067c37abb30e3729eda8fbb1593c5cab4cfb2a. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `static/fixed_responses/getVendorInfo/RadioLegionIntermission11VendorManifest.json` (1 hunks) </details> <details> <summary>🔇 Additional comments (2)</summary><blockquote> <details> <summary>static/fixed_responses/getVendorInfo/RadioLegionIntermission11VendorManifest.json (2)</summary> `61-68`: **Verify the Kuva quantity multiplier.** The Kuva item has a QuantityMultiplier of 10000, which results in 10000 Kuva per purchase. Please confirm if this quantity is intentional. --- `70-78`: **LGTM! Proper purchase limits for unique cosmetic.** The GlassmakerShipDeco correctly implements purchase limitations with both PurchaseQuantityLimit and AllowMultipurchase flags, ensuring players can only obtain one copy of this unique cosmetic item. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
static/fixed_responses/getVendorInfo/RadioLegionIntermission11VendorManifest.json
@ -0,0 +1,559 @@
{
"VendorInfo": {
"_id": { "$oid": "66d538400000000000000000" },
coderabbitai[bot] (Migrated from github.com) commented 2025-01-15 07:24:26 -08:00
Copy Link

💡 Codebase verification

The ObjectId is unique but follows a non-standard pattern

The ObjectId 66d538400000000000000000 is unique across all 28 vendor manifests. However, its pattern with trailing zeros suggests manual construction, which deviates from MongoDB's standard ObjectId generation and could lead to predictability issues.

🔗 Analysis chain

Verify the MongoDB ObjectId generation.

The _id field appears to use a manually constructed ObjectId. This could lead to conflicts if multiple instances use the same ID.

Run this script to check for potential ID conflicts:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for duplicate ObjectIds in vendor manifests
rg -l '"_id".*"66d538400000000000000000"' static/fixed_responses/getVendorInfo/

Length of output: 163

Script:

#!/bin/bash
# List all vendor manifest files and their ObjectIds
echo "=== All vendor manifest files ==="
fd . static/fixed_responses/getVendorInfo/ -e json -x echo "{}"
echo -e "\n=== All ObjectIds used ==="
rg -o '"_id".*\{.*"[$]oid".*:.*"[^"]*"' static/fixed_responses/getVendorInfo/ --no-filename | sort | uniq

Length of output: 2599

_:bulb: Codebase verification_ **The ObjectId is unique but follows a non-standard pattern** The ObjectId `66d538400000000000000000` is unique across all 28 vendor manifests. However, its pattern with trailing zeros suggests manual construction, which deviates from MongoDB's standard ObjectId generation and could lead to predictability issues. <details> <summary>🔗 Analysis chain</summary> **Verify the MongoDB ObjectId generation.** The _id field appears to use a manually constructed ObjectId. This could lead to conflicts if multiple instances use the same ID. Run this script to check for potential ID conflicts: </details> <details> <summary>🏁 Scripts executed</summary> The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Search for duplicate ObjectIds in vendor manifests rg -l '"_id".*"66d538400000000000000000"' static/fixed_responses/getVendorInfo/ ``` Length of output: 163 --- Script: ```shell #!/bin/bash # List all vendor manifest files and their ObjectIds echo "=== All vendor manifest files ===" fd . static/fixed_responses/getVendorInfo/ -e json -x echo "{}" echo -e "\n=== All ObjectIds used ===" rg -o '"_id".*\{.*"[$]oid".*:.*"[^"]*"' static/fixed_responses/getVendorInfo/ --no-filename | sort | uniq ``` Length of output: 2599 </details> <!-- This is an auto-generated comment by CodeRabbit -->
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#784
No description provided.
Delete Branch "nightwave-7"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?