added nora night vendor data (#742) #754

Sainan · 2025-01-08T10:29:16-08:00

nrbdev commented

2025-01-08 10:29:16 -08:00

(Migrated from github.com)

fixes #742

added static shop for nora's nightwave offerings

fixes #742 added static shop for nora's nightwave offerings

coderabbitai[bot] commented

2025-01-08 10:29:23 -08:00

(Migrated from github.com)

Warning

Rate limit exceeded

@nrbdev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 16 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4f33f163dc and 673bef35d5.

📒 Files selected for processing (2)

src/services/serversideVendorsService.ts (2 hunks)

static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json (1 hunks)

Walkthrough

The pull request modifies the serversideVendorsService.ts file by updating the vendorManifests array. Specifically, a new vendor manifest RadioLegionIntermission10VendorManifest is imported and added to the array, while simultaneously removing the ZarimanCommisionsManifestArchimedean entry. The change involves importing the new manifest from a JSON file and adjusting the array of vendor manifests accordingly. The core service logic for retrieving vendor manifests remains unchanged, with only the manifest list being updated.

Assessment against linked issues

Objective	Addressed	Explanation
Add missing server-side vendor manifest for Radio Legion Intermission 10 [#742]	✅
Resolve inability to open nightwave cred offerings [#742]	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

> [!WARNING] > ## Rate limit exceeded > > @nrbdev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait **22 minutes and 16 seconds** before requesting another review. > > <details> > <summary>⌛ How to resolve this issue?</summary> > > After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. > > We recommend that you space out your commits to avoid hitting the rate limit. > > </details> > > > <details> > <summary>🚦 How do rate limits work?</summary> > > CodeRabbit enforces hourly rate limits for each developer per organization. > > Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. > > Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information. > > </details> > > <details> > <summary>📥 Commits</summary> > > Reviewing files that changed from the base of the PR and between 4f33f163dc481256c2f098d0da9ac02ae70770ed and 673bef35d57d0038e98ebf3cd23fe201e9fe6975. > > </details> > > <details> > <summary>📒 Files selected for processing (2)</summary> > > * `src/services/serversideVendorsService.ts` (2 hunks) > * `static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json` (1 hunks) > > </details>   ## Walkthrough The pull request modifies the `serversideVendorsService.ts` file by updating the `vendorManifests` array. Specifically, a new vendor manifest `RadioLegionIntermission10VendorManifest` is imported and added to the array, while simultaneously removing the `ZarimanCommisionsManifestArchimedean` entry. The change involves importing the new manifest from a JSON file and adjusting the array of vendor manifests accordingly. The core service logic for retrieving vendor manifests remains unchanged, with only the manifest list being updated. ## Assessment against linked issues | Objective | Addressed | Explanation | |-----------|-----------|-------------| | Add missing server-side vendor manifest for Radio Legion Intermission 10 [#742] | ✅ | | | Resolve inability to open nightwave cred offerings [#742] | ✅ | |      --- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> <details> <summary>🪧 Tips</summary> ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit <commit_id>, please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR. ([Beta](https://docs.coderabbit.ai/early-access#beta)) - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. </details>

coderabbitai[bot] (Migrated from github.com) reviewed 2025-01-08 10:30:36 -08:00

coderabbitai[bot] (Migrated from github.com) left a comment

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/services/serversideVendorsService.ts (1)

Line range hint 75-91: Consider optimizing vendor manifest lookups.

As the number of vendor manifests grows, the current sequential search implementation (O(n)) might impact performance. Consider using a Map-based lookup for better efficiency:

// Create maps for O(1) lookups
const vendorManifestsByType = new Map<string, IVendorManifest>();
const vendorManifestsByOid = new Map<string, IVendorManifest>();

// Initialize maps once
vendorManifests.forEach(manifest => {
    vendorManifestsByType.set(manifest.VendorInfo.TypeName, manifest);
    vendorManifestsByOid.set(manifest.VendorInfo._id.$oid, manifest);
});

export const getVendorManifestByTypeName = (typeName: string): IVendorManifest | undefined => {
    return vendorManifestsByType.get(typeName);
};

export const getVendorManifestByOid = (oid: string): IVendorManifest | undefined => {
    return vendorManifestsByOid.get(oid);
};

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4476d7136 and 4f33f163dc.

📒 Files selected for processing (1)

src/services/serversideVendorsService.ts (2 hunks)

🧰 Additional context used

🪛 GitHub Check: build (22)

src/services/serversideVendorsService.ts

[failure] 30-30:
Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations.

🪛 GitHub Check: build (20)

src/services/serversideVendorsService.ts

[failure] 30-30:
Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations.

🪛 GitHub Check: build (18)

src/services/serversideVendorsService.ts

[failure] 30-30:
Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations.

🪛 GitHub Actions: Build

src/services/serversideVendorsService.ts

[error] 30-30: Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations.

**Actionable comments posted: 1** <details> <summary>🧹 Nitpick comments (1)</summary><blockquote> <details> <summary>src/services/serversideVendorsService.ts (1)</summary><blockquote> Line range hint `75-91`: **Consider optimizing vendor manifest lookups.** As the number of vendor manifests grows, the current sequential search implementation (O(n)) might impact performance. Consider using a Map-based lookup for better efficiency: ```typescript // Create maps for O(1) lookups const vendorManifestsByType = new Map<string, IVendorManifest>(); const vendorManifestsByOid = new Map<string, IVendorManifest>(); // Initialize maps once vendorManifests.forEach(manifest => { vendorManifestsByType.set(manifest.VendorInfo.TypeName, manifest); vendorManifestsByOid.set(manifest.VendorInfo._id.$oid, manifest); }); export const getVendorManifestByTypeName = (typeName: string): IVendorManifest | undefined => { return vendorManifestsByType.get(typeName); }; export const getVendorManifestByOid = (oid: string): IVendorManifest | undefined => { return vendorManifestsByOid.get(oid); }; ``` </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: .coderabbit.yaml** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between e4476d713602efe22c63666d1f8b7a040d849f25 and 4f33f163dc481256c2f098d0da9ac02ae70770ed. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `src/services/serversideVendorsService.ts` (2 hunks) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🪛 GitHub Check: build (22)</summary> <details> <summary>src/services/serversideVendorsService.ts</summary> [failure] 30-30: Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations. </details> </details> <details> <summary>🪛 GitHub Check: build (20)</summary> <details> <summary>src/services/serversideVendorsService.ts</summary> [failure] 30-30: Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations. </details> </details> <details> <summary>🪛 GitHub Check: build (18)</summary> <details> <summary>src/services/serversideVendorsService.ts</summary> [failure] 30-30: Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations. </details> </details> <details> <summary>🪛 GitHub Actions: Build</summary> <details> <summary>src/services/serversideVendorsService.ts</summary> [error] 30-30: Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations. </details> </details> </details> </details>

src/services/serversideVendorsService.ts

						
				@ -23,3 +23,4 @@

				import OstronProspectorVendorManifest from "@/static/fixed_responses/getVendorInfo/OstronProspectorVendorManifest.json";

				import RadioLegionIntermission10VendorManifest from "@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json";

				import SolarisDebtTokenVendorManifest from "@/static/fixed_responses/getVendorInfo/SolarisDebtTokenVendorManifest.json";

				import SolarisDebtTokenVendorRepossessionsManifest from "@/static/fixed_responses/getVendorInfo/SolarisDebtTokenVendorRepossessionsManifest.json";

coderabbitai[bot] (Migrated from github.com) commented

2025-01-08 10:30:36 -08:00

⚠️ Potential issue

Add the missing vendor manifest JSON file.

The build is failing because the JSON file for RadioLegionIntermission10VendorManifest is missing. Please ensure you create and commit the JSON file at the specified path:

@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json

Would you like me to help generate a template for the vendor manifest JSON file based on the existing manifest structure?

🧰 Tools

🪛 GitHub Check: build (22)

[failure] 30-30:
Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations.

🪛 GitHub Check: build (20)

[failure] 30-30:
Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations.

🪛 GitHub Check: build (18)

[failure] 30-30:
Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations.

🪛 GitHub Actions: Build

[error] 30-30: Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations.

_:warning: Potential issue_ **Add the missing vendor manifest JSON file.** The build is failing because the JSON file for `RadioLegionIntermission10VendorManifest` is missing. Please ensure you create and commit the JSON file at the specified path: ``` @/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json ``` Would you like me to help generate a template for the vendor manifest JSON file based on the existing manifest structure? <details> <summary>🧰 Tools</summary> <details> <summary>🪛 GitHub Check: build (22)</summary> [failure] 30-30: Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations. </details> <details> <summary>🪛 GitHub Check: build (20)</summary> [failure] 30-30: Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations. </details> <details> <summary>🪛 GitHub Check: build (18)</summary> [failure] 30-30: Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations. </details> <details> <summary>🪛 GitHub Actions: Build</summary> [error] 30-30: Cannot find module '@/static/fixed_responses/getVendorInfo/RadioLegionIntermission10VendorManifest.json' or its corresponding type declarations. </details> </details>

Sainan commented

2025-01-08 10:31:26 -08:00

Please keep it alphabetical.

nrbdev commented

2025-01-08 10:33:33 -08:00

(Migrated from github.com)

there

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#754