feat: dynamically cycle ESO, holdfast bounties, hex bounties, & circuit choices #643
@ -1,16 +1,112 @@
|
|||||||
|
|
|||||||
import { RequestHandler } from "express";
|
import { RequestHandler } from "express";
|
||||||
import worldState from "@/static/fixed_responses/worldState.json";
|
import staticWorldState from "@/static/fixed_responses/worldState.json";
|
||||||
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
import buildConfig from "@/static/data/buildConfig.json";
|
import buildConfig from "@/static/data/buildConfig.json";
|
||||||
|
import { IMongoDate, IOid } from "@/src/types/commonTypes";
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
|
||||||
const worldStateController: RequestHandler = (req, res) => {
|
export const worldStateController: RequestHandler = (req, res) => {
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
const buildLabel: string =
|
const worldState: IWorldState = {
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
typeof req.query.buildLabel == "string" ? req.query.buildLabel.split(" ").join("+") : buildConfig.buildLabel;
|
...staticWorldState,
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
BuildLabel:
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
res.json({
|
typeof req.query.buildLabel == "string"
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
...worldState,
|
? req.query.buildLabel.split(" ").join("+")
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
BuildLabel: buildLabel,
|
: buildConfig.buildLabel,
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
Time: Math.round(Date.now() / 1000)
|
Time: Math.round(Date.now() / 1000)
|
||||||
});
|
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
};
|
};
|
||||||
|
|
||||||
export { worldStateController };
|
const week = Math.trunc(new Date().getTime() / 604800000);
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
// Elite Sanctuary Onslaught cycling every week
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
worldState.NodeOverrides.push({
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
_id: { $oid: "5ad9f9bb6df82a56eabf3d44" },
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Node: "SolNode802",
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Seed: week // unfaithful
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
});
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
// Holdfast & Hex bounties cycling every 2.5 hours; unfaithful implementation
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
const bountyCycle = Math.trunc(new Date().getTime() / 9000000);
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
const bountyCycleStart = bountyCycle * 9000000;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
const bountyCycleEnd = bountyCycleStart + 9000000;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
worldState.SyndicateMissions.push({
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
_id: { $oid: bountyCycleStart.toString(16) + "0000000000000029" },
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Activation: { $date: { $numberLong: bountyCycleStart.toString() } },
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Improve week calculation precision and document implementation details A few concerns about this implementation:
Consider these improvements: Also, please document why this implementation is considered "unfaithful" to help future maintainers understand the limitations or differences from the original system.
_:hammer_and_wrench: Refactor suggestion_
**Improve week calculation precision and document implementation details**
A few concerns about this implementation:
1. The week calculation doesn't account for timezone differences
2. The "unfaithful" comment needs clarification
3. The hardcoded OID should be externalized
Consider these improvements:
```diff
+const ESO_NODE_ID = "5ad9f9bb6df82a56eabf3d44";
+const ESO_NODE = "SolNode802";
+
+// Calculate week number using UTC to ensure consistent cycling globally
-const week = Math.trunc(new Date().getTime() / 604800000);
+const week = Math.floor(Date.UTC() / (7 * 24 * 60 * 60 * 1000));
// Elite Sanctuary Onslaught cycling every week
worldState.NodeOverrides.push({
- _id: { $oid: "5ad9f9bb6df82a56eabf3d44" },
- Node: "SolNode802",
+ _id: { $oid: ESO_NODE_ID },
+ Node: ESO_NODE,
Seed: week // unfaithful
});
```
Also, please document why this implementation is considered "unfaithful" to help future maintainers understand the limitations or differences from the original system.
> Committable suggestion skipped: line range outside the PR's diff.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Expiry: { $date: { $numberLong: bountyCycleEnd.toString() } },
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Tag: "ZarimanSyndicate",
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Seed: bountyCycle,
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Nodes: []
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
});
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
worldState.SyndicateMissions.push({
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
_id: { $oid: bountyCycleStart.toString(16) + "0000000000000006" },
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Activation: { $date: { $numberLong: bountyCycleStart.toString(10) } },
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Expiry: { $date: { $numberLong: bountyCycleEnd.toString(10) } },
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Tag: "HexSyndicate",
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Seed: bountyCycle,
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Nodes: []
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
});
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
// Circuit choices cycling every week
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
worldState.EndlessXpChoices.push({
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Category: "EXC_NORMAL",
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Choices: [
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Nidus", "Octavia", "Harrow"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Gara", "Khora", "Revenant"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Garuda", "Baruuk", "Hildryn"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Refactor bounty cycling to reduce duplication and improve precision The current implementation has several areas for improvement:
Consider this refactored approach: 📝 Committable suggestion
_:hammer_and_wrench: Refactor suggestion_
**Refactor bounty cycling to reduce duplication and improve precision**
The current implementation has several areas for improvement:
1. Code duplication in bounty mission creation
2. Magic numbers in cycle calculations
3. Timestamp conversion inconsistency (using both base 10 and 16)
Consider this refactored approach:
```diff
+const BOUNTY_CYCLE_DURATION = 2.5 * 60 * 60 * 1000; // 2.5 hours in milliseconds
+
+interface BountyConfig {
+ tag: string;
+ idSuffix: string;
+}
+
+const bountyTypes: BountyConfig[] = [
+ { tag: "ZarimanSyndicate", idSuffix: "29" },
+ { tag: "HexSyndicate", idSuffix: "06" }
+];
+
-const bountyCycle = Math.trunc(new Date().getTime() / 9000000);
-const bountyCycleStart = bountyCycle * 9000000;
-const bountyCycleEnd = bountyCycleStart + 9000000;
+const now = new Date().getTime();
+const bountyCycle = Math.floor(now / BOUNTY_CYCLE_DURATION);
+const bountyCycleStart = bountyCycle * BOUNTY_CYCLE_DURATION;
+const bountyCycleEnd = bountyCycleStart + BOUNTY_CYCLE_DURATION;
+
+bountyTypes.forEach(({ tag, idSuffix }) => {
+ worldState.SyndicateMissions.push({
+ _id: { $oid: bountyCycleStart.toString(16).padStart(24, '0').slice(0, -2) + idSuffix },
+ Activation: { $date: { $numberLong: bountyCycleStart.toString() } },
+ Expiry: { $date: { $numberLong: bountyCycleEnd.toString() } },
+ Tag: tag,
+ Seed: bountyCycle,
+ Nodes: []
+ });
+});
-worldState.SyndicateMissions.push({...}); // Remove both push operations
```
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
`````suggestion
const BOUNTY_CYCLE_DURATION = 2.5 * 60 * 60 * 1000; // 2.5 hours in milliseconds
interface BountyConfig {
tag: string;
idSuffix: string;
}
const bountyTypes: BountyConfig[] = [
{ tag: "ZarimanSyndicate", idSuffix: "29" },
{ tag: "HexSyndicate", idSuffix: "06" }
];
const now = new Date().getTime();
const bountyCycle = Math.floor(now / BOUNTY_CYCLE_DURATION);
const bountyCycleStart = bountyCycle * BOUNTY_CYCLE_DURATION;
const bountyCycleEnd = bountyCycleStart + BOUNTY_CYCLE_DURATION;
bountyTypes.forEach(({ tag, idSuffix }) => {
worldState.SyndicateMissions.push({
_id: { $oid: bountyCycleStart.toString(16).padStart(24, '0').slice(0, -2) + idSuffix },
Activation: { $date: { $numberLong: bountyCycleStart.toString() } },
Expiry: { $date: { $numberLong: bountyCycleEnd.toString() } },
Tag: tag,
Seed: bountyCycle,
Nodes: []
});
});
`````
</details>
<!-- suggestion_end -->
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Excalibur", "Trinity", "Ember"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Loki", "Mag", "Rhino"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Ash", "Frost", "Nyx"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Saryn", "Vauban", "Nova"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Nekros", "Valkyr", "Oberon"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Hydroid", "Mirage", "Limbo"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Mesa", "Chroma", "Atlas"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Ivara", "Inaros", "Titania"]
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
][week % 12]
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
});
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
worldState.EndlessXpChoices.push({
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Category: "EXC_HARD",
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Choices: [
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Brunt", "Soma", "Vasto", "Solo", "Burston"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Zylok", "Sibear", "Dread", "Despair", "Hate"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Dera", "Sybaris", "Cestra", "Sicarus", "Okina"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Braton", "Lato", "Skana", "Paris", "Kunai"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Boar", "Gammacor", "Angstrum", "Gorgon", "Anku"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Bo", "Latron", "Furis", "Furax", "Strun"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Lex", "Magistar", "Boltor", "Bronco", "Dagger"],
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
["Torid", "Toxocyst", "Ichor", "Miter", "Atomos"]
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
][week % 8]
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
});
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
res.json(worldState);
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
};
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
interface IWorldState {
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
BuildLabel: string;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Time: number;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
SyndicateMissions: ISyndicateMission[];
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
NodeOverrides: INodeOverride[];
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
EndlessXpChoices: IEndlessXpChoice[];
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
}
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
interface ISyndicateMission {
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
_id: IOid;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Activation: IMongoDate;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Expiry: IMongoDate;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Tag: string;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Seed: number;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Nodes: string[];
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
}
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
interface INodeOverride {
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
_id: IOid;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Activation?: IMongoDate;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Expiry?: IMongoDate;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Node: string;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Hide?: boolean;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Seed?: number;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
LevelOverride?: string;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Faction?: string;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
CustomNpcEncounters?: string;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
}
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
interface IEndlessXpChoice {
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Category: string;
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
Choices: string[];
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
}
|
||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
|
|||||||
|
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
🛠️ Refactor suggestion Externalize or document large choice arrays The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. _:hammer_and_wrench: Refactor suggestion_
**Externalize or document large choice arrays**
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
<!-- This is an auto-generated comment by CodeRabbit -->
|
|||||||
@ -479,22 +479,6 @@
|
|||||||
"xpAmounts": [780, 780, 780, 780, 1540]
|
"xpAmounts": [780, 780, 780, 780, 1540]
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
},
|
|
||||||
{
|
|
||||||
"_id": { "$oid": "663a71c80000000000000029" },
|
|
||||||
"Activation": { "$date": { "$numberLong": "1715106248403" } },
|
|
||||||
"Expiry": { "$date": { "$numberLong": "2000000000000" } },
|
|
||||||
"Tag": "ZarimanSyndicate",
|
|
||||||
"Seed": 99562,
|
|
||||||
"Nodes": []
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"_id": { "$oid": "676b8d340000000000000006" },
|
|
||||||
"Activation": { "$date": { "$numberLong": "1735101748215" } },
|
|
||||||
"Expiry": { "$date": { "$numberLong": "2000000000000" } },
|
|
||||||
"Tag": "HexSyndicate",
|
|
||||||
"Seed": 33872,
|
|
||||||
"Nodes": []
|
|
||||||
}
|
}
|
||||||
],
|
],
|
||||||
"ActiveMissions": [
|
"ActiveMissions": [
|
||||||
@ -690,7 +674,6 @@
|
|||||||
{ "_id": { "$oid": "549b18e9b029cef5991d6aec" }, "Node": "EuropaHUB", "Hide": true },
|
{ "_id": { "$oid": "549b18e9b029cef5991d6aec" }, "Node": "EuropaHUB", "Hide": true },
|
||||||
{ "_id": { "$oid": "54a1737aeb658f6cbccf70ff" }, "Node": "ErisHUB", "Hide": true },
|
{ "_id": { "$oid": "54a1737aeb658f6cbccf70ff" }, "Node": "ErisHUB", "Hide": true },
|
||||||
{ "_id": { "$oid": "54a736ddec12f80bd6e9e326" }, "Node": "VenusHUB", "Hide": true },
|
{ "_id": { "$oid": "54a736ddec12f80bd6e9e326" }, "Node": "VenusHUB", "Hide": true },
|
||||||
{ "_id": { "$oid": "5ad9f9bb6df82a56eabf3d44" }, "Node": "SolNode802", "Seed": 9969639 },
|
|
||||||
{
|
{
|
||||||
"_id": { "$oid": "5b8817c2bd4f253264d6aa91" },
|
"_id": { "$oid": "5b8817c2bd4f253264d6aa91" },
|
||||||
"Node": "EarthHUB",
|
"Node": "EarthHUB",
|
||||||
@ -1103,10 +1086,7 @@
|
|||||||
"ConstructionProjects": [],
|
"ConstructionProjects": [],
|
||||||
"TwitchPromos": [],
|
"TwitchPromos": [],
|
||||||
"ExperimentRecommended": [],
|
"ExperimentRecommended": [],
|
||||||
"EndlessXpChoices": [
|
"EndlessXpChoices": [],
|
||||||
{ "Category": "EXC_NORMAL", "Choices": ["Gara", "Khora", "Revenant"] },
|
|
||||||
{ "Category": "EXC_HARD", "Choices": ["Zylok", "Sibear", "Dread", "Despair", "Hate"] }
|
|
||||||
],
|
|
||||||
"ForceLogoutVersion": 0,
|
"ForceLogoutVersion": 0,
|
||||||
"SeasonInfo": {
|
"SeasonInfo": {
|
||||||
"Activation": { "$date": { "$numberLong": "1715796000000" } },
|
"Activation": { "$date": { "$numberLong": "1715796000000" } },
|
||||||
|
|||||||
🛠️ Refactor suggestion
Externalize or document large choice arrays
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.
🛠️ Refactor suggestion
Externalize or document large choice arrays
The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.