OpenWF/SpaceNinjaServer
21
24
Fork 24
Code Issues 22 Pull Requests 4 Actions Packages Projects Releases Activity

feat: dynamically cycle ESO, holdfast bounties, hex bounties, & circuit choices #643

Merged
Sainan merged 2 commits from worldstate into main 2024-12-28 09:30:43 -08:00
Conversation 3 Commits 2 Files Changed 2 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7e23925e5c - Show all commits

2
src/controllers/dynamic/worldStateController.ts
View File

@ -43,7 +43,7 @@ export const worldStateController: RequestHandler = (req, res) => {
coderabbitai[bot] commented 2024-12-28 00:43:25 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Externalize or document large choice arrays

The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.

_:hammer_and_wrench: Refactor suggestion_ **Externalize or document large choice arrays** The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. <!-- This is an auto-generated comment by CodeRabbit -->
coderabbitai[bot] commented 2024-12-28 00:43:25 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Externalize or document large choice arrays

The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.

_:hammer_and_wrench: Refactor suggestion_ **Externalize or document large choice arrays** The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. <!-- This is an auto-generated comment by CodeRabbit -->
Nodes: [] Nodes: []
}); });
// Circuit warframe choices cycling every week // Circuit choices cycling every week
coderabbitai[bot] commented 2024-12-28 00:43:25 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Externalize or document large choice arrays

The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.

_:hammer_and_wrench: Refactor suggestion_ **Externalize or document large choice arrays** The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. <!-- This is an auto-generated comment by CodeRabbit -->
coderabbitai[bot] commented 2024-12-28 00:43:25 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Externalize or document large choice arrays

The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.

_:hammer_and_wrench: Refactor suggestion_ **Externalize or document large choice arrays** The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. <!-- This is an auto-generated comment by CodeRabbit -->
worldState.EndlessXpChoices.push({ worldState.EndlessXpChoices.push({
Category: "EXC_NORMAL", Category: "EXC_NORMAL",
Choices: [ Choices: [

coderabbitai[bot] commented 2024-12-28 00:43:25 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Externalize or document large choice arrays

The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.

_:hammer_and_wrench: Refactor suggestion_ **Externalize or document large choice arrays** The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. <!-- This is an auto-generated comment by CodeRabbit -->
coderabbitai[bot] commented 2024-12-28 00:43:25 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Externalize or document large choice arrays

The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance.

_:hammer_and_wrench: Refactor suggestion_ **Externalize or document large choice arrays** The logic for “EXC_NORMAL” and “EXC_HARD” is sound, but the large hardcoded arrays can be difficult to manage or update later. Consider externalizing them into a config file or module for easier maintenance. <!-- This is an auto-generated comment by CodeRabbit -->