OpenWF/SpaceNinjaServer
28
29
Fork 36
Code Issues 29 Pull Requests 5 Actions Packages Projects Releases Activity

fix: selling items in old builds #3023

Merged
Sainan merged 4 commits from VoltPrime/SpaceNinjaServer:sell-fix into main 2025-11-14 01:50:03 -08:00
Conversation 2 Commits 4 Files Changed 1 +28 -12
VoltPrime commented 2025-11-11 14:06:12 -08:00
Contributor
Copy Link

I'm not sure exactly which build the sell request changed in, but this solution seems to be catch-all.

I'm not sure exactly which build the sell request changed in, but this solution seems to be catch-all.
VoltPrime added 2 commits 2025-11-11 14:06:13 -08:00
fix: selling items in old builds 8996ec7912
Only check legacy conditions if SellCurrency is absent
Some checks failed
Build / build (pull_request) Failing after 1m15s
Details
9c70e90db6
Sainan commented 2025-11-11 23:11:09 -08:00
Owner
Copy Link

Looks okay, but please do npm run fix

Looks okay, but please do `npm run fix`
VoltPrime added 1 commit 2025-11-12 12:03:08 -08:00
merge upstream
Some checks failed
Build / build (pull_request) Failing after 2m4s
Details
ba1d1c8917
VoltPrime added 1 commit 2025-11-12 14:21:50 -08:00
run fix
All checks were successful
Build / build (pull_request) Successful in 3m48s
Details
bc18f4e656
Sainan approved these changes 2025-11-13 00:18:28 -08:00
Sainan merged commit 8a0f99f573 into main 2025-11-14 01:50:03 -08:00
Sainan deleted branch sell-fix 2025-11-14 01:50:04 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 enhancement
New feature or request specific to the emulator
 help wanted
Extra attention is needed
 improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
 pr'd for
Soon™
 question
Further information is requested
 unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
AMelonInsideLemon Ember OrdisPrime Sainan
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#3023
Delete Branch "VoltPrime/SpaceNinjaServer:sell-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?