OpenWF/SpaceNinjaServer
28
29
Fork 36
Code Issues 29 Pull Requests 5 Actions Packages Projects Releases Activity

fix: incubator after PE+ update #3011

Merged
Sainan merged 1 commits from fix-incubating into main 2025-11-10 00:43:30 -08:00
Conversation 2 Commits 1 Files Changed 1 +4 -1
Sainan commented 2025-11-09 04:23:51 -08:00
Owner
Copy Link

Seems the kubrow egg item type was changed in U40.

Seems the kubrow egg item type was changed in U40.
Sainan added 1 commit 2025-11-09 04:23:52 -08:00
fix: incubator after PE+ update
All checks were successful
Build / build (pull_request) Successful in 2m1s
Details
83447bb8b6 
Seems the kubrow egg item type was changed in U40.
Sainan merged commit 3d57a76ee6 into main 2025-11-10 00:43:30 -08:00
Sainan deleted branch fix-incubating 2025-11-10 00:43:30 -08:00
yhhkevin commented 2025-11-10 06:57:18 -08:00
First-time contributor
Copy Link

maybe the inventoryService.ts(811) needs to fix too.(i can't read the code well), after fix the startRecipeController.ts, i still have problem in kubrow. i can't open the kubrow recipe unit now and no error log shows the problem. also, getting kubrow egg in webui and store in game will not create item in the inventories/kubrowpetEggs. getting kubrow egg only run right in the mission.

maybe the inventoryService.ts(811) needs to fix too.(i can't read the code well), after fix the startRecipeController.ts, i still have problem in kubrow. i can't open the kubrow recipe unit now and no error log shows the problem. also, getting kubrow egg in webui and store in game will not create item in the inventories/kubrowpetEggs. getting kubrow egg only run right in the mission.
Sainan commented 2025-11-10 08:18:18 -08:00
Author
Owner
Copy Link

Ah yeah good catch about addItem

Ah yeah good catch about addItem
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 enhancement
New feature or request specific to the emulator
 help wanted
Extra attention is needed
 improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
 pr'd for
Soon™
 question
Further information is requested
 unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
AMelonInsideLemon Ember OrdisPrime Sainan
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#3011
Delete Branch "fix-incubating"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?