fix: junction completion on steel path doesn't save #2937

Merged

Sainan merged 2 commits from sp-junction-fix into main 2025-10-25 00:27:03 -07:00

Conversation 0 Commits 2 Files Changed 2 +4 -4

Sainan commented 2025-10-24 07:00:26 -07:00

Owner

Copy Link

Aka., an alternative approach to fixing the problem in #2866. Junctions don't have RewardInfo and therefore weren't reaching the new call to addMissionComplete.

Aka., an alternative approach to fixing the problem in #2866. Junctions don't have RewardInfo and therefore weren't reaching the new call to addMissionComplete.

Sainan added 2 commits 2025-10-24 07:00:27 -07:00

Revert "fix: only commit 'Missions' on successful completion (#2866)" ... 51dad17ae1

This reverts commit f5c1b8359895df5966c50d9a6aac733b22c25450.

fix: junction completion on steel path doesn't save 799e530bef

Sainan merged commit 23abe5de02 into main 2025-10-25 00:27:03 -07:00

Sainan referenced this issue from a commit 2025-10-25 00:27:05 -07:00

fix: junction completion on steel path doesn't save (#2937)

Sainan deleted branch sp-junction-fix 2025-10-25 00:27:07 -07:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

An existing implemention is incorrect

dependencies

Pull requests that update a dependency file

documentation

Improvements or additions to documentation

enhancement

New feature or request specific to the emulator

help wanted

Extra attention is needed

improvement

missing data

part of more major rehaul

Can't be worked on right now without merge conflicts later

pr'd for

Soon™

question

Further information is requested

unimplemented

you can do this

Considered easy enough for someone's first PR.

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2937

No description provided.