OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

chore(webui): fix inconsistent strings in dropdown menu #2895

Merged
Sainan merged 6 commits from Animan8000/SpaceNinjaServer:fix_casing into main 2025-10-13 05:21:23 -07:00
Conversation 6 Commits 6 Files Changed 6 +12 -12
Animan8000 commented 2025-10-12 08:12:13 -07:00
Contributor
Copy Link

Some dropdown menus are a mix of lower & uppercase words like this: image.png

This should look cleaner (aside the "Pre" did lack a dash before): {BCAD783C-AA7A-4E82-9A2E-5CAEA3A81ED2}.png

Some dropdown menus are a mix of lower & uppercase words like this: ![image.png](/attachments/b93a2fab-cf40-4fec-b699-e2a931e9173e) This should look cleaner (aside the "Pre" did lack a dash before): <img width="235" alt="{BCAD783C-AA7A-4E82-9A2E-5CAEA3A81ED2}.png" src="attachments/96108ef5-b58f-4cee-aa59-63b61b957a46">
{BCAD783C-AA7A-4E82-9A2E-5CAEA3A81ED2}.png
5.9 KiB
image.png
6.3 KiB
Animan8000 added 2 commits 2025-10-12 08:12:14 -07:00
static/webui/translations/de.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m40s
Details
e4fde73606
Sainan commented 2025-10-12 08:14:27 -07:00
Owner
Copy Link

You should probably reset the translations as it was already translated in a few languages with the incorrect casing

You should probably reset the translations as it was already translated in a few languages with the incorrect casing
Animan8000 changed title from chore(webui): fix inconsistent strings in dropdown menu to WIP: chore(webui): fix inconsistent strings in dropdown menu 2025-10-12 09:45:00 -07:00
Animan8000 added 1 commit 2025-10-12 10:03:34 -07:00
static/webui/translations/es.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m41s
Details
bdc7c30a85
Animan8000 added 1 commit 2025-10-12 10:04:25 -07:00
static/webui/translations/fr.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m2s
Details
127073aca3
Animan8000 changed title from WIP: chore(webui): fix inconsistent strings in dropdown menu to chore(webui): fix inconsistent strings in dropdown menu 2025-10-12 10:05:35 -07:00
Animan8000 commented 2025-10-12 10:08:14 -07:00
Author
Contributor
Copy Link

Should I reset all? I just quickly adjusted the existing ones but idk about ru, uk & zh tho...

Last time there was also a little bit of criticism regarding me resetting/untranslating existing stuff (which is understandable to some extent of course), but lemme know

Should I reset all? I just quickly adjusted the existing ones but idk about ru, uk & zh tho... Last time there was also a little bit of criticism regarding me resetting/untranslating existing stuff (which is understandable to some extent of course), but lemme know
Sainan commented 2025-10-12 10:33:29 -07:00
Owner
Copy Link

и -> И
д -> Д

Chinese is fine, there's no such thing as captialisation there.

и -> И д -> Д Chinese is fine, there's no such thing as captialisation there.
Animan8000 added 1 commit 2025-10-12 10:48:41 -07:00
static/webui/translations/ru.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m41s
Details
ce9b1c0de5
Animan8000 added 1 commit 2025-10-12 10:52:15 -07:00
static/webui/translations/uk.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m40s
Details
7dfb5e1771
Animan8000 commented 2025-10-12 10:55:40 -07:00
Author
Contributor
Copy Link

Done. I also changed з to З in the uk file. Apparently that's the uppercase letter that would normally be used in that context. If you have time @LoseFace feel free to lemme know if this is correct or not, just to be extra safe with the change here.

Done. I also changed `з` to `З` in the uk file. Apparently that's the uppercase letter that would normally be used in that context. If you have time @LoseFace feel free to lemme know if this is correct or not, just to be extra safe with the change here.
AMelonInsideLemon commented 2025-10-12 11:00:07 -07:00
Member
Copy Link

з -> З is correct

`з` -> `З` is correct
👍 1
Sainan approved these changes 2025-10-12 11:58:24 -07:00
Sainan merged commit fd7ddd9696 into main 2025-10-13 05:21:23 -07:00
Sainan deleted branch fix_casing 2025-10-13 05:21:23 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2895
No description provided.
Delete Branch "Animan8000/SpaceNinjaServer:fix_casing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?