OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 25 Pull Requests 2 Actions Packages Projects Releases Activity

chore(webui): use consistent/correct year order for Wolf Hunt dropdown menu #2890

Closed
Animan8000 wants to merge 2 commits from Animan8000:wolfOrder into main
pull from: Animan8000:wolfOrder
merge into: OpenWF:main
Conversation 3 Commits 2 Files Changed 2 +43 -43
Animan8000 commented 2025-10-11 11:50:29 -07:00
Contributor
Copy Link

Currently in the WebUI the year order of the Wolf Hunt dropdown menu is not consistent to other events that have a year dropdown menu. {2C761E0B-77FF-46CD-9CFF-923A86254FBE}.png

On Wolf Hunt it currently goes from oldest to latest, rather than the other way around. This PR fixes the small inconsistency while keeping the 2025 event the default one.

Currently in the WebUI the year order of the Wolf Hunt dropdown menu is not consistent to other events that have a year dropdown menu. <img width="432" alt="{2C761E0B-77FF-46CD-9CFF-923A86254FBE}.png" src="attachments/62ef6aeb-f019-4807-a788-53cd1bc7baa7"> On Wolf Hunt it currently goes from oldest to latest, rather than the other way around. This PR fixes the small inconsistency while keeping the 2025 event the default one.
{2C761E0B-77FF-46CD-9CFF-923A86254FBE}.png
6.6 KiB
Animan8000 added 2 commits 2025-10-11 11:50:30 -07:00
src/services/worldStateService.ts aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m40s
Details
efa02dd40c
Sainan commented 2025-10-11 11:57:19 -07:00
Owner
Copy Link

I agree, but let's keep the values meaning the same as they did before

I agree, but let's keep the values meaning the same as they did before
Animan8000 commented 2025-10-11 12:01:32 -07:00
Author
Contributor
Copy Link

I agree, but let's keep the values meaning the same as they did before

That would activate Wolf 2019 as the default one (line 2366 & 2367), if you activate the event the first time in WebUI (while also not having a value present in config.json in advance yet). I intentionally swapped the values to keep the identical behavior (2025 being the default one like before), while also fixing the dropdown menu visually.

> I agree, but let's keep the values meaning the same as they did before That would activate Wolf 2019 as the default one (line 2366 & 2367), if you activate the event the first time in WebUI (while also not having a value present in config.json in advance yet). I intentionally swapped the values to keep the identical behavior (2025 being the default one like before), while also fixing the dropdown menu visually.
Sainan commented 2025-10-11 12:04:05 -07:00
Owner
Copy Link

there's no 'default one', I just want you to revert worldStateService and also swap the value

this whole PR could've been Ctrl+Shift+Arrow Down

there's no 'default one', I just want you to revert worldStateService and also swap the value this whole PR could've been Ctrl+Shift+Arrow Down
Sainan closed this pull request 2025-10-11 12:06:12 -07:00
All checks were successful
Build / build (pull_request) Successful in 1m40s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2890
No description provided.
Delete Branch "Animan8000:wolfOrder"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?