chore: explicitly declare body-parser dependency for pnpm #2873

Merged

Sainan merged 3 commits from MindXL/SpaceNinjaServer:main into main 2025-10-07 23:21:18 -07:00

Conversation 6 Commits 3 Files Changed 2 +4

MindXL commented 2025-10-07 06:07:22 -07:00

Contributor

Copy Link

An error was reported when running build:

src/app.ts:3:24 - error TS2307: Cannot find module 'body-parser' or its corresponding type declarations.

3 import bodyParser from "body-parser";

An error was reported when running build: > src/app.ts:3:24 - error TS2307: Cannot find module 'body-parser' or its corresponding type declarations. > > 3 import bodyParser from "body-parser";

MindXL added 1 commit 2025-10-07 06:07:22 -07:00

fix(depend): add missing module before run build script edb42cee0d

Sainan commented 2025-10-07 06:14:08 -07:00

Owner

Copy Link

body-parser is a dependency of express, so it should be installed with npm i or npm ci. I certainly wonder how you managed to fuck it up.

body-parser is a dependency of express, so it should be installed with `npm i` or `npm ci`. I certainly wonder how you managed to fuck it up.

Sainan closed this pull request 2025-10-07 06:14:08 -07:00

MindXL commented 2025-10-07 06:27:44 -07:00

Author

Contributor

Copy Link

Try pnpm i. Pnpm did not install body-parse when I'm exploring.

Try `pnpm i`. Pnpm did not install `body-parse` when I'm exploring.

Sainan commented 2025-10-07 06:30:43 -07:00

Owner

Copy Link

Does the guide say to use pnpm or npm? :)

Does the guide say to use `pnpm` or `npm`? :)

Sainan commented 2025-10-07 06:31:43 -07:00

Owner

Copy Link

Also, in general, building is not needed anymore unless you're on a super old Node version.

Also, in general, building is not needed anymore unless you're on a super old Node version.

Sainan reopened this pull request 2025-10-07 06:33:25 -07:00

Sainan changed title from fix(depend): add missing module before run build script to chore: explicitly declare body-parser dependency for pnpm 2025-10-07 06:33:46 -07:00

Sainan added 2 commits 2025-10-07 06:37:25 -07:00

move types dep to optionalDependencies 828356e607

update package-lock de689649ce

Sainan approved these changes 2025-10-07 06:37:56 -07:00

MindXL commented 2025-10-07 06:50:18 -07:00

Author

Contributor

Copy Link

I merely use pnpm to manage modules. After cloning this repo, I ran pnpm i and then pnpm run build (or pnpm run raw, or something similar). Both pnpm and VSCode reported missing modules. I thought this might be an issue that others might run into and might need a fix for. But in the end, it's OK if we look at this in a different way. It depends on your perspective.

I merely use `pnpm` to manage modules. After cloning this repo, I ran `pnpm i` and then `pnpm run build` (or `pnpm run raw`, or something similar). Both pnpm and VSCode reported missing modules. I thought this might be an issue that others might run into and might need a fix for. But in the end, it's OK if we look at this in a different way. It depends on your perspective.

Sainan merged commit 6a571e5e78 into main 2025-10-07 23:21:18 -07:00

Sainan referenced this issue from a commit 2025-10-07 23:21:20 -07:00

chore: explicitly declare body-parser dependency for pnpm (#2873)

Sign in to join this conversation.

Reviewers

No Reviewers

Sainan

Labels

Clear labels

bug

An existing implemention is incorrect

dependencies

Pull requests that update a dependency file

documentation

Improvements or additions to documentation

enhancement

New feature or request specific to the emulator

help wanted

Extra attention is needed

improvement

missing data

part of more major rehaul

Can't be worked on right now without merge conflicts later

pr'd for

Soon™

question

Further information is requested

unimplemented

you can do this

Considered easy enough for someone's first PR.

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2873

No description provided.