OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

chore(webui): stick from on top in acquire cards #2802

Merged
Sainan merged 4 commits from AMelonInsideLemon/SpaceNinjaServer:webui-sticky-top into main 2025-09-22 04:42:47 -07:00
Conversation 10 Commits 4 Files Changed 2 +157 -120
AMelonInsideLemon commented 2025-09-20 12:23:27 -07:00
Member
Copy Link

Also use d-none instead style="display: none;" in modular cards

Also use `d-none` instead `style="display: none;"` in modular cards
AMelonInsideLemon added 1 commit 2025-09-20 12:23:28 -07:00
chore(webui): stick from on top in acquire cards
All checks were successful
Build / build (pull_request) Successful in 1m28s
Details
a6c26765ca 
Also use `d-none` instead `style="display: none;"` in modular cards
Sainan commented 2025-09-20 12:29:29 -07:00
Owner
Copy Link

Not sure what the intended effect here is, but all I can see is that now this happens

image.png

Not sure what the intended effect here is, but all I can see is that now this happens ![image.png](/attachments/0ca670e2-d099-42a6-be14-731dc36bb905)
image.png
6.1 KiB
AMelonInsideLemon added 1 commit 2025-09-20 12:35:23 -07:00
use fixed-top on navbar instead sticky-top
All checks were successful
Build / build (pull_request) Successful in 2m37s
Details
c1a3439aac
AMelonInsideLemon commented 2025-09-20 12:36:21 -07:00
Author
Member
Copy Link

Nope, that not intended i think this should fix it

Nope, that not intended i think this should fix it
AMelonInsideLemon commented 2025-09-20 12:46:34 -07:00
Author
Member
Copy Link

That made it even worse

That made it even worse
AMelonInsideLemon changed title from chore(webui): stick from on top in acquire cards to WIP: chore(webui): stick from on top in acquire cards 2025-09-20 12:47:00 -07:00
AMelonInsideLemon added 1 commit 2025-09-20 12:49:40 -07:00
set higher z-index for navbar
All checks were successful
Build / build (pull_request) Successful in 1m13s
Details
d67b27e680
AMelonInsideLemon changed title from WIP: chore(webui): stick from on top in acquire cards to chore(webui): stick from on top in acquire cards 2025-09-20 12:50:17 -07:00
Sainan commented 2025-09-20 13:33:40 -07:00
Owner
Copy Link

Still see no change in the WebUI. What's supposed to be different now?

Still see no change in the WebUI. What's supposed to be different now?
AMelonInsideLemon commented 2025-09-20 13:41:06 -07:00
Author
Member
Copy Link

I don't have this problem in either Firefox or Chrome.
image.png
image.png

I don't have this problem in either Firefox or Chrome. ![image.png](/attachments/a697c778-c952-4203-a17e-b2977ae350bf) ![image.png](/attachments/d68ef75a-652b-4772-9aa0-6b4714e380fc)
image.png
40 KiB
image.png
38 KiB
Sainan commented 2025-09-20 13:42:05 -07:00
Owner
Copy Link

I'm asking why you made these changes to the code because there's no visual difference that I can tell.

I'm asking why you made these changes to the code because there's no visual difference that I can tell.
Sainan commented 2025-09-20 13:42:50 -07:00
Owner
Copy Link

I'm in favour of you using d-none instead of inline styles, but decouple it from whatever this is.

I'm in favour of you using `d-none` instead of inline styles, but decouple it from whatever this is.
AMelonInsideLemon commented 2025-09-20 13:47:22 -07:00
Author
Member
Copy Link

I'm asking why you made these changes to the code because there's no visual difference that I can tell.

Without that changes you need to scroll up if you what to add something.
image.png
With that changes you always have fast access to add item from.
image.png

> I'm asking why you made these changes to the code because there's no visual difference that I can tell. Without that changes you need to scroll up if you what to add something. ![image.png](/attachments/ef296ef4-2ba5-4dea-a72c-a899fc5cca2a) With that changes you always have fast access to add item from. ![image.png](/attachments/aed992a2-a303-4599-a98a-d35684e0217a)
image.png
22 KiB
image.png
20 KiB
Sainan commented 2025-09-20 13:53:24 -07:00
Owner
Copy Link

I still don't get why it needs any of this 'sticky' stuff. It's definitely not sticky. That's overflow.

I still don't get why it needs any of this 'sticky' stuff. It's definitely not sticky. That's overflow.
AMelonInsideLemon added 1 commit 2025-09-20 14:33:42 -07:00
remove sticky-top and overflow-hidden
All checks were successful
Build / build (pull_request) Successful in 1m0s
Details
a87aa89e40
Sainan approved these changes 2025-09-21 02:52:53 -07:00
Sainan merged commit 6f8b14fb2d into main 2025-09-22 04:42:47 -07:00
Sainan deleted branch webui-sticky-top 2025-09-22 04:42:47 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2802
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:webui-sticky-top"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?