OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

fix: correct checks for quest replay #2798

Merged
Sainan merged 3 commits from AMelonInsideLemon/SpaceNinjaServer:fix-replay into main 2025-09-21 02:53:06 -07:00
Conversation 2 Commits 3 Files Changed 3 +11 -11
AMelonInsideLemon commented 2025-09-19 23:08:36 -07:00
Member
Copy Link

Closes #2797

Closes #2797
AMelonInsideLemon added 1 commit 2025-09-19 23:08:37 -07:00
fix: correct checks for quest replay
All checks were successful
Build / build (pull_request) Successful in 1m19s
Details
2336c3018a 
Closes #2797
Sainan reviewed 2025-09-20 00:28:39 -07:00
src/services/questService.ts Outdated
@ -303,3 +303,3 @@
let inventoryChanges: IInventoryChanges = {};
if (!isRerun) {
if (isRerun) {
Sainan commented 2025-09-20 00:28:39 -07:00
Owner
Copy Link

Can't we use stage i to track items were already given?

Can't we use stage `i` to track items were already given?
Sainan marked this conversation as resolved
AMelonInsideLemon added 1 commit 2025-09-20 01:06:32 -07:00
check values directly in questKey
Some checks failed
Build / build (pull_request) Failing after 1m16s
Details
34a23aa2dc
Sainan approved these changes 2025-09-20 01:08:00 -07:00
AMelonInsideLemon added 1 commit 2025-09-20 01:09:14 -07:00
lint
All checks were successful
Build / build (pull_request) Successful in 1m31s
Details
5d0ee2fc05
Sainan merged commit 87da94658d into main 2025-09-21 02:53:06 -07:00
Sainan deleted branch fix-replay 2025-09-21 02:53:09 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2798
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:fix-replay"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?