OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

chore(webui): exclude always available items from datalist #2783

Merged
Sainan merged 5 commits from AMelonInsideLemon/SpaceNinjaServer:exclude-from-add-missing into main 2025-09-16 23:24:00 -07:00
Conversation 4 Commits 5 Files Changed 4 +25 -18
AMelonInsideLemon commented 2025-09-15 10:58:44 -07:00
Member
Copy Link
No description provided.
AMelonInsideLemon added 1 commit 2025-09-15 10:58:44 -07:00
chore(webui): exclude always available items from Add Missing
Some checks failed
Build / build (pull_request) Failing after 25s
Details
c4c1bc68ca
AMelonInsideLemon added 1 commit 2025-09-15 11:06:05 -07:00
update pe+
All checks were successful
Build / build (pull_request) Successful in 2m28s
Details
7c4a7d7cf0
AMelonInsideLemon commented 2025-09-15 11:09:54 -07:00
Author
Member
Copy Link

Maybe better to put such items only into the itemMap without adding them to the datalist?

Maybe better to put such items only into the itemMap without adding them to the datalist?
Sainan commented 2025-09-15 11:12:03 -07:00
Owner
Copy Link

Yeah, perhaps, if acquiring these items would needlessly bloat the inventory.

Yeah, perhaps, if acquiring these items would needlessly bloat the inventory.
AMelonInsideLemon added 1 commit 2025-09-15 11:18:09 -07:00
don't put always available items into datalist
All checks were successful
Build / build (pull_request) Successful in 1m6s
Details
32983eae89
AMelonInsideLemon changed title from chore(webui): exclude always available items from `Add Missing` to chore(webui): exclude always available items from datalist 2025-09-15 11:18:37 -07:00
Sainan reviewed 2025-09-15 11:20:49 -07:00
src/controllers/custom/getItemListsController.ts Outdated
@ -459,2 +460,3 @@
name: getString(item.name, lang)
});
};
if (item.alwaysAvailable) flavourItem.alwaysAvailable = true;
Sainan commented 2025-09-15 11:20:49 -07:00
Owner
Copy Link

Redundant conditional since undefined will be passed on as undefined

Redundant conditional since undefined will be passed on as undefined
AMelonInsideLemon marked this conversation as resolved
AMelonInsideLemon added 1 commit 2025-09-15 11:23:48 -07:00
Update getItemListsController.ts
All checks were successful
Build / build (pull_request) Successful in 1m4s
Details
ece55d6bbc
Sainan approved these changes 2025-09-15 11:27:27 -07:00
AMelonInsideLemon added 1 commit 2025-09-15 12:07:40 -07:00
also don't add items with reAddToItemList
All checks were successful
Build / build (pull_request) Successful in 1m5s
Details
bcca4a8d3d
Sainan merged commit 6c2b7a61e2 into main 2025-09-16 23:24:00 -07:00
Sainan deleted branch exclude-from-add-missing 2025-09-16 23:24:00 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2783
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:exclude-from-add-missing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?