OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

feat(webui): guild view #2752

Merged
Sainan merged 18 commits from AMelonInsideLemon/SpaceNinjaServer:webui-guildView into main 2025-09-09 23:55:11 -07:00
Conversation 7 Commits 18 Files Changed 33 +1516 -192
AMelonInsideLemon commented 2025-09-05 16:29:05 -07:00
Member
Copy Link

Also moves guild-specific cheats to a switch for each guild
Closes #1403

Also moves guild-specific cheats to a switch for each guild Closes #1403
AMelonInsideLemon added 1 commit 2025-09-05 16:29:06 -07:00
feat(webui): guild view
Some checks failed
Build / build (pull_request) Failing after 2m6s
Details
901df3a4d4 
Also moves guild-specific cheats to a switch for each guild
Closes #1403
AMelonInsideLemon added 1 commit 2025-09-05 16:41:46 -07:00
hide guild navitem when we not in guild
All checks were successful
Build / build (pull_request) Successful in 1m54s
Details
d3bdf7fa7d
Sainan commented 2025-09-05 19:17:35 -07:00
Owner
Copy Link

I love me some all-in-1 PRs... have you considered how "skip clan key crafting" is gonna work for the creator of the guild?

I love me some all-in-1 PRs... have you considered how "skip clan key crafting" is gonna work for the creator of the guild?
Sainan changed title from feat(webui): guild view to WIP: feat(webui): guild view 2025-09-07 01:35:26 -07:00
AMelonInsideLemon added 1 commit 2025-09-07 19:48:54 -07:00
revert change to skipClanKeyCrafting cheat
All checks were successful
Build / build (pull_request) Successful in 1m58s
Details
210dcee384
AMelonInsideLemon commented 2025-09-07 19:50:21 -07:00
Author
Member
Copy Link

nope

nope
AMelonInsideLemon changed title from WIP: feat(webui): guild view to feat(webui): guild view 2025-09-07 19:51:12 -07:00
Sainan commented 2025-09-07 21:58:20 -07:00
Owner
Copy Link

Alright, actually looking at the webui, I do like this, but a few notes:

  • The tab really ought to be last since it's not always available, it's awkward that it shifts the tabs after itself
  • The padding on "Credits" and "Platinum" needs fixing when you have no permission to add them
  • PE+ 0.5.85 should have all the information you need to avoid the research and recipes having /Lotus/ strings
Alright, actually looking at the webui, I do like this, but a few notes: - The tab really ought to be last since it's not always available, it's awkward that it shifts the tabs after itself - The padding on "Credits" and "Platinum" needs fixing when you have no permission to add them - PE+ 0.5.85 should have all the information you need to avoid the research and recipes having `/Lotus/` strings
AMelonInsideLemon added 4 commits 2025-09-07 22:54:46 -07:00
move nav tab
All checks were successful
Build / build (pull_request) Successful in 58s
Details
db12537f4e
AMelonInsideLemon added 1 commit 2025-09-07 22:56:19 -07:00
revert
All checks were successful
Build / build (pull_request) Successful in 1m15s
Details
0dc6ca60e4
Sainan reviewed 2025-09-08 00:01:04 -07:00
static/webui/script.js Outdated
@ -1505,0 +1744,4 @@
event.preventDefault();
changeGuildRank(guildId, member._id.$oid, member.Rank + 1);
};
a.title = loc("code_rankDown");
Sainan commented 2025-09-08 00:01:04 -07:00
Owner
Copy Link

Promote/demote wording makes more sense

Promote/demote wording makes more sense
Sainan marked this conversation as resolved
Sainan added 1 commit 2025-09-08 07:27:16 -07:00
promote/demote
All checks were successful
Build / build (pull_request) Successful in 2m30s
Details
85aec688ec
Sainan approved these changes 2025-09-08 07:27:37 -07:00
Dismissed
AMelonInsideLemon added 1 commit 2025-09-08 08:12:41 -07:00
loc
All checks were successful
Build / build (pull_request) Successful in 1m41s
Details
fcfe81d585
AMelonInsideLemon added 1 commit 2025-09-08 14:58:37 -07:00
Update getItemListsController.ts
All checks were successful
Build / build (pull_request) Successful in 1m25s
Details
a2bdd9aaf8
AMelonInsideLemon added 1 commit 2025-09-08 15:06:41 -07:00
Update getItemListsController.ts
All checks were successful
Build / build (pull_request) Successful in 59s
Details
75804a012e
AMelonInsideLemon added 1 commit 2025-09-08 18:34:41 -07:00
add faction to gradivus dilemma trophy name
All checks were successful
Build / build (pull_request) Successful in 1m9s
Details
1d8ec5a551
Sainan reviewed 2025-09-08 20:32:37 -07:00
src/controllers/custom/getItemListsController.ts Outdated
@ -370,0 +418,4 @@
const factionTag = uniqueName.includes("Corpus") ? "FC_CORPUS" : "FC_GRINEER";
const faction = eFaction.find(f => f.tag === factionTag)?.name || factionTag;
name += ` [${getString(faction, lang)}]`;
console.log(uniqueName);
Sainan commented 2025-09-08 20:32:37 -07:00
Owner
Copy Link

Derp

Derp
Sainan marked this conversation as resolved
Sainan added 1 commit 2025-09-08 20:48:35 -07:00
remove console.log
All checks were successful
Build / build (pull_request) Successful in 1m17s
Details
32832d60e4
Sainan added 1 commit 2025-09-08 20:55:14 -07:00
posterity
All checks were successful
Build / build (pull_request) Successful in 1m1s
Details
394701c8b5
Sainan dismissed Sainan’s review 2025-09-08 20:55:20 -07:00
Sainan added 1 commit 2025-09-08 21:03:37 -07:00
update PE+
All checks were successful
Build / build (pull_request) Successful in 1m23s
Details
12505faffe
Sainan approved these changes 2025-09-08 21:04:16 -07:00
AMelonInsideLemon added 1 commit 2025-09-08 21:50:21 -07:00
use ExportFactions in Gradivus Dilema trophy instead eFaction
Some checks failed
Build / build (pull_request) Failing after 1m9s
Details
f5dd56b49b
AMelonInsideLemon added 1 commit 2025-09-08 21:51:37 -07:00
Update getItemListsController.ts
All checks were successful
Build / build (pull_request) Successful in 2m0s
Details
1a0896072a
Sainan merged commit d64531f4b2 into main 2025-09-09 23:55:11 -07:00
Sainan deleted branch webui-guildView 2025-09-09 23:55:14 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2752
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:webui-guildView"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?