feat: finishInvasionsInOneMission #2715
Sainan
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "AlexisinGit/SpaceNinjaServerAlexFork:finishOneInvasionFinishTheWholeThing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
#2646
This seems incomplete as you e.g. did not update the webui translation files to add your new string.
Cheat: finish One Invasion Finish The Whole Thingto WIP: Cheat: finish One Invasion Finish The Whole Thingshould i leave an empty string or?
No. Also DO NOT use AI translation in languages you are not familiar in. Use the
[UNTRANSLATED]thingy instead, for non-english strings.welp, this should work now.
Please use the update-translations script to properly populate the non-en files.
I didn't realize we have such tool. Is there anything else I should be paying attention to?
I mean, I question the quality of this contribution more than anything.
Is... there a reason to make it a multiplier? Invasions are always "complete at least 3 more missions for one side than the other", they're not variable, you don't get bigger rewards for doing more than 3 missions, and multiplying by 2 ends up quite awkward.
Well, the name of this option is quite awkward compared to e.g. "Invasion Progress Multiplier". And the implementation is a multiplier anyway, so could give the user more flexibility.
"Finish Invasions in One Mission" would definitely be less of a mouthful. And again I question the need for flexibility here. Having 0, 1 or 2 completed missions have the same end result of not qualifying for invasion pay. Having 3, 4, 5 or 99 all have the same end result of qualifying for invasion pay.
Plus since it's 3 invasions for pay, the only valid actual multipliers would be 1, 2 or 3, one of which is normal, one of which is instant completion, and the other is an extremely awkward middle ground I don't think users would actually care for if they're messing with faster invasion completions anyway.
I mean, users might want to have to do 2 invasion missions instead of 3 but not go all the way to 1 ?
Would they really, though? Given the relatively small difference between doing 2 vs 3 missions, compared to doing 1 vs 3 missions, if a user is annoyed enough by invasions to want to speed them up, chances are they want the bigger skip, not just skipping out on a single mission.
I'm still learning about account and server-wide cheats.
Meanwhile, I also don't think a multiplier would be the best idea. 0,1,2,3 is a lot more to comprehend than a toggle.
The issue is "finishing one invasion mission finishes it's whole thing" rather than "manipulate invasion score". I'm just making a cheat option that does the job. I don't think the name displayed on the UI needs to match its underlying logic, neither do users need to know how it is implemented.
like... for "Invasion Progress Multiplier" i would not be knowing what it does.
but for "Finish Invasions in One Mission" i would know. Because it's what i want to do.
WIP: Cheat: finish One Invasion Finish The Whole Thingto Cheat: finish One Invasion Finish The Whole ThingCheat: finish One Invasion Finish The Whole Thingto feat: finishInvasionsInOneMission