OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

feat(webui): display Favorite items first #2656

Merged
Sainan merged 2 commits from AMelonInsideLemon/SpaceNinjaServer:webui-show-favorite into main 2025-08-17 13:12:07 -07:00
Conversation 3 Commits 2 Files Changed 1 +155 -147
AMelonInsideLemon commented 2025-08-16 10:30:26 -07:00
Member
Copy Link

Closes #2653

Closes #2653
AMelonInsideLemon added 1 commit 2025-08-16 10:30:27 -07:00
feat(webui): display Favorite items first
All checks were successful
Build / build (pull_request) Successful in 1m4s
Details
94741cf22c 
Closes #2653
Sainan commented 2025-08-16 10:51:04 -07:00
Owner
Copy Link

The star being in front of the name looks a bit weird. Does it need to be displayed at all if there's no way to toggle it via WebUI? Hoisting seems sufficient.

The star being in front of the name looks a bit weird. Does it need to be displayed at all if there's no way to toggle it via WebUI? Hoisting seems sufficient.
AMelonInsideLemon added 1 commit 2025-08-16 13:19:51 -07:00
remove star
All checks were successful
Build / build (pull_request) Successful in 1m7s
Details
5d8f2a387e
AMelonInsideLemon commented 2025-08-16 13:22:07 -07:00
Author
Member
Copy Link

I think better to remove that star indicator because we already use star icon for Gild, and I can't imagine what icon could be used for this action.

I think better to remove that star indicator because we already use star icon for `Gild`, and I can't imagine what icon could be used for this action.
Sainan approved these changes 2025-08-16 13:24:57 -07:00
Sainan merged commit 024b806af1 into main 2025-08-17 13:12:07 -07:00
Sainan deleted branch webui-show-favorite 2025-08-17 13:12:07 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2656
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:webui-show-favorite"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?