OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

feat: getShip import #2627

Merged
Sainan merged 4 commits from AMelonInsideLemon/SpaceNinjaServer:getShip-import into main 2025-08-15 15:13:36 -07:00
Conversation 3 Commits 4 Files Changed 11 +101 -13
AMelonInsideLemon commented 2025-08-14 22:01:41 -07:00
Member
Copy Link

Re #2592
Unsure about import note, is it okay that we leave the API path?

Re #2592 Unsure about import note, is it okay that we leave the API path?
AMelonInsideLemon added 1 commit 2025-08-14 22:01:42 -07:00
feat: getShip import
Some checks failed
Build / build (pull_request) Failing after 52s
Details
c7258a9749 
Re #2592
Sainan commented 2025-08-14 22:06:18 -07:00
Owner
Copy Link

Looks good, but I would just say inventory.php and getShip.php without the leading / because that's slightly misleading. Also eslint failing.

Looks good, but I would just say `inventory.php` and `getShip.php` without the leading `/` because that's slightly misleading. Also eslint failing.
AMelonInsideLemon added 1 commit 2025-08-14 22:07:10 -07:00
eslint
All checks were successful
Build / build (pull_request) Successful in 1m2s
Details
1c6d4b1ac1
AMelonInsideLemon added 1 commit 2025-08-14 22:08:30 -07:00
remove /
All checks were successful
Build / build (pull_request) Successful in 1m1s
Details
1440e59362
Sainan commented 2025-08-14 22:10:52 -07:00
Owner
Copy Link

Just FYI you could've declared convertShip to take Partial<IOrbiterClient> to handle ShipInterior being absent without the linter saying "it can't be".

Just FYI you could've declared `convertShip` to take `Partial<IOrbiterClient>` to handle `ShipInterior` being absent without the linter saying "it can't be".
Sainan approved these changes 2025-08-14 22:11:01 -07:00
AMelonInsideLemon added 1 commit 2025-08-14 22:42:23 -07:00
FavouriteLoadouts may be undefined on live
All checks were successful
Build / build (pull_request) Successful in 1m28s
Details
ef4b083622
Sainan merged commit b0b68f474a into main 2025-08-15 15:13:36 -07:00
Sainan deleted branch getShip-import 2025-08-15 15:13:37 -07:00
Sainan referenced this issue from a commit 2025-08-15 15:13:38 -07:00
feat: getShip import (#2627)
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2627
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:getShip-import"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?