OpenWF/SpaceNinjaServer
21
23
Fork 29
Code Issues 23 Pull Requests 3 Actions Packages Projects Releases Activity

feat: recover nightwave challenges #2593

Merged
Sainan merged 3 commits from AMelonInsideLemon/SpaceNinjaServer:getPastWeeklyChallenges into main 2025-08-08 04:21:19 -07:00
Conversation 7 Commits 3 Files Changed 4 +122 -42
AMelonInsideLemon commented 2025-08-06 17:32:57 -07:00
Contributor
Copy Link

Closes #1534

Closes #1534
AMelonInsideLemon added 1 commit 2025-08-06 17:32:57 -07:00
feat: recover nightwave challenges
All checks were successful
Build / build (pull_request) Successful in 55s
Details
869ee9e2a2 
Closes #1534
Sainan reviewed 2025-08-06 17:48:02 -07:00
src/services/worldStateService.ts Outdated
@ -454,0 +442,4 @@
const nightwaveStartDate = new Date(nightwaveStartTimestamp);
const dayOffset = (nightwaveStartDate.getDay() + 6) % 7;
nightwaveStartDate.setDate(nightwaveStartDate.getDate() - dayOffset);
nightwaveStartDate.setHours(0, 0, 0, 0);
Sainan commented 2025-08-06 17:48:02 -07:00
Owner
Copy Link

This is dependent on local time.

This is dependent on local time.
Sainan commented 2025-08-06 17:49:22 -07:00
Owner
Copy Link

In general, you should be able to divide by 7 days, that's what the EPOCH is for. Otherwise, looks good.

In general, you should be able to divide by 7 days, that's what the EPOCH is for. Otherwise, looks good.
AMelonInsideLemon added 1 commit 2025-08-06 18:17:54 -07:00
use setUCT/getUTC
All checks were successful
Build / build (pull_request) Successful in 1m19s
Details
34fd8951f8
AMelonInsideLemon commented 2025-08-06 18:21:53 -07:00
Author
Contributor
Copy Link

In general, you should be able to divide by 7 days, that's what the EPOCH is for. Otherwise, looks good.

You are talking about that offset inside nightwaveWeekStart?

> In general, you should be able to divide by 7 days, that's what the EPOCH is for. Otherwise, looks good. You are talking about that offset inside `nightwaveWeekStart`?
Sainan commented 2025-08-06 18:50:24 -07:00
Owner
Copy Link

Yes, I don't see why you don't just use the existing logic to operate on the timestamp itself.

Yes, I don't see why you don't just use the existing logic to operate on the timestamp itself.
AMelonInsideLemon commented 2025-08-06 19:14:38 -07:00
Author
Contributor
Copy Link

Right now the Nightwave start date falls on Wednesday, but the rotation of challanges is Monday. And for this I move the nightwaveStartDate to Monday to get correct timestamp to calculate nightwave week number.

Right now the Nightwave start date falls on Wednesday, but the rotation of challanges is Monday. And for this I move the `nightwaveStartDate` to Monday to get correct timestamp to calculate nightwave week number.
Sainan commented 2025-08-06 19:35:09 -07:00
Owner
Copy Link

Modular arithmetic, my man.

local EPOCH = 1734307200000
local ts = 1747851300000 - EPOCH
ts -= (ts % 604800000)
print(EPOCH + ts) --> 1747612800000
Modular arithmetic, my man. ```lua local EPOCH = 1734307200000 local ts = 1747851300000 - EPOCH ts -= (ts % 604800000) print(EPOCH + ts) --> 1747612800000 ```
AMelonInsideLemon added 1 commit 2025-08-07 05:04:28 -07:00
use EPOCH instead of setUTC/getUTC
All checks were successful
Build / build (pull_request) Successful in 56s
Details
75faae583f
Sainan approved these changes 2025-08-07 12:31:10 -07:00
Sainan merged commit 679752633a into main 2025-08-08 04:21:19 -07:00
Sainan deleted branch getPastWeeklyChallenges 2025-08-08 04:21:20 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2593
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:getPastWeeklyChallenges"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?