OpenWF/SpaceNinjaServer
21
23
Fork 30
Code Issues 23 Pull Requests 6 Actions Packages Projects Releases Activity

WIP: add world Event add RecurringGhoul misson #2555

Closed
BanLanGen wants to merge 2 commits from BanLanGen/SpaceNinjaServer:main into main
pull from: BanLanGen/SpaceNinjaServer:main
merge into: OpenWF:main
Conversation 2 Commits 2 Files Changed 12 +557 -65
BanLanGen commented 2025-07-26 13:15:56 -07:00
First-time contributor
Copy Link

Add world event
Add RecurringGhoul mission
Add en language
TennoCon Relay not have change maby like ability videos need stripped assets
image.png

Add world event Add RecurringGhoul mission Add en language TennoCon Relay not have change maby like ability videos need stripped assets ![image.png](/attachments/f8f49518-231d-4fc5-851d-ac18b97c8106)
image.png
1.1 MiB
BanLanGen added 1 commit 2025-07-26 13:15:57 -07:00
add world Event add RecurringGhoul misson
Some checks failed
Build / build (pull_request) Failing after 1m25s
Details
d02fba869d
BanLanGen commented 2025-07-26 13:17:21 -07:00
Author
First-time contributor
Copy Link

image.png

![image.png](/attachments/16132415-bf12-4abe-a08d-3a770a4822a4)
image.png
4.0 MiB
BanLanGen added 1 commit 2025-07-26 21:02:03 -07:00
add world Event add RecurringGhoul misson
All checks were successful
Build / build (pull_request) Successful in 1m19s
Details
ffb3c01c80
Sainan commented 2025-07-27 06:26:32 -07:00
Owner
Copy Link

This PR does so much yet it accomplishes so little. Adding some goals to world state is great, but it's just gonna end up corrupting people's inventories if they earn a score but don't receive rewards. Also no regular rotation and instead requiring manual activation of these things is very unfaithful. For the tennocon relay, you could further provide an option to set it to the end state that is seen on live right now.

Focus on one thing and then do it well, otherwise this is unfortunately useless.

This PR does so much yet it accomplishes so little. Adding some goals to world state is great, but it's just gonna end up corrupting people's inventories if they earn a score but don't receive rewards. Also no regular rotation and instead requiring manual activation of these things is very unfaithful. For the tennocon relay, you could further provide an option to set it to the end state that is seen on live right now. Focus on one thing and then do it well, otherwise this is unfortunately useless.
Sainan changed title from add world Event add RecurringGhoul misson to WIP: add world Event add RecurringGhoul misson 2025-07-28 08:55:25 -07:00
BanLanGen closed this pull request 2025-07-29 00:59:19 -07:00
All checks were successful
Build / build (pull_request) Successful in 1m19s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2555
No description provided.
Delete Branch "BanLanGen/SpaceNinjaServer:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?