OpenWF/SpaceNinjaServer
22
24
Fork 25
Code Issues 20 Pull Requests 1 Actions Packages Projects Releases Activity

feat(webui): edit suit invigorations #2478

Merged
Sainan merged 12 commits from nyaoouo/SpaceNinjaServer:ImplEditSuitInvigorationUpgradeController into main 2025-07-14 20:33:38 -07:00
Conversation 10 Commits 12 Files Changed 10 -2
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fb7d5efa0a - Show all commits

2
static/webui/index.html
View File

@ -477,8 +477,6 @@
<tbody id="crystals-list"></tbody> <tbody id="crystals-list"></tbody>
</table> </table>
<form onsubmit="submitSuitInvigorationUpgrade(event)"> <form onsubmit="submitSuitInvigorationUpgrade(event)">
Sainan marked this conversation as resolved Outdated
Sainan commented 2025-07-13 21:07:01 -07:00
Outdated
Review
Copy Link

Why is this inside of the archon crystals card and not its own card?

Why is this inside of the archon crystals card and not its own card?
nyaoouo commented 2025-07-14 05:07:31 -07:00
Outdated
Review
Copy Link

Because I didn't realize that you used path route first and then only controlled visibility based on url params...

Because I didn't realize that you used path route first and then only controlled visibility based on url params...
<input type="hidden" id="dv-invigoration-oid" />
<div class="mb-3"> <div class="mb-3">
Sainan marked this conversation as resolved Outdated
Sainan commented 2025-07-12 21:16:43 -07:00
Outdated
Review
Copy Link

The oid is already in the query string. Be consistent.

The oid is already in the query string. Be consistent.
<label for="invigoration-offensive" class="form-label">Offensive Upgrade</label> <label for="invigoration-offensive" class="form-label">Offensive Upgrade</label>
<select class="form-select" id="dv-invigoration-offensive"> <select class="form-select" id="dv-invigoration-offensive">